Review Request 125551: Link to more libraries for dngwriter

[Dāvis Mosāns]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125551/

Review request for Digikam.

By Dāvis Mosāns.

Repository: digikam

Description

Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as
../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'


This RR fixes it by linking to those required libraries.

Testing

Compiles

Diffs

• libs/3rdparty/dngwriter/CMakeLists.txt (cc82d0a0c1713d7eab5b53d81c263056d5c88fd7)
• libs/3rdparty/dngwriter/tests/CMakeLists.txt (7fd6136ee652bc3822fc0228059bc84d5302af19)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125551/

the current implementation fix the problem. please try again

- Gilles Caulier

On October 8th, 2015, 12:32 a.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Oct. 8, 2015, 12:32 a.m.

Repository: digikam

Description

Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as
../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'


This RR fixes it by linking to those required libraries.

Testing

Compiles

Diffs

• libs/3rdparty/dngwriter/CMakeLists.txt (cc82d0a0c1713d7eab5b53d81c263056d5c88fd7)
• libs/3rdparty/dngwriter/tests/CMakeLists.txt (7fd6136ee652bc3822fc0228059bc84d5302af19)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dāvis Mosāns]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125551/

This change has been discarded.

Review request for Digikam.

By Dāvis Mosāns.

Updated Oct. 14, 2015, 9:52 p.m.

Repository: digikam

Description

Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as
../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'


This RR fixes it by linking to those required libraries.

Testing

Compiles

Diffs

• libs/3rdparty/dngwriter/CMakeLists.txt (cc82d0a0c1713d7eab5b53d81c263056d5c88fd7)
• libs/3rdparty/dngwriter/tests/CMakeLists.txt (7fd6136ee652bc3822fc0228059bc84d5302af19)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dāvis Mosāns]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125551/

On oktobris 14th, 2015, 1:58 p.m. EEST, Gilles Caulier wrote:

the current implementation fix the problem. please try again

cool, thanks :)

- Dāvis

On oktobris 14th, 2015, 9:52 p.m. EEST, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Oct. 14, 2015, 9:52 p.m.

Repository: digikam

Description

Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as
../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'


This RR fixes it by linking to those required libraries.

Testing

Compiles

Diffs

• libs/3rdparty/dngwriter/CMakeLists.txt (cc82d0a0c1713d7eab5b53d81c263056d5c88fd7)
• libs/3rdparty/dngwriter/tests/CMakeLists.txt (7fd6136ee652bc3822fc0228059bc84d5302af19)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel