Review Request 125384: Use FindPkgConfig instead of obsolete PKGCONFIG

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 125384: Use FindPkgConfig instead of obsolete PKGCONFIG

Dāvis Mosāns
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125384/

Review request for Digikam.
By Dāvis Mosāns.
Repository: digikam

Description

CMake shows

-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig

This fixes it and seems to work, but I don't really know if this is correct...

Testing

CMake completes without this warning

Diffs

  • cmake/modules/FindLqr-1.cmake (83341311cf87ea331452898abeb0626aceddb9eb)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125384: Use FindPkgConfig instead of obsolete PKGCONFIG

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125384/

Ship it!

Ship It!

- Gilles Caulier


On September 24th, 2015, 8:11 p.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.
By Dāvis Mosāns.

Updated Sept. 24, 2015, 8:11 p.m.

Repository: digikam

Description

CMake shows

-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig

This fixes it and seems to work, but I don't really know if this is correct...

Testing

CMake completes without this warning

Diffs

  • cmake/modules/FindLqr-1.cmake (83341311cf87ea331452898abeb0626aceddb9eb)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125384: Use FindPkgConfig instead of obsolete PKGCONFIG

Dāvis Mosāns
In reply to this post by Dāvis Mosāns
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125384/

This change has been marked as submitted.


Review request for Digikam.
By Dāvis Mosāns.

Updated Sept. 24, 2015, 8:54 p.m.

Changes

Submitted with commit f4a89cfa7df47ae9bd183c4a6515a727008dbf30 by Gilles Caulier to branch master.
Repository: digikam

Description

CMake shows

-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig

This fixes it and seems to work, but I don't really know if this is correct...

Testing

CMake completes without this warning

Diffs

  • cmake/modules/FindLqr-1.cmake (83341311cf87ea331452898abeb0626aceddb9eb)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel