Review Request 122968: Fix frameworks build wrt to definition of HUGE

[Marko Käning]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122968/

Review request for Digikam and Veaceslav Munteanu.

By Marko Käning.

Repository: kipi-plugins

Description

Building on OSX/CI failed for kipi-plugins due to missing definition of HUGE.
Turns out this is just a porting issue, leaving branch 'frameworks' incomplete for KF5.
The relevant commit on branch 'master' is 535f6b390f1924d3222c47cb15d756ba7be86ffc.

Testing

Does not fail on 'frameworks' anymore because of HUGE, since it is now also using LARGE instead.

Diffs

• sendimages/settingswidget.cpp (69e3794f80fd3b2328234e4c80d00c5f7ac82889)
• sendimages/emailsettings.h (5d0283fbc5102274593819257b2a0da9ee5333be)
• .reviewboardrc (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marko Käning]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122968/

This change has been marked as submitted.

Review request for Digikam and Veaceslav Munteanu.

By Marko Käning.

Updated March 15, 2015, 7:01 p.m.

Repository: kipi-plugins

Description

Building on OSX/CI failed for kipi-plugins due to missing definition of HUGE.
Turns out this is just a porting issue, leaving branch 'frameworks' incomplete for KF5.
The relevant commit on branch 'master' is 535f6b390f1924d3222c47cb15d756ba7be86ffc.

Testing

Does not fail on 'frameworks' anymore because of HUGE, since it is now also using LARGE instead.

Diffs

• sendimages/settingswidget.cpp (69e3794f80fd3b2328234e4c80d00c5f7ac82889)
• sendimages/emailsettings.h (5d0283fbc5102274593819257b2a0da9ee5333be)
• .reviewboardrc (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel