Review Request 119504: Allow searching for libkface using find_package, but without the FindKface.cmake module

[Johannes Zarl-2]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119504/

Review request for Digikam.

By Johannes Zarl.

Repository: libkface

Description

Implement KfaceConfig.cmake with imported targets.
This patch simplifies find_package usage for a project using libkface, and allows regular cmake package versioning to be used:
find_package(Kface 3.3.0 CONFIG)
if(Kface_FOUND)
  target_link_libraries(my_program ${KFACE_NAMESPACE}kface )
endif()


Note: in its current form, this patch uses CMake features only available in CMake >= 2.8.11.

Diffs

• CMakeLists.txt (e6910e6)
• cmake/templates/KfaceConfig.cmake.in (PRE-CREATION)
• libkface/CMakeLists.txt (b14c920)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Zarl-2]

Hi,

Any chance I might get feedback on this?

Cheers,
  Johannes

On Sunday 27 July 2014 18:00:20 Johannes Zarl wrote:

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119504/
> -----------------------------------------------------------
>
> Review request for Digikam.
>
>
> Repository: libkface
>
>
> Description
> -------
>
> Implement KfaceConfig.cmake with imported targets.
>
> This patch simplifies find_package usage for a project using libkface, and
> allows regular cmake package versioning to be used:
>
>     find_package(Kface 3.3.0 CONFIG)
>     if(Kface_FOUND)
>       target_link_libraries(my_program ${KFACE_NAMESPACE}kface )
>     endif()
>
> Note: in its current form, this patch uses CMake features only available in
> CMake >= 2.8.11.
>
>
> Diffs
> -----
>
>   CMakeLists.txt e6910e6
>   cmake/templates/KfaceConfig.cmake.in PRE-CREATION
>   libkface/CMakeLists.txt b14c920
>
> Diff: https://git.reviewboard.kde.org/r/119504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Johannes Zarl

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel