Review Request 119414: Limit linking libkface to OpenCV libraries to only needed components

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 119414: Limit linking libkface to OpenCV libraries to only needed components

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119414/

Review request for Digikam.
By Vadim Zhukov.
Repository: libkface

Description

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
  2. Limit libkface linking to only OpenCV components it really uses.

This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.

Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119413/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (f0a6d8d)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 119414: Limit linking libkface to OpenCV libraries to only needed components

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119414/

This change has been marked as submitted.


Review request for Digikam.
By Vadim Zhukov.

Updated July 23, 2014, 7:40 a.m.

Repository: libkface

Description

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
  2. Limit libkface linking to only OpenCV components it really uses.

This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.

Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119413/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (f0a6d8d)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel