digiKam › digikam-devel

Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

classic Classic list List threaded Threaded
♦
♦
 10 messages Options
Vadim Zhukov
Reply | Threaded
Open this post in threaded view
♦
♦
|

Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/

Review request for Digikam.
By Vadim Zhukov.
Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/ 

SET(OpenCV_LIBS)

FIND_PACKAGE(OpenCV)    


^^^there is not limitation about OpenCV component to link RemoveRedEyes tool, as you do with your others opencv patches.

- Gilles Caulier


On July 22nd, 2014, 8:34 p.m. UTC, Vadim Zhukov wrote:

Review request for Digikam.
By Vadim Zhukov.

Updated July 22, 2014, 8:34 p.m.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Vadim Zhukov
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Vadim Zhukov
In reply to this post by Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/

Review request for Digikam.
By Vadim Zhukov.

Updated Июль 23, 2014, 1:13 п.п.

Changes

Actually specify components needed. Spotted by Gilles.
Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs (updated)

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Vadim Zhukov
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Vadim Zhukov
In reply to this post by Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/

On Июль 23rd, 2014, 11:44 д.п. MSK, Gilles Caulier wrote:

SET(OpenCV_LIBS)

FIND_PACKAGE(OpenCV)    


^^^there is not limitation about OpenCV component to link RemoveRedEyes tool, as you do with your others opencv patches.
Yep, you're right. I failed at moving patches between OpenBSD Ports and KIPI plugins repos back and forth. I've just updated the patch.

- Vadim


On Июль 23rd, 2014, 1:13 п.п. MSK, Vadim Zhukov wrote:

Review request for Digikam.
By Vadim Zhukov.

Updated Июль 23, 2014, 1:13 п.п.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Gilles Caulier-4
In reply to this post by Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/ 

Kipi-plugins won't link against OpenCV :


Undefined symbols for architecture x86_64:

  "_cvArcLength", referenced from:

      KIPIRemoveRedEyesPlugin::CBlobGetHullPerimeter::operator()(KIPIRemoveRedEyesPlugin::CBlob const&) const in Blob.cpp.o

  "_cvContourArea", referenced from:

      KIPIRemoveRedEyesPlugin::CBlobGetHullArea::operator()(KIPIRemoveRedEyesPlugin::CBlob const&) const in Blob.cpp.o

  "_cvConvexHull2", referenced from:

      KIPIRemoveRedEyesPlugin::CBlob::GetConvexHull(CvSeq) const in Blob.cpp.o

      KIPIRemoveRedEyesPlugin::CBlobGetHullPerimeter::operator()(KIPIRemoveRedEyesPlugin::CBlob const&) const in Blob.cpp.o

      KIPIRemoveRedEyesPlugin::CBlobGetHullArea::operator()(KIPIRemoveRedEyesPlugin::CBlob const&) const in Blob.cpp.o

  "_cvCvtColor", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::findPossibleEyes(double, int, char const) in haarclassifierlocator.cpp.o

  "_cvDilate", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::generateMask(int, CvSeq) in haarclassifierlocator.cpp.o

  "_cvErode", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::generateMask(int, CvSeq) in haarclassifierlocator.cpp.o

  "_cvFillImage", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::findBlobs(_IplImage, int) in haarclassifierlocator.cpp.o

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::allocateBuffers() in haarclassifierlocator.cpp.o

  "_cvFitEllipse2", referenced from:

      KIPIRemoveRedEyesPlugin::CBlob::GetEllipse() const in Blob.cpp.o

  "_cvHaarDetectObjects", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::findPossibleEyes(double, int, char const) in haarclassifierlocator.cpp.o

  "_cvLoadImage", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::startCorrection(QString const&, QString const&) in haarclassifierlocator.cpp.o

  "_cvReleaseHaarClassifierCascade", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::findPossibleEyes(double, int, char const) in haarclassifierlocator.cpp.o

  "_cvSaveImage", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::saveImage(QString const&, KIPIRemoveRedEyesPlugin::Locator::SaveResult) in haarclassifierlocator.cpp.o

  "_cvSmooth", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::removeRedEyes() in haarclassifierlocator.cpp.o

  "_cvThreshold", referenced from:

      KIPIRemoveRedEyesPlugin::HaarClassifierLocator::generateMask(int, CvSeq*) in haarclassifierlocator.cpp.o

[ 49%] ld: symbol(s) not found for architecture x86_64

clang: error: linker command failed with exit code 1 (use -v to see invocation)

- Gilles Caulier


On July 23rd, 2014, 9:13 a.m. UTC, Vadim Zhukov wrote:

Review request for Digikam.
By Vadim Zhukov.

Updated July 23, 2014, 9:13 a.m.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Vadim Zhukov
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Vadim Zhukov
In reply to this post by Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/

Review request for Digikam.
By Vadim Zhukov.

Updated Июль 23, 2014, 2:31 п.п.

Changes

More explicit dependencies on OpenCV for KIPI plugins.

Still curious why those doesn't raise on OpenBSD...
Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs (updated)

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Vadim Zhukov
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/

This change has been marked as submitted.

Review request for Digikam.
By Vadim Zhukov.

Updated July 23, 2014, 11:43 a.m.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/ 

Vadim,


I must use the same components defined into libkface for RemoveRedEyes, else link do not work properly...

- Gilles Caulier


On July 23rd, 2014, 11:43 a.m. UTC, Vadim Zhukov wrote:

Review request for Digikam.
By Vadim Zhukov.

Updated July 23, 2014, 11:43 a.m.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Vadim Zhukov
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/

On Июль 23rd, 2014, 3:44 п.п. MSK, Gilles Caulier wrote:

Vadim,


I must use the same components defined into libkface for RemoveRedEyes, else link do not work properly...
Does it happen on OS X only? Are there any "find_package(OpenCV)" (without "COMPONENTS") in your build somewhere?

- Vadim


On Июль 23rd, 2014, 3:43 п.п. MSK, Vadim Zhukov wrote:

Review request for Digikam.
By Vadim Zhukov.

Updated Июль 23, 2014, 3:43 п.п.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

Gilles Caulier-4
In reply to this post by Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119413/ 

Same problem under Windows and Linux

- Gilles Caulier


On July 23rd, 2014, 11:43 a.m. UTC, Vadim Zhukov wrote:

Review request for Digikam.
By Vadim Zhukov.

Updated July 23, 2014, 11:43 a.m.

Repository: kipi-plugins

Description 

    

  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
    2. 

  2. Limit KIPI plugins linking to only OpenCV components it really uses.
    3. 



This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.


Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Testing 

OpenBSD/i386-CURRENT

Diffs

  • CMakeLists.txt (8a4a0d4)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Free forum by Nabble Edit this page