Review Request 119200: Unbreak compilation of kmemoryinfo_backend.cpp on OpenBSD (at least)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 119200: Unbreak compilation of kmemoryinfo_backend.cpp on OpenBSD (at least)

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119200/

Review request for Digikam.
By Vadim Zhukov.
Repository: digikam

Description

There is an unused (!) variable named "new" declared, which is forbidden in C++. This code is only compiled on NetBSD and OpenBSD, where people usually could fix such problems themselves, so it wasn't noticed for a long time. But anyway this obviously needs to be fixed.

Testing

OpenBSD/i386-CURRENT, KDE 4.13.2

Diffs

  • libs/3rdparty/kmemoryinfo/kmemoryinfo_backend.cpp (7eeb45f)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 119200: Unbreak compilation of kmemoryinfo_backend.cpp on OpenBSD (at least)

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119200/

Review request for Digikam.
By Vadim Zhukov.

Updated Июль 9, 2014, 8:57 п.п.

Repository: digikam

Description (updated)

There is an unused (!) variable named "new" declared, which is forbidden in C++. This code is only compiled on NetBSD and OpenBSD, where people usually could fix such problems themselves, so it wasn't noticed for a long time. But anyway this obviously needs to be fixed.

Please note that I don't have commit rights.

Testing

OpenBSD/i386-CURRENT, KDE 4.13.2

Diffs

  • libs/3rdparty/kmemoryinfo/kmemoryinfo_backend.cpp (7eeb45f)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 119200: Unbreak compilation of kmemoryinfo_backend.cpp on OpenBSD (at least)

Vadim Zhukov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119200/

This change has been marked as submitted.


Review request for Digikam.
By Vadim Zhukov.

Updated July 9, 2014, 5:07 p.m.

Repository: digikam

Description

There is an unused (!) variable named "new" declared, which is forbidden in C++. This code is only compiled on NetBSD and OpenBSD, where people usually could fix such problems themselves, so it wasn't noticed for a long time. But anyway this obviously needs to be fixed.

Please note that I don't have commit rights.

Testing

OpenBSD/i386-CURRENT, KDE 4.13.2

Diffs

  • libs/3rdparty/kmemoryinfo/kmemoryinfo_backend.cpp (7eeb45f)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel