Review Request 111021: In case of multiple matches for a lens from lensfun, check if one is an exact match.

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111021/

Review request for Digikam and Gilles Caulier.

By Teemu Rytilahti.

Description

In case lensfun returns multiple lenses, check if we have an exact match.
Lensfun seems to return all the "matching" revisions of the lens (marked f.ex. with II or R) even though there is an exact match for the lens available.
This fix allows one hopefully to run bqm for photos with those cases.

Might fix also 303848.

Testing

Tested locally to work with "OLYMPUS M.14-42mm F3.5-5.6 II", for which lensfun also returns "OLYMPUS M.14-42mm F3.5-5.6 II R".

Bugs: https://bugs.kde.org/show_bug.cgi?id=303848

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (55eeccae091ad260cae6e2a6a9929f2c405f8471)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111021/

Ping?

- Teemu

On June 14th, 2013, 1:58 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam and Gilles Caulier.

By Teemu Rytilahti.

Updated June 14, 2013, 1:58 p.m.

Description

In case lensfun returns multiple lenses, check if we have an exact match.
Lensfun seems to return all the "matching" revisions of the lens (marked f.ex. with II or R) even though there is an exact match for the lens available.
This fix allows one hopefully to run bqm for photos with those cases.

Might fix also 303848.

Testing

Tested locally to work with "OLYMPUS M.14-42mm F3.5-5.6 II", for which lensfun also returns "OLYMPUS M.14-42mm F3.5-5.6 II R".

Bugs: https://bugs.kde.org/show_bug.cgi?id=303848

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (55eeccae091ad260cae6e2a6a9929f2c405f8471)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-5]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111021/

This review has been submitted with commit 09e5724cc30efa46314fb773be318890be1d32c4 by Gilles Caulier to branch master.

- Commit Hook

On June 14th, 2013, 1:58 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam and Gilles Caulier.

By Teemu Rytilahti.

Updated June 14, 2013, 1:58 p.m.

Bugs: https://bugs.kde.org/show_bug.cgi?id=303848

Repository: digikam

Description

In case lensfun returns multiple lenses, check if we have an exact match.
Lensfun seems to return all the "matching" revisions of the lens (marked f.ex. with II or R) even though there is an exact match for the lens available.
This fix allows one hopefully to run bqm for photos with those cases.

Might fix also 303848.

Testing

Tested locally to work with "OLYMPUS M.14-42mm F3.5-5.6 II", for which lensfun also returns "OLYMPUS M.14-42mm F3.5-5.6 II R".

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (55eeccae091ad260cae6e2a6a9929f2c405f8471)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111021/

This change has been marked as submitted.

Review request for Digikam and Gilles Caulier.

By Teemu Rytilahti.

Updated Nov. 28, 2013, 4:12 p.m.

Bugs: https://bugs.kde.org/show_bug.cgi?id=303848

Repository: digikam

Description

In case lensfun returns multiple lenses, check if we have an exact match.
Lensfun seems to return all the "matching" revisions of the lens (marked f.ex. with II or R) even though there is an exact match for the lens available.
This fix allows one hopefully to run bqm for photos with those cases.

Might fix also 303848.

Testing

Tested locally to work with "OLYMPUS M.14-42mm F3.5-5.6 II", for which lensfun also returns "OLYMPUS M.14-42mm F3.5-5.6 II R".

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (55eeccae091ad260cae6e2a6a9929f2c405f8471)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel