Review Request 109298: Adding photo informations to the album view item
Locked
Review Request 109298: Adding photo informations to the album view item
 
|
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
Ship it! Ship It! - Gilles On March 5th, 2013, 9:09 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
I tested your patch. It sound not too intrusive especially with icon view text add below thumb. But : - Option must be disable by default (it's not the case at first run with this patch) - Check you new i18n. I see a problem with tool-tip of this option, from AlbumView setup page. I would also to see included in this patch something about to print all these info, exactly like you do with icon-view, as a simple line with photo info, but over preview canvas, following this wish : https://bugs.kde.org/show_bug.cgi?id=221142 This can be done to show photo info on a corner of preview image, as bottom right for ex. This must be available to all preview canvas : iconview (F3) and Light table. A new option must be add to setup of course. What do you think about ? Gilles Caulier - Gilles On March 5th, 2013, 9:09 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
What's about my proposal to show these photo information over Preview mode canvas ? Gilles Caulier - Gilles On March 6th, 2013, 10:08 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Gilles Caulier-4
This was exactly my initial idea, I like it very much. I'll start with an overlay of this line. - Marco On March 6th, 2013, 11:08 p.m. CET, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
>btw Is there a way to commit a patch without having the status of an KDE developer? No you cannot : you must to be registered with a developer account... Are you interested to contribute more and become an official developer ? Gilles Caulier - Gilles On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
- Gilles On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
I tested your last patch, and you miss-understood me. Previously, i talk about Preview mode (from Album UI, press F3). Preview is not thumbnail. It a real view of image to replace icon view. It's not a real full image handling as it's done in image editor. A reduced size of image data is used to speed up loading. Your new patch include thumbnail overlay support. I not sure if it's the right way to do. We have already tool tip for this purpose. Also, do you see that a new View Mode have been introduced recently : Table-view. To switch on, go to View menu and select right option. In this mode, you can customize items info columns visible, including photo info. But Preview Mode need definitively photo info overlay. Just to be sure that you understand what i mean, i take a shot of preview mode : http://www.flickr.com/photos/digikam/8554418954/ Overlay need to be displayed on the bottom/left corner of preview canvas... Gilles Caulier - Gilles On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
Thumbnail Overlay mode is really a bad idea. It bloat GUI, as expected : http://www.flickr.com/photos/digikam/8553333929/ But this is exactly what we need for preview mode (:=)))... Please revert you patch to previous version and move/adapt overlay implementation for Preview Mode. Classes dedicated to show preview in Album UI and Light Table canvas are listed below: https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/graphicsview/graphicsdimgview.h https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/imagepreviewview.h https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/lighttable/lighttablepreview.h https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/importui/views/importpreviewview.h Gilles Caulier - Gilles On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
My original idea was to increase the number of photos in Album view, therefore one need to reduce the information below and the most important information should also available in the thumbnail bar. Well to expand this overlay to the Preview mode should be easy and the information in the previewed photos is also a nice feature independent of this overlay. You're right, the overlay bloat the GUI, but it is acceptable for few information. * Most of the photos are landscape so that there are some space on the top. * The shortcut and toolbar icon is there for switch on / off the overlay. I need this also. * The tool tips shows information only for one photo, so you cannot compare them. * The new table view is good for comparison of information but it has one drawback: you only have a few photos on the side. Marco - Marco On March 13th, 2013, 12:10 a.m. CET, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
Marco, Any progress here ? Gilles Caulier - Gilles On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
Not yet, much work and holiday not before mid of April. Meanwhile you can integrate r2, because it is independent of the overlay stuff. What do you think of my comment? Marco - Marco On March 13th, 2013, 12:10 a.m. CET, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Gilles Caulier-4
>You're right, the overlay bloat the GUI, but it is acceptable for few information. >* Most of the photos are landscape so that there are some space on the top. yes, but the model view is not designed to optimize space in this condition. In fact the new list view mode where work Micheal will respond to your whishes >* The shortcut and toolbar icon is there for switch on / off the overlay. I need this also. Why not... but see my next comment. >* The tool tips shows information only for one photo, so you cannot compare them. Right. But new list view mode do it very well. You can now customize all column with info that you need, taken from digiKam, metadata or file properties. This is definitively the best way to compare and sort images, better than overlay. >* The new table view is good for comparison of information but it has one drawback: you only have a few photos on the side. I'm not agree. As you can also change thumbnails size in this mode, you can extend the visible counts of item on the screen. Problem is the same with icon-view in fact. This is why you need to scroll-down. But definitively, compare items properties will be more simple with table view than overlay : properties will be show side by side using columns. Gilles Caulier - Gilles On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Gilles Caulier-4
Janitorial Question: What's the status of this? Has it been commited? Or not? Or there's still work to do? If there is still work to do maybe makes sense discarding this review request and starting a new one? - Albert On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Gilles Caulier-4
- Albert On març 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Review Request 109298: Adding photo informations to the album view item
|
|
In reply to this post by Marco Berghoff
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
«
Return to digikam-devel
|
1 view|%1 views
| Free forum by Nabble | Edit this page |