Review Request 109110: Find and external SQLite v2 for digiKam DB 0.7 conversion

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109110/

Review request for Digikam and Gilles Caulier.

By Pino Toscano.

Description

Instead of rely on an internal copy of SQLite v2, search for an external version of it; if not found, disable the import/conversion of old databases from v0.7, failing directly with an error message.

Once this is accepted, a second commit will remove the libs/3rdparty/sqlite2 directory.

Testing

digiKam compiles with and without SQLite v2.

Bugs: 237037

Diffs

• CMakeLists.txt (cb7967389b60e33eec5e10a9633577d70e8ecbfa)
• cmake/modules/FindSqlite2.cmake (PRE-CREATION)
• digikam/CMakeLists.txt (71cc34cc05e71f348b193963a30f7c8f0e6daf89)
• digikam/utils/config-digikam.h.cmake (fb6644d509e198deae6ec5c8f8c54610a927df9b)
• libs/database/schemaupdater.cpp (100edc948e48d2e282354714fcd69a9c5be4df72)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109110/

Patch is fine for me. You can commit and close bug #237037

Gilles Caulier

- Gilles

On February 23rd, 2013, 1:39 p.m. UTC, Pino Toscano wrote:

Review request for Digikam and Gilles Caulier.

By Pino Toscano.

Updated Feb. 23, 2013, 1:39 p.m.

Description

Instead of rely on an internal copy of SQLite v2, search for an external version of it; if not found, disable the import/conversion of old databases from v0.7, failing directly with an error message.

Once this is accepted, a second commit will remove the libs/3rdparty/sqlite2 directory.

Testing

digiKam compiles with and without SQLite v2.

Bugs: 237037

Diffs

• CMakeLists.txt (cb7967389b60e33eec5e10a9633577d70e8ecbfa)
• cmake/modules/FindSqlite2.cmake (PRE-CREATION)
• digikam/CMakeLists.txt (71cc34cc05e71f348b193963a30f7c8f0e6daf89)
• digikam/utils/config-digikam.h.cmake (fb6644d509e198deae6ec5c8f8c54610a927df9b)
• libs/database/schemaupdater.cpp (100edc948e48d2e282354714fcd69a9c5be4df72)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-5]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109110/

This review has been submitted with commit 0addce7f2ebdccd76b3291a45e0019ed45069e7e by Pino Toscano to branch master.

- Commit

On February 23rd, 2013, 1:39 p.m. UTC, Pino Toscano wrote:

Review request for Digikam and Gilles Caulier.

By Pino Toscano.

Updated Feb. 23, 2013, 1:39 p.m.

Description

Instead of rely on an internal copy of SQLite v2, search for an external version of it; if not found, disable the import/conversion of old databases from v0.7, failing directly with an error message.

Once this is accepted, a second commit will remove the libs/3rdparty/sqlite2 directory.

Testing

digiKam compiles with and without SQLite v2.

Bugs: 237037

Diffs

• CMakeLists.txt (cb7967389b60e33eec5e10a9633577d70e8ecbfa)
• cmake/modules/FindSqlite2.cmake (PRE-CREATION)
• digikam/CMakeLists.txt (71cc34cc05e71f348b193963a30f7c8f0e6daf89)
• digikam/utils/config-digikam.h.cmake (fb6644d509e198deae6ec5c8f8c54610a927df9b)
• libs/database/schemaupdater.cpp (100edc948e48d2e282354714fcd69a9c5be4df72)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel