Review Request 109048: Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid.

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

Review request for Digikam.

By Teemu Rytilahti.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

Ship it!

Ship It!

- Gilles

On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 9:03 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

>Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. 

The patch sound fine for me.


>Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.

If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus. 


0x9206	37382	Image	Exif.Image.SubjectDistance	SRational	The distance to the subject, given in meters.

0x100c	4108	Olympus	Exif.Olympus.FocusDistance	Rational	Manual focus distance

Note : exiftool do not give a better explaination abou tthis private tag :

http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html

What do you plan to add in your patch ?

>Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Do you applied a patch to Exiv2 project ?

Gilles Caulier

- Gilles

On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 9:03 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

On March 17th, 2013, 12:17 p.m. UTC, Gilles Caulier wrote:

>Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. 

The patch sound fine for me.


>Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.

If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus. 


0x9206	37382	Image	Exif.Image.SubjectDistance	SRational	The distance to the subject, given in meters.

0x100c	4108	Olympus	Exif.Olympus.FocusDistance	Rational	Manual focus distance

Note : exiftool do not give a better explaination abou tthis private tag :

http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html

What do you plan to add in your patch ?

>Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Do you applied a patch to Exiv2 project ?

Gilles Caulier

> As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.
> If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus. 

Yup, at least my camera (Olympus E-PL3) doesn't mark regular (Exif.Photo.)SubjectDistance at all, and I assume that's the case for all those other special cases in there.

> What do you plan to add in your patch ?

The current code already uses Exif.Photo.SubjectDistance as default before trying to check for the vendor specific tags. What makes me wonder though that there's also another standard one (Exif.Photo.SubjectDistance), which isn't handled at all.

Soo, to answer to your question, I think adding this special case should be enough for now?

> Do you applied a patch to Exiv2 project ?

Nope, I haven't been able to get in touch with the maintainer via e-mail and their Redmine doesn't let me login at all. Sent a new message about the matter to Andreas.

- Teemu

On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 9:03 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

On March 17th, 2013, 12:17 p.m. UTC, Gilles Caulier wrote:

>Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. 

The patch sound fine for me.


>Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.

If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus. 


0x9206	37382	Image	Exif.Image.SubjectDistance	SRational	The distance to the subject, given in meters.

0x100c	4108	Olympus	Exif.Olympus.FocusDistance	Rational	Manual focus distance

Note : exiftool do not give a better explaination abou tthis private tag :

http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html

What do you plan to add in your patch ?

>Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Do you applied a patch to Exiv2 project ?

Gilles Caulier

On March 21st, 2013, 1:52 p.m. UTC, Teemu Rytilahti wrote:

> As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.
> If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus. 

Yup, at least my camera (Olympus E-PL3) doesn't mark regular (Exif.Photo.)SubjectDistance at all, and I assume that's the case for all those other special cases in there.

> What do you plan to add in your patch ?

The current code already uses Exif.Photo.SubjectDistance as default before trying to check for the vendor specific tags. What makes me wonder though that there's also another standard one (Exif.Photo.SubjectDistance), which isn't handled at all.

Soo, to answer to your question, I think adding this special case should be enough for now?

> Do you applied a patch to Exiv2 project ?

Nope, I haven't been able to get in touch with the maintainer via e-mail and their Redmine doesn't let me login at all. Sent a new message about the matter to Andreas.

Eww, okay, forgot to publish that comment yesterday. Anyway, Andreas already responded and I was able to submit the patch: http://dev.exiv2.org/issues/896 . Soo, I shall push the changes to master, right?

- Teemu

On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 9:03 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

> Soo, to answer to your question, I think adding this special case should be enough for now?

yes, it's fine...

>Nope, I haven't been able to get in touch with the maintainer via e-mail and their Redmine doesn't let me login at all. Sent a new message about the matter to Andreas.

Try to contact Robin Mills <[hidden email]> instead if Andreas is too busy to respond.

- Gilles

On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 9:03 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

>Soo, I shall push the changes to master, right?

Yes, it's safe for me...

- Gilles

On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 9:03 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109048/

This change has been marked as submitted.

Review request for Digikam.

By Teemu Rytilahti.

Updated March 21, 2013, 4:04 p.m.

Description

Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Testing

Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.

Diffs

• libs/dimg/filters/lens/lensfuniface.cpp (f2bbb620bfa116cb9f72afa7dc2229d02dafd830)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel