Reread metadata from image removes rating

[Johannes Wienke-3]

Hi,

I just noticed that "Reread metadata from image" removes the rating
assigned to an image, even though I don't store ratings in the image
metadata. Is this the desired behaviour? For me it was really surprising
to have lost all ratings for an album because I had to reread the
metadata to get the updated geo-localization information from the files.

Moreover I just noticed that if the option to save tags in the images is
selected, assigning at tag correctly adds the tag to the image metadata
but removing it afterwards in digikam doesn't remove the tag from the
metadata. Is this a known issue?

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I just noticed that "Reread metadata from image" removes the rating
> assigned to an image, even though I don't store ratings in the image
> metadata. Is this the desired behaviour? For me it was really surprising
> to have lost all ratings for an album because I had to reread the
> metadata to get the updated geo-localization information from the files.

Indeed, that's a bug. I will fix it.

>
> Moreover I just noticed that if the option to save tags in the images is
> selected, assigning at tag correctly adds the tag to the image metadata
> but removing it afterwards in digikam doesn't remove the tag from the
> metadata. Is this a known issue?

Can't reproduce here. Which image format, which tag, which metadata field are
you looking at?

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Am 23.12.2009 16:15 schrieb Marcel Wiesweg:
>> I just noticed that "Reread metadata from image" removes the rating
>> assigned to an image, even though I don't store ratings in the image
>> metadata. Is this the desired behaviour? For me it was really surprising
>> to have lost all ratings for an album because I had to reread the
>> metadata to get the updated geo-localization information from the files.
>
> Indeed, that's a bug. I will fix it.

Thanks.

>> Moreover I just noticed that if the option to save tags in the images is
>> selected, assigning at tag correctly adds the tag to the image metadata
>> but removing it afterwards in digikam doesn't remove the tag from the
>> metadata. Is this a known issue?
>
> Can't reproduce here. Which image format, which tag, which metadata field are
> you looking at?

Was a plain jpeg. I can reproduce it like this;

1. Take a jpeg file without tags.
2. set one tag for that file
3. write metadata to that file
4. remove tag from file
5. write metadata to file again
6. tag is still in the exif information

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > I just noticed that "Reread metadata from image" removes the rating
> > assigned to an image, even though I don't store ratings in the image
> > metadata. Is this the desired behaviour? For me it was really surprising
> > to have lost all ratings for an album because I had to reread the
> > metadata to get the updated geo-localization information from the files.
>
> Indeed, that's a bug. I will fix it.

For this we must decide what "reread" means for which group of metadata.

Tags are merged, only new keywords will be added to the database.

Other fields are replaced as a group: If one field is found, all are replaced
in the db. This applies to the groups GPS data, copyright information, and
photo metadata (make, model, exposure etc.).

Currently rating, width, height, creation and digitization date and
orientation are unconditionally replaced.

Remaining fields are treated as single fields and will be replaced if found
and not touched if not found.

To fix the problem here, rating will only be replaced if set in the metadata.
Please check if other fields here should be treated differently as well.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/12/23 Johannes Wienke <[hidden email]>:

> Am 23.12.2009 16:15 schrieb Marcel Wiesweg:
>>>
>>> I just noticed that "Reread metadata from image" removes the rating
>>> assigned to an image, even though I don't store ratings in the image
>>> metadata. Is this the desired behaviour? For me it was really surprising
>>> to have lost all ratings for an album because I had to reread the
>>> metadata to get the updated geo-localization information from the files.
>>
>> Indeed, that's a bug. I will fix it.
>
> Thanks.
>
>>> Moreover I just noticed that if the option to save tags in the images is
>>> selected, assigning at tag correctly adds the tag to the image metadata
>>> but removing it afterwards in digikam doesn't remove the tag from the
>>> metadata. Is this a known issue?
>>
>> Can't reproduce here. Which image format, which tag, which metadata field
>> are you looking at?
>
> Was a plain jpeg. I can reproduce it like this;
>
> 1. Take a jpeg file without tags.
> 2. set one tag for that file
> 3. write metadata to that file
> 4. remove tag from file
> 5. write metadata to file again
> 6. tag is still in the exif information

In Exif ? Are you sure ? digiKam write Tags in Iptc (only tags name)
and in XMP (Tags name and Tags paths)

Which libkexiv2 you use ? trunk ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Am 23.12.2009 17:23 schrieb Gilles Caulier:

> 2009/12/23 Johannes Wienke <[hidden email]>:
>> Am 23.12.2009 16:15 schrieb Marcel Wiesweg:
>>>> Moreover I just noticed that if the option to save tags in the images is
>>>> selected, assigning at tag correctly adds the tag to the image metadata
>>>> but removing it afterwards in digikam doesn't remove the tag from the
>>>> metadata. Is this a known issue?
>>> Can't reproduce here. Which image format, which tag, which metadata field
>>> are you looking at?
>> Was a plain jpeg. I can reproduce it like this;
>>
>> 1. Take a jpeg file without tags.
>> 2. set one tag for that file
>> 3. write metadata to that file
>> 4. remove tag from file
>> 5. write metadata to file again
>> 6. tag is still in the exif information
>
> In Exif ? Are you sure ? digiKam write Tags in Iptc (only tags name)
> and in XMP (Tags name and Tags paths)

Ah sorry, may also be iptc or what ever exiftool also prints out. ;)

> Which libkexiv2 you use ? trunk ?

Yes, trunk.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Was a plain jpeg. I can reproduce it like this;
>
> 1. Take a jpeg file without tags.
> 2. set one tag for that file
> 3. write metadata to that file
> 4. remove tag from file
> 5. write metadata to file again
> 6. tag is still in the exif information
>
> Johannes
>

In which way do you write the metadata to the file?
I have enabled "write tags to metadata" in the settings, I assign the tag with
the right sidebar (imgdescedittab) and it's done directly.
(and removed directly as well)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > Indeed, that's a bug. I will fix it.
>
> Thanks.

Take care, I just discovered that it's not yet fixed. Requires some deeper
changes.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Am 24.12.2009 15:29 schrieb Marcel Wiesweg:

>> Was a plain jpeg. I can reproduce it like this;
>>
>> 1. Take a jpeg file without tags.
>> 2. set one tag for that file
>> 3. write metadata to that file
>> 4. remove tag from file
>> 5. write metadata to file again
>> 6. tag is still in the exif information
>>
>
> In which way do you write the metadata to the file?
> I have enabled "write tags to metadata" in the settings, I assign the tag with
> the right sidebar (imgdescedittab) and it's done directly.
> (and removed directly as well)

For me it isn't written to the metadata directly, eventhough I have the
option set. Another bug? It was the "write metadata to file" command
from the image menu.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel