Rejection of Face Suggestions

[kartikx]

Hello all,

I've been able to implement the feature for rejection of face suggestions. I've made commits to the gsoc20-facesengine-workflow branch.

Please let me know if the implementation is appropriate.

Thanks

Kartik

[Gilles Caulier-4]

Hi,

I don't checkout your branch. I will do it now and look your code style.

Best

Gilles Caulier

Le ven. 8 mai 2020 à 11:33, Kartik Ramesh <[hidden email]> a écrit :
>
> Hello all,
>
> I've been able to implement the feature for rejection of face suggestions. I've made commits to the gsoc20-facesengine-workflow branch.
> Please let me know if the implementation is appropriate.
>
> Thanks
> Kartik

[Gilles Caulier-4]

Q : Where are located exactly your commits to check in source code files ?
Best

Gilles Caulier

Le dim. 10 mai 2020 à 09:06, Gilles Caulier <[hidden email]> a écrit :

>
> Hi,
>
> I don't checkout your branch. I will do it now and look your code style.
>
> Best
>
> Gilles Caulier
>
> Le ven. 8 mai 2020 à 11:33, Kartik Ramesh <[hidden email]> a écrit :
> >
> > Hello all,
> >
> > I've been able to implement the feature for rejection of face suggestions. I've made commits to the gsoc20-facesengine-workflow branch.
> > Please let me know if the implementation is appropriate.
> >
> > Thanks
> > Kartik

[kartikx]

Apologies Gilles, I'm not sure I'm completely understanding your question. You can view my commits to gsoc20 branch here https://invent.kde.org/kde/digikam/-/commits/gsoc20-facesengine-workflow. 

I made changes to core/utilities/facemanagement/widgets, core/utilities/facemanagement/threads, core/utilities/facemanagement/workers, core/libs/database/tags and core/app/items/views.

Regards

Kartik

On Sun, May 10, 2020 at 12:39 PM Gilles Caulier <[hidden email]> wrote:

Q : Where are located exactly your commits to check in source code files ?
Best

Gilles Caulier

Le dim. 10 mai 2020 à 09:06, Gilles Caulier <[hidden email]> a écrit :
>
> Hi,
>
> I don't checkout your branch. I will do it now and look your code style.
>
> Best
>
> Gilles Caulier
>
> Le ven. 8 mai 2020 à 11:33, Kartik Ramesh <[hidden email]> a écrit :
> >
> > Hello all,
> >
> > I've been able to implement the feature for rejection of face suggestions. I've made commits to the gsoc20-facesengine-workflow branch.
> > Please let me know if the implementation is appropriate.
> >
> > Thanks
> > Kartik

[Thanh Trung Dinh]

Hi all,

I review Kartik's code yesterday and it seems good to me. I made a comment on gitlab but I forgot to send an email to you. Still better that Gilles takes another look to the codes.

Best,

On Sun, May 10, 2020, 09:21 Kartik Ramesh <[hidden email]> wrote:

Apologies Gilles, I'm not sure I'm completely understanding your question. You can view my commits to gsoc20 branch here https://invent.kde.org/kde/digikam/-/commits/gsoc20-facesengine-workflow. 

I made changes to core/utilities/facemanagement/widgets, core/utilities/facemanagement/threads, core/utilities/facemanagement/workers, core/libs/database/tags and core/app/items/views.

Regards

Kartik

On Sun, May 10, 2020 at 12:39 PM Gilles Caulier <[hidden email]> wrote:

Q : Where are located exactly your commits to check in source code files ?
Best

Gilles Caulier

Le dim. 10 mai 2020 à 09:06, Gilles Caulier <[hidden email]> a écrit :
>
> Hi,
>
> I don't checkout your branch. I will do it now and look your code style.
>
> Best
>
> Gilles Caulier
>
> Le ven. 8 mai 2020 à 11:33, Kartik Ramesh <[hidden email]> a écrit :
> >
> > Hello all,
> >
> > I've been able to implement the feature for rejection of face suggestions. I've made commits to the gsoc20-facesengine-workflow branch.
> > Please let me know if the implementation is appropriate.
> >
> > Thanks
> > Kartik

[Gilles Caulier-4]

Thanh

Right i seen the comment in gitlab. Yes, it's a good way to follow and
comment commit step by step through web interface.

Kartik,

I like the fact to commit in atomic way, and not to group all changes
in large one. It's more difficult to review.

Another point is to test new code. Please ping us when code is ready
to be tested in run time for a specific feature. Please explain a
little bit the expected way to test and the result to obtain.

No need to details in deep all changes and all functionalities. Just
write to words to be able to switch in your project. As we work on
other place it's sometime difficult to follow all changes.

Voilà

gilles

Le dim. 10 mai 2020 à 09:34, Thanh Trung Dinh
<[hidden email]> a écrit :

>
> Hi all,
>
> I review Kartik's code yesterday and it seems good to me. I made a comment on gitlab but I forgot to send an email to you. Still better that Gilles takes another look to the codes.
>
> Best,
>
> On Sun, May 10, 2020, 09:21 Kartik Ramesh <[hidden email]> wrote:
>>
>> Apologies Gilles, I'm not sure I'm completely understanding your question. You can view my commits to gsoc20 branch here https://invent.kde.org/kde/digikam/-/commits/gsoc20-facesengine-workflow.
>>
>> I made changes to core/utilities/facemanagement/widgets, core/utilities/facemanagement/threads, core/utilities/facemanagement/workers, core/libs/database/tags and core/app/items/views.
>>
>> Regards
>> Kartik
>>
>> On Sun, May 10, 2020 at 12:39 PM Gilles Caulier <[hidden email]> wrote:
>>>
>>> Q : Where are located exactly your commits to check in source code files ?
>>> Best
>>>
>>> Gilles Caulier
>>>
>>> Le dim. 10 mai 2020 à 09:06, Gilles Caulier <[hidden email]> a écrit :
>>> >
>>> > Hi,
>>> >
>>> > I don't checkout your branch. I will do it now and look your code style.
>>> >
>>> > Best
>>> >
>>> > Gilles Caulier
>>> >
>>> > Le ven. 8 mai 2020 à 11:33, Kartik Ramesh <[hidden email]> a écrit :
>>> > >
>>> > > Hello all,
>>> > >
>>> > > I've been able to implement the feature for rejection of face suggestions. I've made commits to the gsoc20-facesengine-workflow branch.
>>> > > Please let me know if the implementation is appropriate.
>>> > >
>>> > > Thanks
>>> > > Kartik

[kartikx]

I like the fact to commit in atomic way, and not to group all changes
in large one. It's more difficult to review.

 Just to clarify, the way I committed, was it appropriate?

Another point is to test new code. Please ping us when code is ready
to be tested in run time for a specific feature.

 Apologies, I'm not sure what you mean by "when code is ready to be tested". Can you please explain again what I am expected to do?

Regards

Kartik

[Gilles Caulier-4]

Le dim. 10 mai 2020 à 13:18, Kartik Ramesh <[hidden email]> a écrit :
>>
>> I like the fact to commit in atomic way, and not to group all changes
>> in large one. It's more difficult to review.
>
>  Just to clarify, the way I committed, was it appropriate?

yes it is

>
>> Another point is to test new code. Please ping us when code is ready
>> to be tested in run time for a specific feature.
>
>  Apologies, I'm not sure what you mean by "when code is ready to be tested". Can you please explain again what I am expected to do?

When you want that team test your last implementation, just ping us by
mail with a minimal details to know in goal to perform tests...

Gilles Caulier

[kartikx]

Thanks for explaining. Sure, I'll provide all necessary details from next time.

On Sun, May 10, 2020 at 5:17 PM Gilles Caulier <[hidden email]> wrote:

Le dim. 10 mai 2020 à 13:18, Kartik Ramesh <[hidden email]> a écrit :
>>
>> I like the fact to commit in atomic way, and not to group all changes
>> in large one. It's more difficult to review.
>
>  Just to clarify, the way I committed, was it appropriate?

yes it is

>
>> Another point is to test new code. Please ping us when code is ready
>> to be tested in run time for a specific feature.
>
>  Apologies, I'm not sure what you mean by "when code is ready to be tested". Can you please explain again what I am expected to do?

When you want that team test your last implementation, just ping us by
mail with a minimal details to know in goal to perform tests...

Gilles Caulier