Re: undo/redo in editor is not working in digikam 3.4
Locked
Re: undo/redo in editor is not working in digikam 3.4
 
|
Yes, plenty of space. Ifiled bug, btw. I consider downgrading due to this. But first I wonderr if there could be a problem at compile time causing this? I use the e chakra liux package.
I will ask the packagercto test if he can confirm Gilles Caulier <[hidden email]> skrev: >undo/redo action data (image version) as stored to /var. Do you have >enough place on your HDD ? > >Gilles Caulier > >2013/9/17 Anders Lund <[hidden email]>: >> AndersOn Tirsdag den 17. september 2013 23:09:57, Lund wrote: >>> Is that a known issue? >> >> In more detail, the menu and toolbar buttons indicates that they reacts, but >> the image display does not... >> >> -- >> Anders >> _______________________________________________ >> Digikam-users mailing list >> [hidden email] >> https://mail.kde.org/mailman/listinfo/digikam-users >_______________________________________________ >Digikam-users mailing list >[hidden email] >https://mail.kde.org/mailman/listinfo/digikam-users Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
Here it's not reproducible as well. code is compiled using git/master...
Gilles Caulier 2013/9/21 Anders Lund <[hidden email]>: > Yes, plenty of space. Ifiled bug, btw. I consider downgrading due to this. But first I wonderr if there could be a problem at compile time causing this? I use the e chakra liux package. > > I will ask the packagercto test if he can confirm > > Gilles Caulier <[hidden email]> skrev: > >>undo/redo action data (image version) as stored to /var. Do you have >>enough place on your HDD ? >> >>Gilles Caulier >> >>2013/9/17 Anders Lund <[hidden email]>: >>> AndersOn Tirsdag den 17. september 2013 23:09:57, Lund wrote: >>>> Is that a known issue? >>> >>> In more detail, the menu and toolbar buttons indicates that they reacts, but >>> the image display does not... >>> >>> -- >>> Anders >>> _______________________________________________ >>> Digikam-users mailing list >>> [hidden email] >>> https://mail.kde.org/mailman/listinfo/digikam-users >>_______________________________________________ >>Digikam-users mailing list >>[hidden email] >>https://mail.kde.org/mailman/listinfo/digikam-users > _______________________________________________ > Digikam-users mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-users Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
I tried running digikam from a console, and gets this:
digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No itemShortInfo could be retrieved from the database for image "20130921T142936-0007_v1.JPG" digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No itemShortInfo could be retrieved from the database for image "20130921T142936-0007_v1.JPG" Undoning sometimes produces a damaged image display, like this: http://owncloud.alweb.dk/public.php?service=files&t=08885d934fc9bea999d863e6740e7cfb Anders On Lørdag den 21. september 2013 10:27:08, Gilles Caulier wrote: > Here it's not reproducible as well. code is compiled using git/master... > > Gilles Caulier > > 2013/9/21 Anders Lund <[hidden email]>: > > Yes, plenty of space. Ifiled bug, btw. I consider downgrading due to this. > > But first I wonderr if there could be a problem at compile time causing > > this? I use the e chakra liux package. > > > > I will ask the packagercto test if he can confirm > > > > Gilles Caulier <[hidden email]> skrev: > >>undo/redo action data (image version) as stored to /var. Do you have > >>enough place on your HDD ? > >> > >>Gilles Caulier > >> > >>2013/9/17 Anders Lund <[hidden email]>: > >>> AndersOn Tirsdag den 17. september 2013 23:09:57, Lund wrote: > >>>> Is that a known issue? > >>> > >>> In more detail, the menu and toolbar buttons indicates that they reacts, > >>> but the image display does not... > >>> > >>> -- > >>> Anders > >>> _______________________________________________ > >>> Digikam-users mailing list > >>> [hidden email] > >>> https://mail.kde.org/mailman/listinfo/digikam-users > >> > >>_______________________________________________ > >>Digikam-users mailing list > >>[hidden email] > >>https://mail.kde.org/mailman/listinfo/digikam-users > >> > > _______________________________________________ > > Digikam-users mailing list > > [hidden email] > > https://mail.kde.org/mailman/listinfo/digikam-users > > _______________________________________________ > Digikam-users mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-users -- Anders _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
Sound like a problem with your DB which store versioning information.
Why i don't know... Gilles Caulier 2013/9/22 Anders Lund <[hidden email]>: > I tried running digikam from a console, and gets this: > > digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No itemShortInfo > could be retrieved from the database for image "20130921T142936-0007_v1.JPG" > digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No itemShortInfo > could be retrieved from the database for image "20130921T142936-0007_v1.JPG" > > Undoning sometimes produces a damaged image display, like this: > http://owncloud.alweb.dk/public.php?service=files&t=08885d934fc9bea999d863e6740e7cfb > > Anders > > On Lørdag den 21. september 2013 10:27:08, Gilles Caulier wrote: >> Here it's not reproducible as well. code is compiled using git/master... >> >> Gilles Caulier >> >> 2013/9/21 Anders Lund <[hidden email]>: >> > Yes, plenty of space. Ifiled bug, btw. I consider downgrading due to this. >> > But first I wonderr if there could be a problem at compile time causing >> > this? I use the e chakra liux package. >> > >> > I will ask the packagercto test if he can confirm >> > >> > Gilles Caulier <[hidden email]> skrev: >> >>undo/redo action data (image version) as stored to /var. Do you have >> >>enough place on your HDD ? >> >> >> >>Gilles Caulier >> >> >> >>2013/9/17 Anders Lund <[hidden email]>: >> >>> AndersOn Tirsdag den 17. september 2013 23:09:57, Lund wrote: >> >>>> Is that a known issue? >> >>> >> >>> In more detail, the menu and toolbar buttons indicates that they reacts, >> >>> but the image display does not... >> >>> >> >>> -- >> >>> Anders >> >>> _______________________________________________ >> >>> Digikam-users mailing list >> >>> [hidden email] >> >>> https://mail.kde.org/mailman/listinfo/digikam-users >> >> >> >>_______________________________________________ >> >>Digikam-users mailing list >> >>[hidden email] >> >>https://mail.kde.org/mailman/listinfo/digikam-users >> >> >> > _______________________________________________ >> > Digikam-users mailing list >> > [hidden email] >> > https://mail.kde.org/mailman/listinfo/digikam-users >> >> _______________________________________________ >> Digikam-users mailing list >> [hidden email] >> https://mail.kde.org/mailman/listinfo/digikam-users > > -- > Anders > _______________________________________________ > Digikam-users mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-users Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
2013/9/22 Gilles Caulier <[hidden email]>:
> Sound like a problem with your DB which store versioning information. > Why i don't know... > > Gilles Caulier > > 2013/9/22 Anders Lund <[hidden email]>: >> I tried running digikam from a console, and gets this: >> >> digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No itemShortInfo >> could be retrieved from the database for image "20130921T142936-0007_v1.JPG" >> digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No itemShortInfo >> could be retrieved from the database for image "20130921T142936-0007_v1.JPG" >> >> Undoning sometimes produces a damaged image display, like this: >> http://owncloud.alweb.dk/public.php?service=files&t=08885d934fc9bea999d863e6740e7cfb >> the image corruption sound like more a image structure problem, not relevant of DB. Try to load 20130921T142936-0007_v1.JPG in showfoto for ex which doesn't use BD, to see if it's reproducible Gilles Caulier _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
In reply to this post by Gilles Caulier-4
On Søndag den 22. september 2013 11:41:26, Gilles Caulier wrote:
> Sound like a problem with your DB which store versioning information. > Why i don't know... This was an image just converted from raw, but obviously saved. I cleard my package cache, and it looks like my problems was due to missing sapce on /var, now things are back to working. I'll close the bug report, but I wonder if it would be smart with a warning when there is not enough space? Anders > Gilles Caulier > > 2013/9/22 Anders Lund <[hidden email]>: > > I tried running digikam from a console, and gets this: > > > > digikam(5653)/digikam (core) Digikam::ImageInfo::ImageInfo: No > > itemShortInfo could be retrieved from the database for image > > "20130921T142936-0007_v1.JPG" digikam(5653)/digikam (core) > > Digikam::ImageInfo::ImageInfo: No itemShortInfo could be retrieved from > > the database for image "20130921T142936-0007_v1.JPG" > > > > Undoning sometimes produces a damaged image display, like this: > > http://owncloud.alweb.dk/public.php?service=files&t=08885d934fc9bea999d863 > > e6740e7cfb > > > > Anders > > > > On Lørdag den 21. september 2013 10:27:08, Gilles Caulier wrote: > >> Here it's not reproducible as well. code is compiled using git/master... > >> > >> Gilles Caulier > >> > >> 2013/9/21 Anders Lund <[hidden email]>: > >> > Yes, plenty of space. Ifiled bug, btw. I consider downgrading due to > >> > this. > >> > But first I wonderr if there could be a problem at compile time causing > >> > this? I use the e chakra liux package. > >> > > >> > I will ask the packagercto test if he can confirm > >> > > >> > Gilles Caulier <[hidden email]> skrev: > >> >>undo/redo action data (image version) as stored to /var. Do you have > >> >>enough place on your HDD ? > >> >> > >> >>Gilles Caulier > >> >> > >> >>2013/9/17 Anders Lund <[hidden email]>: > >> >>> AndersOn Tirsdag den 17. september 2013 23:09:57, Lund wrote: > >> >>>> Is that a known issue? > >> >>> > >> >>> In more detail, the menu and toolbar buttons indicates that they > >> >>> reacts, > >> >>> but the image display does not... > >> >>> > >> >>> -- > >> >>> Anders > >> >>> _______________________________________________ -- Anders _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
2013/9/22 Anders Lund <[hidden email]>:
> On Søndag den 22. september 2013 11:41:26, Gilles Caulier wrote: >> Sound like a problem with your DB which store versioning information. >> Why i don't know... > > This was an image just converted from raw, but obviously saved. > > I cleard my package cache, and it looks like my problems was due to missing > sapce on /var, now things are back to working. Ahh. This is an usual problem. > > I'll close the bug report, but I wonder if it would be smart with a warning > when there is not enough space? > Yes space must be check before to use it. But /var is a big puzzle where all Linux sub system use free space to play. If it miss space on /var how a non Linux guru will fix the problem ? There is an entry on bugzilla about this problem. digiKam do not ask to use /var. We delegate all to KTempDir from KDELibs which ask to system temporary free space. This is not perfect but it work on all tux/WinOSX. A perfect solution will be to add a settings dedicated to use a specific local hard drive (a SSD of course) to store temp file. This typically settings must be shared with kipi-plugins to be homogeneous. Gilles _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
On Søndag den 22. september 2013 14:09:20, Gilles Caulier wrote:
> 2013/9/22 Anders Lund <[hidden email]>: > > On Søndag den 22. september 2013 11:41:26, Gilles Caulier wrote: > >> Sound like a problem with your DB which store versioning information. > >> Why i don't know... > > > > This was an image just converted from raw, but obviously saved. > > > > I cleard my package cache, and it looks like my problems was due to > > missing sapce on /var, now things are back to working. > > Ahh. This is an usual problem. > > > I'll close the bug report, but I wonder if it would be smart with a > > warning > > when there is not enough space? > > Yes space must be check before to use it. But /var is a big puzzle > where all Linux sub system use free space to play. If it miss space on > /var how a non Linux guru will fix the problem ? There is an entry on > bugzilla about this problem. > > digiKam do not ask to use /var. We delegate all to KTempDir from > KDELibs which ask to system temporary free space. This is not perfect > but it work on all tux/WinOSX. Using KTempDir sounds sane - maybe that object could provide a way to get information about free space? > A perfect solution will be to add a settings dedicated to use a > specific local hard drive (a SSD of course) to store temp file. This > typically settings must be shared with kipi-plugins to be homogeneous. > > Gilles > _______________________________________________ > Digikam-users mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-users -- Anders _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
In reply to this post by Gilles Caulier-4
On Sun, 22 Sep 2013, Gilles Caulier wrote: > digiKam do not ask to use /var. We delegate all to KTempDir from > KDELibs which ask to system temporary free space. This is not perfect > but it work on all tux/WinOSX. > > A perfect solution will be to add a settings dedicated to use a > specific local hard drive (a SSD of course) to store temp file. This > typically settings must be shared with kipi-plugins to be homogeneous. Gilles, You can do that, here and now. KTempDir uses a default temporary path which is defined as : $KDEHOME/tmp-$HOST/... Default KDEHOME is somehing like $HOME/.kde4 and in this directory there's tmp-$HOST. It's a symbolic link pointing - by default - to /tmp/kde-$USER But you can change this link definition to point to anywhere you wish. So, all KDE based applications, and Kipi plugins and others, are expected to honour this. And if you wish fast access, it can a be a SSD of course, but it can be RAM, faster than SSD. (My $KDEHOME/tmp-$HOST points to /dev/shm/kde-$USER Of course, when using /dev/shm, temporary files will vanish at computer power off.) Regards, Jean-François _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
I will be more precise here.
In code we use KStandardDir::localeLocal('cache",...) to get temprary dir to store uno/redo files : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/core/undocache.cpp#L69 KStandardDir has no way to check free-space : http://www.purinchu.net/kdelibs-apidocs/kdecore/html/classKStandardDirs.html But i remember that we have already a method in Import Tool to show free space from camera and collection. KDiskFreeSpaceInfo must do the stuff : http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/kdiskfreespaceinfo_8h.html Gilles _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
Maybe there is somewhere an error message if you try to write more data than
possible? On Søndag den 22. september 2013 20:33:14, Gilles Caulier wrote: > I will be more precise here. > > In code we use KStandardDir::localeLocal('cache",...) to get temprary > dir to store uno/redo files : > > https://projects.kde.org/projects/extragear/graphics/digikam/repository/revi > sions/master/entry/utilities/imageeditor/core/undocache.cpp#L69 > > KStandardDir has no way to check free-space : > > http://www.purinchu.net/kdelibs-apidocs/kdecore/html/classKStandardDirs.html > > But i remember that we have already a method in Import Tool to show > free space from camera and collection. KDiskFreeSpaceInfo must do the > stuff : > > http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/kdiskfreespaceinfo_8h.ht > ml That looks like good information -- Anders _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
Implemented.
http://commits.kde.org/digikam/5cac0a5f7c911392abdaec28ec776510e9284688 In fact the cache action not registered and not performed and will not appears in editor menu... It's the most quick fix that i can do for this problem. Note that i check if a least a space of 1Gb is available to perform undo action. I think it's enough for most of case here. Right ? I hope that no side effect will be introduced. Note : from the console editor will print free space available in cache. Under OSX, it look like this after applying an autoColor Correction : digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotPreview: Preview "Auto Correction" started... digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Preview "Auto Correction" completed... digikam(12210)/digikam (core) Digikam::WBFilter::autoExposureAdjustement: White level at: 249 digikam(12210)/digikam (core) Digikam::WBFilter::autoExposureAdjustement: Black: 0.0410156 Exposition: 0.0342157 digikam(12210)/digikam (core) Digikam::WBFilter::setLUTv: T(K): 6500 => R: 1 G: 1 B: 1 BP: 10 WP: 250 digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotPreview: Preview "Auto Correction" started... digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Preview "Auto Correction" completed... digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotOk: Final "Auto Correction" started... digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Final "Auto Correction" completed... digikam(12210)/digikam (core) Digikam::UndoCache::putData: Free space available in Editor cache [ "/private/var/tmp/kdecache-gilles/digiKam/" ] in Mbytes: 120418 Gilles 2013/9/22 Anders Lund <[hidden email]>: > Maybe there is somewhere an error message if you try to write more data than > possible? > > On Søndag den 22. september 2013 20:33:14, Gilles Caulier wrote: >> I will be more precise here. >> >> In code we use KStandardDir::localeLocal('cache",...) to get temprary >> dir to store uno/redo files : >> >> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revi >> sions/master/entry/utilities/imageeditor/core/undocache.cpp#L69 >> >> KStandardDir has no way to check free-space : >> >> http://www.purinchu.net/kdelibs-apidocs/kdecore/html/classKStandardDirs.html >> >> But i remember that we have already a method in Import Tool to show >> free space from camera and collection. KDiskFreeSpaceInfo must do the >> stuff : >> >> http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/kdiskfreespaceinfo_8h.ht >> ml > > That looks like good information > > -- > Anders > _______________________________________________ > Digikam-users mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-users Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
Re: undo/redo in editor is not working in digikam 3.4
|
|
Hi Gilles,
Thanks for caring for this! A little hidden value, helping users :) Anders On Søndag den 22. september 2013 21:07:55, Gilles Caulier wrote: > Implemented. > > http://commits.kde.org/digikam/5cac0a5f7c911392abdaec28ec776510e9284688 > > In fact the cache action not registered and not performed and will not > appears in editor menu... > > It's the most quick fix that i can do for this problem. > > Note that i check if a least a space of 1Gb is available to perform > undo action. I think it's enough for most of case here. Right ? > > I hope that no side effect will be introduced. > > Note : from the console editor will print free space available in > cache. Under OSX, it look like this after applying an autoColor > Correction : > > digikam(12210)/digikam (core) > Digikam::EditorToolThreaded::slotPreview: Preview "Auto Correction" > started... > digikam(12210)/digikam (core) > Digikam::EditorToolThreaded::slotFilterFinished: Preview "Auto > Correction" completed... > digikam(12210)/digikam (core) > Digikam::WBFilter::autoExposureAdjustement: White level at: 249 > digikam(12210)/digikam (core) > Digikam::WBFilter::autoExposureAdjustement: Black: 0.0410156 > Exposition: 0.0342157 > digikam(12210)/digikam (core) Digikam::WBFilter::setLUTv: T(K): 6500 > => R: 1 G: 1 B: 1 BP: 10 WP: 250 > digikam(12210)/digikam (core) > Digikam::EditorToolThreaded::slotPreview: Preview "Auto Correction" > started... > digikam(12210)/digikam (core) > Digikam::EditorToolThreaded::slotFilterFinished: Preview "Auto > Correction" completed... > digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotOk: > Final "Auto Correction" started... > digikam(12210)/digikam (core) > Digikam::EditorToolThreaded::slotFilterFinished: Final "Auto > Correction" completed... > digikam(12210)/digikam (core) Digikam::UndoCache::putData: Free space > available in Editor cache [ > "/private/var/tmp/kdecache-gilles/digiKam/" ] in Mbytes: 120418 > > Gilles > > 2013/9/22 Anders Lund <[hidden email]>: > > Maybe there is somewhere an error message if you try to write more data > > than possible? > > > > On Søndag den 22. september 2013 20:33:14, Gilles Caulier wrote: > >> I will be more precise here. > >> > >> In code we use KStandardDir::localeLocal('cache",...) to get temprary > >> dir to store uno/redo files : > >> > >> https://projects.kde.org/projects/extragear/graphics/digikam/repository/r > >> evi sions/master/entry/utilities/imageeditor/core/undocache.cpp#L69 > >> > >> KStandardDir has no way to check free-space : > >> > >> http://www.purinchu.net/kdelibs-apidocs/kdecore/html/classKStandardDirs.h > >> tml > >> > >> But i remember that we have already a method in Import Tool to show > >> free space from camera and collection. KDiskFreeSpaceInfo must do the > >> stuff : > >> > >> http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/kdiskfreespaceinfo_8h > >> .ht ml > > > > That looks like good information > > > > -- > > Anders > > _______________________________________________ > > Digikam-users mailing list > > [hidden email] > > https://mail.kde.org/mailman/listinfo/digikam-users > > _______________________________________________ > Digikam-users mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-users -- Anders _______________________________________________ Digikam-users mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-users |
«
Return to digikam-users
|
1 view|%1 views
| Free forum by Nabble | Edit this page |