Re: extragear/graphics/digikam/libs/dmetadata

[Michael G. Hansen]

This commit broke compilation for me. KDE 4.3.1, Qt 4.5.2, gcc-4.3.4.

Michael Hansen


Michael Jansen wrote:

> SVN commit 1031114 by mjansen:
>
> Fix memleak. Unregister namespace.
>
> I'm pretty sure the design is suboptimal but this is the easiest fix. How
> about (un)registering the namespace once for each app?
>
>  M  +1 -0      dmetadata.cpp  
>
>
> --- trunk/extragear/graphics/digikam/ #1031113:1031114
> @@ -70,6 +70,7 @@
>  
>  DMetadata::~DMetadata()
>  {
> +    unregisterXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/"));
>  }
>  
>  bool DMetadata::load(const QString& filePath) const
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

yes, i can reproduce. I will fix it...

Gilles

2009/10/4 Michael G. Hansen <[hidden email]>:

> This commit broke compilation for me. KDE 4.3.1, Qt 4.5.2, gcc-4.3.4.
>
> Michael Hansen
>
>
> Michael Jansen wrote:
>> SVN commit 1031114 by mjansen:
>>
>> Fix memleak. Unregister namespace.
>>
>> I'm pretty sure the design is suboptimal but this is the easiest fix. How
>> about (un)registering the namespace once for each app?
>>
>>  M  +1 -0      dmetadata.cpp
>>
>>
>> --- trunk/extragear/graphics/digikam/ #1031113:1031114
>> @@ -70,6 +70,7 @@
>>
>>  DMetadata::~DMetadata()
>>  {
>> +    unregisterXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/"));
>>  }
>>
>>  bool DMetadata::load(const QString& filePath) const
>>
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Since you don't provide why the compilation fails (would really help) i have
to assume it's because you miss the unregisterXmpNameSpace() method.

I don't know the policy here if digikam is supposed to compile against kde 4.3
. If yes i have to revert. If not you have to update kdegraphics. See commit

http://websvn.kde.org/?revision=1011032&view=revision

Mike


On Sunday 04 October 2009 11:48:28 Michael G. Hansen wrote:

> This commit broke compilation for me. KDE 4.3.1, Qt 4.5.2, gcc-4.3.4.
>
> Michael Hansen
>
> Michael Jansen wrote:
> > SVN commit 1031114 by mjansen:
> >
> > Fix memleak. Unregister namespace.
> >
> > I'm pretty sure the design is suboptimal but this is the easiest fix. How
> > about (un)registering the namespace once for each app?
> >
> >  M  +1 -0      dmetadata.cpp
> >
> >
> > --- trunk/extragear/graphics/digikam/ #1031113:1031114
> > @@ -70,6 +70,7 @@
> >
> >  DMetadata::~DMetadata()
> >  {
> > +  
> > unregisterXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/")); }
> >
> >  bool DMetadata::load(const QString& filePath) const
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/10/5 Michael Jansen <[hidden email]>:
> Since you don't provide why the compilation fails (would really help) i have
> to assume it's because you miss the unregisterXmpNameSpace() method.
>
> I don't know the policy here if digikam is supposed to compile against kde 4.3
> . If yes i have to revert. If not you have to update kdegraphics. See commit

yes, digiKam must compile with KDE 4.3.x. It become the new KDE
desktop in production now...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel