Re: [digikam] core/libs: show video thumbnails and preview always rotated

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [digikam] core/libs: show video thumbnails and preview always rotated

Christoph Feck-2
On 06/10/19 21:37, Maik Qualmann wrote:

> Git commit edb0d06f34d8ee922c565b5f3a72065d550d52b7 by Maik Qualmann.
> Committed on 10/06/2019 at 19:36.
> Pushed by mqualmann into branch 'master'.
>
> show video thumbnails and preview always rotated
>
> M  +4    -1    core/libs/threadimageio/thumb/thumbnailcreator.cpp
> M  +15   -19   core/libs/video/player/mediaplayerview.cpp
> M  +15   -19   core/libs/video/player/slidevideo.cpp
>
> https://invent.kde.org/kde/digikam/commit/edb0d06f34d8ee922c565b5f3a72065d550d52b7

> -#include "metaenginesettings.h"

This caused compilation error on my system:

mediaplayerview.cpp:484:14: error: 'MetaEngine' has not been declared

I am compiling digikam with many optional dependencies disabled, do you
have an idea why the MetaEngine constants are no longer pulled in?

Thanks,
Christoph

--
Christoph Feck
KDE Quality Team

Reply | Threaded
Open this post in threaded view
|

Re: [digikam] core/libs: show video thumbnails and preview always rotated

Maik Qualmann
The metaengine.h is needed here, I fix it tonight.

Maik

Christoph Feck <[hidden email]> schrieb am Mo., 17. Juni 2019 16:34:
On 06/10/19 21:37, Maik Qualmann wrote:
> Git commit edb0d06f34d8ee922c565b5f3a72065d550d52b7 by Maik Qualmann.
> Committed on 10/06/2019 at 19:36.
> Pushed by mqualmann into branch 'master'.
>
> show video thumbnails and preview always rotated
>
> M  +4    -1    core/libs/threadimageio/thumb/thumbnailcreator.cpp
> M  +15   -19   core/libs/video/player/mediaplayerview.cpp
> M  +15   -19   core/libs/video/player/slidevideo.cpp
>
> https://invent.kde.org/kde/digikam/commit/edb0d06f34d8ee922c565b5f3a72065d550d52b7

> -#include "metaenginesettings.h"

This caused compilation error on my system:

mediaplayerview.cpp:484:14: error: 'MetaEngine' has not been declared

I am compiling digikam with many optional dependencies disabled, do you
have an idea why the MetaEngine constants are no longer pulled in?

Thanks,
Christoph

--
Christoph Feck
KDE Quality Team

Reply | Threaded
Open this post in threaded view
|

Re: [digikam] core/libs: show video thumbnails and preview always rotated

Maik Qualmann
Done:

https://invent.kde.org/kde/digikam/commit/
524b2982ae69e0855abc285905fb68d79b824aa3

Maik

Am Montag, 17. Juni 2019, 17:05:17 CEST schrieb Maik Qualmann:

> The metaengine.h is needed here, I fix it tonight.
>
> Maik
>
> Christoph Feck <[hidden email]> schrieb am Mo., 17. Juni 2019 16:34:
> > On 06/10/19 21:37, Maik Qualmann wrote:
> > > Git commit edb0d06f34d8ee922c565b5f3a72065d550d52b7 by Maik Qualmann.
> > > Committed on 10/06/2019 at 19:36.
> > > Pushed by mqualmann into branch 'master'.
> > >
> > > show video thumbnails and preview always rotated
> > >
> > > M  +4    -1    core/libs/threadimageio/thumb/thumbnailcreator.cpp
> > > M  +15   -19   core/libs/video/player/mediaplayerview.cpp
> > > M  +15   -19   core/libs/video/player/slidevideo.cpp
> >
> > https://invent.kde.org/kde/digikam/commit/edb0d06f34d8ee922c565b5f3a72065d
> > 550d52b7>
> > > -#include "metaenginesettings.h"
> >
> > This caused compilation error on my system:
> >
> > mediaplayerview.cpp:484:14: error: 'MetaEngine' has not been declared
> >
> > I am compiling digikam with many optional dependencies disabled, do you
> > have an idea why the MetaEngine constants are no longer pulled in?
> >
> > Thanks,
> > Christoph
> >
> > --
> > Christoph Feck
> > KDE Quality Team




Reply | Threaded
Open this post in threaded view
|

Re: [digikam] core/libs: show video thumbnails and preview always rotated

Christoph Feck-2
On 06/17/19 18:26, Maik Qualmann wrote:
> Done:
>
> https://invent.kde.org/kde/digikam/commit/
> 524b2982ae69e0855abc285905fb68d79b824aa3

Merci, confirmed it worked :)

Christoph