Re: [digikam] /: Somehow the KDebug include is not working correctly, we get a lot of warnings

[Gilles Caulier-4]

Andi,

Just for information, when we have started to port digiKam to KDE4,
Laurent Montel ask to methat it's better to include KDE header using
.h notation, not C++.

For Qt4, it's different. C++ notation is fine. I always apply this way
in my code...

Gilles

2011/3/6 Andi Clemens <[hidden email]>:

> Git commit 5226e4a9ecf333c8a63f8571f316c7e0d9a74bf1 by Andi Clemens.
> Committed on 06/03/2011 at 09:20.
> Pushed by aclemens into branch 'master'.
>
> Somehow the KDebug include is not working correctly, we get a lot of warnings
> during compile. Using "kdebug.h" works, the AREA_CODE for kDebug can be read
> and no compile warnings are visible.
>
> M  +1    -1    libs/dimg/imagehistory/dimagehistory.cpp
> M  +1    -1    libs/imageproperties/imagepropertieshistorytab.cpp
> M  +1    -1    libs/imageproperties/imagepropertiessidebar.cpp
> M  +1    -1    libs/imageproperties/imagepropertiessidebardb.cpp
> M  +1    -1    libs/imageproperties/imagepropertiesversionstab.cpp
> M  +1    -1    libs/imageproperties/versionsdelegate.cpp
> M  +1    -1    libs/imageproperties/versionsoverlays.cpp
> M  +1    -1    libs/imageproperties/versionstreeview.cpp
> M  +1    -1    libs/models/imageversionsmodel.cpp
> M  +1    -1    libs/versionmanager/versionmanager.cpp
> M  +1    -1    libs/widgets/common/filtershistorywidget.cpp
> M  +1    -1    libs/widgets/common/imagefiltershistoryitemdelegate.cpp
> M  +1    -1    libs/widgets/common/imagefiltershistorymodel.cpp
> M  +1    -1    libs/widgets/common/versionswidget.cpp
> M  +1    -1    libs/widgets/graphicsview/clickdragreleaseitem.cpp
> M  +1    -1    utilities/facedetection/facescandialog.cpp
>
> http://commits.kde.org/digikam/5226e4a9ecf333c8a63f8571f316c7e0d9a74bf1
>
> diff --git a/libs/dimg/imagehistory/dimagehistory.cpp b/libs/dimg/imagehistory/dimagehistory.cpp
> index 6fe498d..3a4d453 100644
> --- a/libs/dimg/imagehistory/dimagehistory.cpp
> +++ b/libs/dimg/imagehistory/dimagehistory.cpp
> @@ -35,7 +35,7 @@
>  // KDE includes
>
>  #include <kglobal.h>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <KUrl>
>
>  namespace Digikam
> diff --git a/libs/imageproperties/imagepropertieshistorytab.cpp b/libs/imageproperties/imagepropertieshistorytab.cpp
> index 476229b..1e55cbb 100644
> --- a/libs/imageproperties/imagepropertieshistorytab.cpp
> +++ b/libs/imageproperties/imagepropertieshistorytab.cpp
> @@ -34,7 +34,7 @@
>
>  #include <KUrl>
>  #include <KLocale>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/imageproperties/imagepropertiessidebar.cpp b/libs/imageproperties/imagepropertiessidebar.cpp
> index a979839..eca5632 100644
> --- a/libs/imageproperties/imagepropertiessidebar.cpp
> +++ b/libs/imageproperties/imagepropertiessidebar.cpp
> @@ -40,7 +40,7 @@
>  #include <kcursor.h>
>  #include <kglobal.h>
>  #include <kiconloader.h>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // LibKDcraw includes
>
> diff --git a/libs/imageproperties/imagepropertiessidebardb.cpp b/libs/imageproperties/imagepropertiessidebardb.cpp
> index f05f3ab..ba7fc51 100644
> --- a/libs/imageproperties/imagepropertiessidebardb.cpp
> +++ b/libs/imageproperties/imagepropertiessidebardb.cpp
> @@ -35,7 +35,7 @@
>
>  // KDE includes
>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <kfileitem.h>
>  #include <klocale.h>
>  #include <kconfig.h>
> diff --git a/libs/imageproperties/imagepropertiesversionstab.cpp b/libs/imageproperties/imagepropertiesversionstab.cpp
> index c972d24..50daf45 100644
> --- a/libs/imageproperties/imagepropertiesversionstab.cpp
> +++ b/libs/imageproperties/imagepropertiesversionstab.cpp
> @@ -35,7 +35,7 @@
>  #include <KConfig>
>  #include <KConfigGroup>
>  #include <KGlobal>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <KLocale>
>  #include <KIconLoader>
>  #include <KStandardGuiItem>
> diff --git a/libs/imageproperties/versionsdelegate.cpp b/libs/imageproperties/versionsdelegate.cpp
> index 56379d0..f6881c1 100644
> --- a/libs/imageproperties/versionsdelegate.cpp
> +++ b/libs/imageproperties/versionsdelegate.cpp
> @@ -33,7 +33,7 @@
>
>  // KDE includes
>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <KCategoryDrawer>
>  #include <KColorScheme>
>  #include <KIconLoader>
> diff --git a/libs/imageproperties/versionsoverlays.cpp b/libs/imageproperties/versionsoverlays.cpp
> index 7e03932..2211c2d 100644
> --- a/libs/imageproperties/versionsoverlays.cpp
> +++ b/libs/imageproperties/versionsoverlays.cpp
> @@ -30,7 +30,7 @@
>
>  #include <KLocale>
>  #include <KIconLoader>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/imageproperties/versionstreeview.cpp b/libs/imageproperties/versionstreeview.cpp
> index d6fda2c..34bcd27 100644
> --- a/libs/imageproperties/versionstreeview.cpp
> +++ b/libs/imageproperties/versionstreeview.cpp
> @@ -32,7 +32,7 @@
>
>  #include <KLocale>
>  #include <KIconLoader>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/models/imageversionsmodel.cpp b/libs/models/imageversionsmodel.cpp
> index 15153b3..a5d5543 100644
> --- a/libs/models/imageversionsmodel.cpp
> +++ b/libs/models/imageversionsmodel.cpp
> @@ -26,7 +26,7 @@
>  // KDE includes
>
>  #include <KLocale>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/versionmanager/versionmanager.cpp b/libs/versionmanager/versionmanager.cpp
> index 7352a74..02c18dd 100644
> --- a/libs/versionmanager/versionmanager.cpp
> +++ b/libs/versionmanager/versionmanager.cpp
> @@ -30,9 +30,9 @@
>
>  #include <KConfigGroup>
>  #include <KDiskFreeSpaceInfo>
> -#include <KDebug>
>  #include <KGlobal>
>  #include <KUrl>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/widgets/common/filtershistorywidget.cpp b/libs/widgets/common/filtershistorywidget.cpp
> index a9a6d96..78de8b8 100644
> --- a/libs/widgets/common/filtershistorywidget.cpp
> +++ b/libs/widgets/common/filtershistorywidget.cpp
> @@ -34,7 +34,7 @@
>
>  #include <KUrl>
>  #include <KLocale>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/widgets/common/imagefiltershistoryitemdelegate.cpp b/libs/widgets/common/imagefiltershistoryitemdelegate.cpp
> index ee8c532..9e690a8 100644
> --- a/libs/widgets/common/imagefiltershistoryitemdelegate.cpp
> +++ b/libs/widgets/common/imagefiltershistoryitemdelegate.cpp
> @@ -33,7 +33,7 @@
>
>  #include <KIconLoader>
>  #include <KLocale>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <KColorScheme>
>
>  // Local includes
> diff --git a/libs/widgets/common/imagefiltershistorymodel.cpp b/libs/widgets/common/imagefiltershistorymodel.cpp
> index 43972e9..dd37f83 100644
> --- a/libs/widgets/common/imagefiltershistorymodel.cpp
> +++ b/libs/widgets/common/imagefiltershistorymodel.cpp
> @@ -30,7 +30,7 @@
>  // KDE includes
>
>  #include <KUrl>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <KIconLoader>
>
>  // Local includes
> diff --git a/libs/widgets/common/versionswidget.cpp b/libs/widgets/common/versionswidget.cpp
> index 787bbde..1c7ea69 100644
> --- a/libs/widgets/common/versionswidget.cpp
> +++ b/libs/widgets/common/versionswidget.cpp
> @@ -39,7 +39,7 @@
>  #include <KLocale>
>  #include <KIconLoader>
>  #include <KUrl>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/libs/widgets/graphicsview/clickdragreleaseitem.cpp b/libs/widgets/graphicsview/clickdragreleaseitem.cpp
> index f375230..ea348c1 100644
> --- a/libs/widgets/graphicsview/clickdragreleaseitem.cpp
> +++ b/libs/widgets/graphicsview/clickdragreleaseitem.cpp
> @@ -33,7 +33,7 @@
>
>  // KDE includes
>
> -#include <KDebug>
> +#include <kdebug.h>
>
>  // Local includes
>
> diff --git a/utilities/facedetection/facescandialog.cpp b/utilities/facedetection/facescandialog.cpp
> index 5daf836..97b2be5 100644
> --- a/utilities/facedetection/facescandialog.cpp
> +++ b/utilities/facedetection/facescandialog.cpp
> @@ -40,7 +40,7 @@
>
>  // KDE includes
>
> -#include <KDebug>
> +#include <kdebug.h>
>  #include <KDialog>
>  #include <KIconLoader>
>  #include <KLocale>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Yes I always use the "*.h" notation for KDE, too.
But somehow some files in the digiKam source tree have the "K***" notation  
now.


Andi


On Sun, 06 Mar 2011 10:49:14 +0100, Gilles Caulier  
<[hidden email]> wrote:

> Andi,
>
> Just for information, when we have started to port digiKam to KDE4,
> Laurent Montel ask to methat it's better to include KDE header using
> .h notation, not C++.
>
> For Qt4, it's different. C++ notation is fine. I always apply this way
> in my code...
>
> Gilles
>
> 2011/3/6 Andi Clemens <[hidden email]>:
>> Git commit 5226e4a9ecf333c8a63f8571f316c7e0d9a74bf1 by Andi Clemens.
>> Committed on 06/03/2011 at 09:20.
>> Pushed by aclemens into branch 'master'.
>>
>> Somehow the KDebug include is not working correctly, we get a lot of  
>> warnings
>> during compile. Using "kdebug.h" works, the AREA_CODE for kDebug can be  
>> read
>> and no compile warnings are visible.
>>
>> M  +1    -1    libs/dimg/imagehistory/dimagehistory.cpp
>> M  +1    -1    libs/imageproperties/imagepropertieshistorytab.cpp
>> M  +1    -1    libs/imageproperties/imagepropertiessidebar.cpp
>> M  +1    -1    libs/imageproperties/imagepropertiessidebardb.cpp
>> M  +1    -1    libs/imageproperties/imagepropertiesversionstab.cpp
>> M  +1    -1    libs/imageproperties/versionsdelegate.cpp
>> M  +1    -1    libs/imageproperties/versionsoverlays.cpp
>> M  +1    -1    libs/imageproperties/versionstreeview.cpp
>> M  +1    -1    libs/models/imageversionsmodel.cpp
>> M  +1    -1    libs/versionmanager/versionmanager.cpp
>> M  +1    -1    libs/widgets/common/filtershistorywidget.cpp
>> M  +1    -1    libs/widgets/common/imagefiltershistoryitemdelegate.cpp
>> M  +1    -1    libs/widgets/common/imagefiltershistorymodel.cpp
>> M  +1    -1    libs/widgets/common/versionswidget.cpp
>> M  +1    -1    libs/widgets/graphicsview/clickdragreleaseitem.cpp
>> M  +1    -1    utilities/facedetection/facescandialog.cpp
>>
>> http://commits.kde.org/digikam/5226e4a9ecf333c8a63f8571f316c7e0d9a74bf1
>>
>> diff --git a/libs/dimg/imagehistory/dimagehistory.cpp  
>> b/libs/dimg/imagehistory/dimagehistory.cpp
>> index 6fe498d..3a4d453 100644
>> --- a/libs/dimg/imagehistory/dimagehistory.cpp
>> +++ b/libs/dimg/imagehistory/dimagehistory.cpp
>> @@ -35,7 +35,7 @@
>>  // KDE includes
>>
>>  #include <kglobal.h>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <KUrl>
>>
>>  namespace Digikam
>> diff --git a/libs/imageproperties/imagepropertieshistorytab.cpp  
>> b/libs/imageproperties/imagepropertieshistorytab.cpp
>> index 476229b..1e55cbb 100644
>> --- a/libs/imageproperties/imagepropertieshistorytab.cpp
>> +++ b/libs/imageproperties/imagepropertieshistorytab.cpp
>> @@ -34,7 +34,7 @@
>>
>>  #include <KUrl>
>>  #include <KLocale>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/imageproperties/imagepropertiessidebar.cpp  
>> b/libs/imageproperties/imagepropertiessidebar.cpp
>> index a979839..eca5632 100644
>> --- a/libs/imageproperties/imagepropertiessidebar.cpp
>> +++ b/libs/imageproperties/imagepropertiessidebar.cpp
>> @@ -40,7 +40,7 @@
>>  #include <kcursor.h>
>>  #include <kglobal.h>
>>  #include <kiconloader.h>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // LibKDcraw includes
>>
>> diff --git a/libs/imageproperties/imagepropertiessidebardb.cpp  
>> b/libs/imageproperties/imagepropertiessidebardb.cpp
>> index f05f3ab..ba7fc51 100644
>> --- a/libs/imageproperties/imagepropertiessidebardb.cpp
>> +++ b/libs/imageproperties/imagepropertiessidebardb.cpp
>> @@ -35,7 +35,7 @@
>>
>>  // KDE includes
>>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <kfileitem.h>
>>  #include <klocale.h>
>>  #include <kconfig.h>
>> diff --git a/libs/imageproperties/imagepropertiesversionstab.cpp  
>> b/libs/imageproperties/imagepropertiesversionstab.cpp
>> index c972d24..50daf45 100644
>> --- a/libs/imageproperties/imagepropertiesversionstab.cpp
>> +++ b/libs/imageproperties/imagepropertiesversionstab.cpp
>> @@ -35,7 +35,7 @@
>>  #include <KConfig>
>>  #include <KConfigGroup>
>>  #include <KGlobal>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <KLocale>
>>  #include <KIconLoader>
>>  #include <KStandardGuiItem>
>> diff --git a/libs/imageproperties/versionsdelegate.cpp  
>> b/libs/imageproperties/versionsdelegate.cpp
>> index 56379d0..f6881c1 100644
>> --- a/libs/imageproperties/versionsdelegate.cpp
>> +++ b/libs/imageproperties/versionsdelegate.cpp
>> @@ -33,7 +33,7 @@
>>
>>  // KDE includes
>>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <KCategoryDrawer>
>>  #include <KColorScheme>
>>  #include <KIconLoader>
>> diff --git a/libs/imageproperties/versionsoverlays.cpp  
>> b/libs/imageproperties/versionsoverlays.cpp
>> index 7e03932..2211c2d 100644
>> --- a/libs/imageproperties/versionsoverlays.cpp
>> +++ b/libs/imageproperties/versionsoverlays.cpp
>> @@ -30,7 +30,7 @@
>>
>>  #include <KLocale>
>>  #include <KIconLoader>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/imageproperties/versionstreeview.cpp  
>> b/libs/imageproperties/versionstreeview.cpp
>> index d6fda2c..34bcd27 100644
>> --- a/libs/imageproperties/versionstreeview.cpp
>> +++ b/libs/imageproperties/versionstreeview.cpp
>> @@ -32,7 +32,7 @@
>>
>>  #include <KLocale>
>>  #include <KIconLoader>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/models/imageversionsmodel.cpp  
>> b/libs/models/imageversionsmodel.cpp
>> index 15153b3..a5d5543 100644
>> --- a/libs/models/imageversionsmodel.cpp
>> +++ b/libs/models/imageversionsmodel.cpp
>> @@ -26,7 +26,7 @@
>>  // KDE includes
>>
>>  #include <KLocale>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/versionmanager/versionmanager.cpp  
>> b/libs/versionmanager/versionmanager.cpp
>> index 7352a74..02c18dd 100644
>> --- a/libs/versionmanager/versionmanager.cpp
>> +++ b/libs/versionmanager/versionmanager.cpp
>> @@ -30,9 +30,9 @@
>>
>>  #include <KConfigGroup>
>>  #include <KDiskFreeSpaceInfo>
>> -#include <KDebug>
>>  #include <KGlobal>
>>  #include <KUrl>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/widgets/common/filtershistorywidget.cpp  
>> b/libs/widgets/common/filtershistorywidget.cpp
>> index a9a6d96..78de8b8 100644
>> --- a/libs/widgets/common/filtershistorywidget.cpp
>> +++ b/libs/widgets/common/filtershistorywidget.cpp
>> @@ -34,7 +34,7 @@
>>
>>  #include <KUrl>
>>  #include <KLocale>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/widgets/common/imagefiltershistoryitemdelegate.cpp  
>> b/libs/widgets/common/imagefiltershistoryitemdelegate.cpp
>> index ee8c532..9e690a8 100644
>> --- a/libs/widgets/common/imagefiltershistoryitemdelegate.cpp
>> +++ b/libs/widgets/common/imagefiltershistoryitemdelegate.cpp
>> @@ -33,7 +33,7 @@
>>
>>  #include <KIconLoader>
>>  #include <KLocale>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <KColorScheme>
>>
>>  // Local includes
>> diff --git a/libs/widgets/common/imagefiltershistorymodel.cpp  
>> b/libs/widgets/common/imagefiltershistorymodel.cpp
>> index 43972e9..dd37f83 100644
>> --- a/libs/widgets/common/imagefiltershistorymodel.cpp
>> +++ b/libs/widgets/common/imagefiltershistorymodel.cpp
>> @@ -30,7 +30,7 @@
>>  // KDE includes
>>
>>  #include <KUrl>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <KIconLoader>
>>
>>  // Local includes
>> diff --git a/libs/widgets/common/versionswidget.cpp  
>> b/libs/widgets/common/versionswidget.cpp
>> index 787bbde..1c7ea69 100644
>> --- a/libs/widgets/common/versionswidget.cpp
>> +++ b/libs/widgets/common/versionswidget.cpp
>> @@ -39,7 +39,7 @@
>>  #include <KLocale>
>>  #include <KIconLoader>
>>  #include <KUrl>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/libs/widgets/graphicsview/clickdragreleaseitem.cpp  
>> b/libs/widgets/graphicsview/clickdragreleaseitem.cpp
>> index f375230..ea348c1 100644
>> --- a/libs/widgets/graphicsview/clickdragreleaseitem.cpp
>> +++ b/libs/widgets/graphicsview/clickdragreleaseitem.cpp
>> @@ -33,7 +33,7 @@
>>
>>  // KDE includes
>>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>
>>  // Local includes
>>
>> diff --git a/utilities/facedetection/facescandialog.cpp  
>> b/utilities/facedetection/facescandialog.cpp
>> index 5daf836..97b2be5 100644
>> --- a/utilities/facedetection/facescandialog.cpp
>> +++ b/utilities/facedetection/facescandialog.cpp
>> @@ -40,7 +40,7 @@
>>
>>  // KDE includes
>>
>> -#include <KDebug>
>> +#include <kdebug.h>
>>  #include <KDialog>
>>  #include <KIconLoader>
>>  #include <KLocale>
>>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel