Re: Review Request 125986: Enable gwenview to build against the new versions of libkipi (as well as older ones)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125986: Enable gwenview to build against the new versions of libkipi (as well as older ones)

Shlomi Fish
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125986/

Review request for Digikam, Gwenview and Release Team.
By Shlomi Fish.

Updated nov. 8, 2015, 9:58 p.m.

Repository: gwenview

Description

This patch allows gwenview to build against the new versions of libkipi, and retains compatibility with older ones. See https://mail.kde.org/pipermail/release-team/2015-November/009108.html

Diffs

  • app/kipiinterface.h (d3961e9)
  • app/kipiinterface.cpp (8f71700)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125986: Enable gwenview to build against the new versions of libkipi (as well as older ones)

David Edmundson
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125986/

Ship it!

Ship It!

app/kipiinterface.cpp (Diff revision 1)
463
    return NULL;

why not

return new KIPI::FileReadWriteLock(url);


- David Edmundson


On November 8th, 2015, 9:58 p.m. UTC, Shlomi Fish wrote:

Review request for Digikam, Gwenview and Release Team.
By Shlomi Fish.

Updated Nov. 8, 2015, 9:58 p.m.

Repository: gwenview

Description

This patch allows gwenview to build against the new versions of libkipi, and retains compatibility with older ones. See https://mail.kde.org/pipermail/release-team/2015-November/009108.html

Diffs

  • app/kipiinterface.h (d3961e9)
  • app/kipiinterface.cpp (8f71700)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125986: Enable gwenview to build against the new versions of libkipi (as well as older ones)

David Edmundson
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125986/

On November 9th, 2015, 9:56 p.m. UTC, David Edmundson wrote:

app/kipiinterface.cpp (Diff revision 1)
463
    return NULL;

why not

return new KIPI::FileReadWriteLock(url);

sorry, didn't mean to post that comment. I thought I'd deleted it (stupid RB). This method won't be called anyway. This is fine.


- David


On November 8th, 2015, 9:58 p.m. UTC, Shlomi Fish wrote:

Review request for Digikam, Gwenview and Release Team.
By Shlomi Fish.

Updated Nov. 8, 2015, 9:58 p.m.

Repository: gwenview

Description

This patch allows gwenview to build against the new versions of libkipi, and retains compatibility with older ones. See https://mail.kde.org/pipermail/release-team/2015-November/009108.html

Diffs

  • app/kipiinterface.h (d3961e9)
  • app/kipiinterface.cpp (8f71700)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 125986: Enable gwenview to build against the new versions of libkipi (as well as older ones)

Shlomi Fish
In reply to this post by Shlomi Fish
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125986/

This change has been marked as submitted.


Review request for Digikam, Gwenview and Release Team.
By Shlomi Fish.

Updated Nov. 14, 2015, 3:14 p.m.

Changes

Submitted with commit 68a5acbe6e12f5a1e84d9ccefed668735744cbfb by Albert Astals Cid on behalf of Shlomi Fish to branch master.
Repository: gwenview

Description

This patch allows gwenview to build against the new versions of libkipi, and retains compatibility with older ones. See https://mail.kde.org/pipermail/release-team/2015-November/009108.html

Diffs

  • app/kipiinterface.h (d3961e9)
  • app/kipiinterface.cpp (8f71700)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel