Re: [Kde-pim] Akonadi Contact library: Targets not properly exported

[Scarlett Clark]

It has to do with /path/to/include/KF5/path/to/camelcase , the key is actually the KF5 folder.
If I patch  include/KF5/Path/To/Camelcase file it works, however the camel case file does not find its own header.

/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kde/kdepimlibs/inst/usr/include/KF5/Akonadi/Contact/ContactSearchJob:1:46: fatal error: akonadi/contact/contactsearchjob.h: No such file or directory
22:47:37 compilation terminated.

I can only assume the KF5 folder is involved again. So I tried to add KF5 to the ecm_generate_headers(PREFIX) but that has the effect of lower case kf5 which also does not work, obviously.

So I turned back to Digikam and patched:

-#include <Akonadi/Contact/ContactSearchJob>
+#include <KF5/akonadi/contact/contactsearchjob.h>

And finally we have a successful build.

https://build.kde.org/job/digikam%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/console

I do notice KDE_INSTALL_INCLUDEDIR_KF5 in kdepimlibs is likely what puts in this KF5 folder?

I do not know who is responsible here, but someone needs to fix something :) I have exhausted my current C++ skills to get this far lol.

I have added digikam to the conversation.

Cheers,

Scarlett

On Thu, Mar 31, 2016 at 11:48 PM, Ben Cooksley <[hidden email]> wrote:

On Thu, Mar 31, 2016 at 11:44 PM, Christophe Giboudeaux
<[hidden email]> wrote:
> On mercredi 30 mars 2016 20:19:29 CEST Ben Cooksley wrote:
>> On Tue, Mar 29, 2016 at 10:46 PM, Sandro Knauß <[hidden email]> wrote:
>>
>> Those are the header generation and installation routines - which do
>> indeed look.
>> What is missing in this case is the include path specification for the
>> KF5::AkonadiContact target which CMake provides.
>>
>
> The exported target is correct.
> From KF5AkonadiContactTargets.cmake :
>
> set_target_properties(KF5::AkonadiContact PROPERTIES
> INTERFACE_INCLUDE_DIRECTORIES
>  "${_IMPORT_PREFIX}/include/KF5/Akonadi/Contact;
>   ${_IMPORT_PREFIX}/include/KF5;
>   ${_IMPORT_PREFIX}/include/KF5/akonadi/contact;
>   ${_IMPORT_PREFIX}/include/KF5"
>   INTERFACE_LINK_LIBRARIES "KF5::AkonadiCore;KF5::Contacts;Qt5::Widgets"
> )

Hmm, indeed that does look correct.
I wonder why Digikam would fail to compile then:

19:24:09 /home/jenkins/sources/digikam/kf5-qt5/utilities/kdesupport/akonadi/akonadiiface.cpp:47:44:
fatal error: Akonadi/Contact/ContactSearchJob: No such file or
directory

Any ideas? (I assume Digikam is trying using to use AkonadiContact correctly)

Cheers,
Ben

>
> _______________________________________________
> Kde-buildsystem mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/kde-buildsystem

>
_______________________________________________
KDE PIM mailing list [hidden email]
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Hi Scarlet,

-#include <Akonadi/Contact/ContactSearchJob>
+#include <KF5/akonadi/contact/contactsearchjob.h>

This patch sound like a wrong way to handle frameworks header. After all i never use #include <KF5/...> syntax, and there is no reason to do it.

Using the .h file instead the camelcase version is not a problem, but both cases must work well in client application.

Gilles Caulier

2016-04-07 3:01 GMT+02:00 Scarlett Clark <[hidden email]>:

It has to do with /path/to/include/KF5/path/to/camelcase , the key is actually the KF5 folder.
If I patch  include/KF5/Path/To/Camelcase file it works, however the camel case file does not find its own header.

/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kde/kdepimlibs/inst/usr/include/KF5/Akonadi/Contact/ContactSearchJob:1:46: fatal error: akonadi/contact/contactsearchjob.h: No such file or directory
22:47:37 compilation terminated.

I can only assume the KF5 folder is involved again. So I tried to add KF5 to the ecm_generate_headers(PREFIX) but that has the effect of lower case kf5 which also does not work, obviously.

So I turned back to Digikam and patched:

-#include <Akonadi/Contact/ContactSearchJob>
+#include <KF5/akonadi/contact/contactsearchjob.h>

And finally we have a successful build.

https://build.kde.org/job/digikam%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/console

I do notice KDE_INSTALL_INCLUDEDIR_KF5 in kdepimlibs is likely what puts in this KF5 folder?

I do not know who is responsible here, but someone needs to fix something :) I have exhausted my current C++ skills to get this far lol.

I have added digikam to the conversation.

Cheers,

Scarlett

On Thu, Mar 31, 2016 at 11:48 PM, Ben Cooksley <[hidden email]> wrote:

On Thu, Mar 31, 2016 at 11:44 PM, Christophe Giboudeaux
<[hidden email]> wrote:
> On mercredi 30 mars 2016 20:19:29 CEST Ben Cooksley wrote:
>> On Tue, Mar 29, 2016 at 10:46 PM, Sandro Knauß <[hidden email]> wrote:
>>
>> Those are the header generation and installation routines - which do
>> indeed look.
>> What is missing in this case is the include path specification for the
>> KF5::AkonadiContact target which CMake provides.
>>
>
> The exported target is correct.
> From KF5AkonadiContactTargets.cmake :
>
> set_target_properties(KF5::AkonadiContact PROPERTIES
> INTERFACE_INCLUDE_DIRECTORIES
>  "${_IMPORT_PREFIX}/include/KF5/Akonadi/Contact;
>   ${_IMPORT_PREFIX}/include/KF5;
>   ${_IMPORT_PREFIX}/include/KF5/akonadi/contact;
>   ${_IMPORT_PREFIX}/include/KF5"
>   INTERFACE_LINK_LIBRARIES "KF5::AkonadiCore;KF5::Contacts;Qt5::Widgets"
> )

Hmm, indeed that does look correct.
I wonder why Digikam would fail to compile then:

19:24:09 /home/jenkins/sources/digikam/kf5-qt5/utilities/kdesupport/akonadi/akonadiiface.cpp:47:44:
fatal error: Akonadi/Contact/ContactSearchJob: No such file or
directory

Any ideas? (I assume Digikam is trying using to use AkonadiContact correctly)

Cheers,
Ben

>
> _______________________________________________
> Kde-buildsystem mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/kde-buildsystem

>
_______________________________________________
KDE PIM mailing list [hidden email]
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Scarlett Clark]

On Fri, Apr 8, 2016 at 5:38 AM, Gilles Caulier <[hidden email]> wrote:

Hi Scarlet,

-#include <Akonadi/Contact/ContactSearchJob>
+#include <KF5/akonadi/contact/contactsearchjob.h>

This patch sound like a wrong way to handle frameworks header. After all i
never use #include <KF5/...> syntax, and there is no reason to do it.

Using the .h file instead the camelcase version is not a problem, but both
cases must work well in client application.

Gilles Caulier

As I stated above I don't care HOW it is fixed. But someone NEEDS to fix it. My patch above makes Digikam build. Period. I can certainly remove it, but then you are back to a permanent build failure.

I am not a C++ programmer, my knowledge is minimal. I hate red jobs, so I took time out of my vacation and fought with this for many days, as no one else did.

Please fix it properly, anyone.

Thanks,

Scarlett

2016-04-07 3:01 GMT+02:00 Scarlett Clark <[hidden email]>:

> It has to do with /path/to/include/KF5/path/to/camelcase , the key is
> actually the KF5 folder.
> If I patch  include/KF5/Path/To/Camelcase file it works, however the camel
> case file does not find its own header.
>
> /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kde/kdepimlibs/inst/usr/include/KF5/Akonadi/Contact/ContactSearchJob:1:46: fatal error: akonadi/contact/contactsearchjob.h: No such file or directory*22:47:37* compilation terminated.

>
> I can only assume the KF5 folder is involved again. So I tried to add KF5
> to the ecm_generate_headers(PREFIX) but that has the effect of lower case
> kf5 which also does not work, obviously.
>
> So I turned back to Digikam and patched:
>
> -#include <Akonadi/Contact/ContactSearchJob>
> +#include <KF5/akonadi/contact/contactsearchjob.h>
>
> And finally we have a successful build.
>
>
> https://build.kde.org/job/digikam%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/console
>
> I do notice KDE_INSTALL_INCLUDEDIR_KF5 in kdepimlibs is likely what puts
> in this KF5 folder?
>
> I do not know who is responsible here, but someone needs to fix something
> :) I have exhausted my current C++ skills to get this far lol.
>
> I have added digikam to the conversation.
> Cheers,
> Scarlett
>
>
> On Thu, Mar 31, 2016 at 11:48 PM, Ben Cooksley <[hidden email]> wrote:
>
>> On Thu, Mar 31, 2016 at 11:44 PM, Christophe Giboudeaux
>> <[hidden email]> wrote:
>> > On mercredi 30 mars 2016 20:19:29 CEST Ben Cooksley wrote:
>> >> On Tue, Mar 29, 2016 at 10:46 PM, Sandro Knauß <[hidden email]>
>> wrote:
>> >>
>> >> Those are the header generation and installation routines - which do
>> >> indeed look.
>> >> What is missing in this case is the include path specification for the
>> >> KF5::AkonadiContact target which CMake provides.
>> >>
>> >
>> > The exported target is correct.
>> > From KF5AkonadiContactTargets.cmake :
>> >
>> > set_target_properties(KF5::AkonadiContact PROPERTIES
>> > INTERFACE_INCLUDE_DIRECTORIES
>> >  "${_IMPORT_PREFIX}/include/KF5/Akonadi/Contact;
>> >   ${_IMPORT_PREFIX}/include/KF5;
>> >   ${_IMPORT_PREFIX}/include/KF5/akonadi/contact;
>> >   ${_IMPORT_PREFIX}/include/KF5"
>> >   INTERFACE_LINK_LIBRARIES "KF5::AkonadiCore;KF5::Contacts;Qt5::Widgets"
>> > )
>>
>> Hmm, indeed that does look correct.
>> I wonder why Digikam would fail to compile then:
>>
>> 19:24:09
>> /home/jenkins/sources/digikam/kf5-qt5/utilities/kdesupport/akonadi/akonadiiface.cpp:47:44:
>> fatal error: Akonadi/Contact/ContactSearchJob: No such file or
>> directory
>>
>> Any ideas? (I assume Digikam is trying using to use AkonadiContact
>> correctly)
>>
>> Cheers,
>> Ben
>>
>> >
>> > _______________________________________________
>> > Kde-buildsystem mailing list
>> > [hidden email]
>> > https://mail.kde.org/mailman/listinfo/kde-buildsystem
>> >
>> _______________________________________________
>> KDE PIM mailing list [hidden email]
>> https://mail.kde.org/mailman/listinfo/kde-pim
>> KDE PIM home page at http://pim.kde.org/
>>
>
>

> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

>
>
_______________________________________________
KDE PIM mailing list [hidden email]
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ben Cooksley]

On Sat, Apr 9, 2016 at 12:38 AM, Gilles Caulier
<[hidden email]> wrote:
> Hi Scarlet,

Hi GIlles, PIM developers,

>
> -#include <Akonadi/Contact/ContactSearchJob>
> +#include <KF5/akonadi/contact/contactsearchjob.h>
>
> This patch sound like a wrong way to handle frameworks header. After all i
> never use #include <KF5/...> syntax, and there is no reason to do it.
>
> Using the .h file instead the camelcase version is not a problem, but both
> cases must work well in client application.

Can someone please investigate the issue within the Akonadi Contact library?
Assuming the part of Digikam which is trying to use this header is
linking to the appropriate library using the provided target, then
this compilation failure would indicate that targets are not being
properly exported despite appearing to be so.

It would be appreciated if you jointly investigated why this isn't working.

Also, PIM devs - you've broken your CI jobs with your version bump *again*.
Please check with dfaure on how he handles the Frameworks version
bumps - those don't experience these issues.

>
> Gilles Caulier

Regards,
Ben

>
> 2016-04-07 3:01 GMT+02:00 Scarlett Clark <[hidden email]>:
>>
>> It has to do with /path/to/include/KF5/path/to/camelcase , the key is
>> actually the KF5 folder.
>> If I patch  include/KF5/Path/To/Camelcase file it works, however the camel
>> case file does not find its own header.
>>
>>
>> /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kde/kdepimlibs/inst/usr/include/KF5/Akonadi/Contact/ContactSearchJob:1:46:
>> fatal error: akonadi/contact/contactsearchjob.h: No such file or directory
>> 22:47:37 compilation terminated.
>>
>> I can only assume the KF5 folder is involved again. So I tried to add KF5
>> to the ecm_generate_headers(PREFIX) but that has the effect of lower case
>> kf5 which also does not work, obviously.
>>
>> So I turned back to Digikam and patched:
>>
>> -#include <Akonadi/Contact/ContactSearchJob>
>> +#include <KF5/akonadi/contact/contactsearchjob.h>
>>
>> And finally we have a successful build.
>>
>>
>> https://build.kde.org/job/digikam%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/console
>>
>> I do notice KDE_INSTALL_INCLUDEDIR_KF5 in kdepimlibs is likely what puts
>> in this KF5 folder?
>>
>> I do not know who is responsible here, but someone needs to fix something
>> :) I have exhausted my current C++ skills to get this far lol.
>>
>> I have added digikam to the conversation.
>> Cheers,
>> Scarlett
>>
>>
>> On Thu, Mar 31, 2016 at 11:48 PM, Ben Cooksley <[hidden email]> wrote:
>>>
>>> On Thu, Mar 31, 2016 at 11:44 PM, Christophe Giboudeaux
>>> <[hidden email]> wrote:
>>> > On mercredi 30 mars 2016 20:19:29 CEST Ben Cooksley wrote:
>>> >> On Tue, Mar 29, 2016 at 10:46 PM, Sandro Knauß <[hidden email]>
>>> >> wrote:
>>> >>
>>> >> Those are the header generation and installation routines - which do
>>> >> indeed look.
>>> >> What is missing in this case is the include path specification for the
>>> >> KF5::AkonadiContact target which CMake provides.
>>> >>
>>> >
>>> > The exported target is correct.
>>> > From KF5AkonadiContactTargets.cmake :
>>> >
>>> > set_target_properties(KF5::AkonadiContact PROPERTIES
>>> > INTERFACE_INCLUDE_DIRECTORIES
>>> >  "${_IMPORT_PREFIX}/include/KF5/Akonadi/Contact;
>>> >   ${_IMPORT_PREFIX}/include/KF5;
>>> >   ${_IMPORT_PREFIX}/include/KF5/akonadi/contact;
>>> >   ${_IMPORT_PREFIX}/include/KF5"
>>> >   INTERFACE_LINK_LIBRARIES
>>> > "KF5::AkonadiCore;KF5::Contacts;Qt5::Widgets"
>>> > )
>>>
>>> Hmm, indeed that does look correct.
>>> I wonder why Digikam would fail to compile then:
>>>
>>> 19:24:09
>>> /home/jenkins/sources/digikam/kf5-qt5/utilities/kdesupport/akonadi/akonadiiface.cpp:47:44:
>>> fatal error: Akonadi/Contact/ContactSearchJob: No such file or
>>> directory
>>>
>>> Any ideas? (I assume Digikam is trying using to use AkonadiContact
>>> correctly)
>>>
>>> Cheers,
>>> Ben
>>>
>>> >
>>> > _______________________________________________
>>> > Kde-buildsystem mailing list
>>> > [hidden email]
>>> > https://mail.kde.org/mailman/listinfo/kde-buildsystem
>>> >
>>> _______________________________________________
>>> KDE PIM mailing list [hidden email]
>>> https://mail.kde.org/mailman/listinfo/kde-pim
>>> KDE PIM home page at http://pim.kde.org/
>>
>>
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christophe Giboudeaux]

On samedi 9 avril 2016 08:53:51 CEST Ben Cooksley wrote:

> On Sat, Apr 9, 2016 at 12:38 AM, Gilles Caulier
>
> <[hidden email]> wrote:
> > Hi Scarlet,
>
> Hi GIlles, PIM developers,
>
> > -#include <Akonadi/Contact/ContactSearchJob>
> > +#include <KF5/akonadi/contact/contactsearchjob.h>
> >
> > This patch sound like a wrong way to handle frameworks header. After all i
> > never use #include <KF5/...> syntax, and there is no reason to do it.
> >
> > Using the .h file instead the camelcase version is not a problem, but both
> > cases must work well in client application.
>
> Can someone please investigate the issue within the Akonadi Contact library?
> Assuming the part of Digikam which is trying to use this header is linking
> to the appropriate library using the provided target, then this compilation
> failure would indicate that targets are not being properly exported despite
> appearing to be so.
>

To investigate the digikam issue, a failing build log with VERBOSE=1 would
certainly help.


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ben Cooksley]

On Sat, Apr 9, 2016 at 8:07 PM, Christophe Giboudeaux
<[hidden email]> wrote:

> On samedi 9 avril 2016 08:53:51 CEST Ben Cooksley wrote:
>> On Sat, Apr 9, 2016 at 12:38 AM, Gilles Caulier
>>
>> <[hidden email]> wrote:
>> > Hi Scarlet,
>>
>> Hi GIlles, PIM developers,
>>
>> > -#include <Akonadi/Contact/ContactSearchJob>
>> > +#include <KF5/akonadi/contact/contactsearchjob.h>
>> >
>> > This patch sound like a wrong way to handle frameworks header. After all i
>> > never use #include <KF5/...> syntax, and there is no reason to do it.
>> >
>> > Using the .h file instead the camelcase version is not a problem, but both
>> > cases must work well in client application.
>>
>> Can someone please investigate the issue within the Akonadi Contact library?
>> Assuming the part of Digikam which is trying to use this header is linking
>> to the appropriate library using the provided target, then this compilation
>> failure would indicate that targets are not being properly exported despite
>> appearing to be so.
>>
>
> To investigate the digikam issue, a failing build log with VERBOSE=1 would
> certainly help.

The relevant fragment is attached - a full VERBOSE=1 log for the
entire of Digikam up to the point where it fails would be many
megabytes in size (which is why they're not enabled on the CI system).

Cheers,
Ben

>
>
> _______________________________________________
> Kde-buildsystem mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ben Cooksley]

On Wed, Apr 27, 2016 at 7:11 PM, Stephen Kelly <[hidden email]> wrote:
> Ben Cooksley wrote:
>
>> It would be appreciated if you jointly investigated why this isn't
>> working.
>
> Hi,

Hi Stephen,

>
> Sorry for not being active on this before.
>
> I tried to build the akonadi parts of digikam master with akonadi-contacts
> from kdepimlibs, and it worked. I also notice that the build on b.k.o is not
> red and the #include seems to be as it has always been.
>
> Has this issue been resolved somehow?

Yes, the fault in Digikam's code has been resolved.
From what I understand it has something to do with some of the more
unusual CMake constructs which Digikam was using (and is a fault the
CMake developers have acknowledged but is apparently rather difficult
to fix)

>
> Thanks,
>
> Steve.

Cheers,
Ben

>
>
>
> _______________________________________________
> Kde-buildsystem mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ben Cooksley]

On Thu, Apr 28, 2016 at 7:22 AM, Stephen Kelly <[hidden email]> wrote:

> Ben Cooksley wrote:
>
>>> Has this issue been resolved somehow?
>>
>> Yes, the fault in Digikam's code has been resolved.
>> From what I understand it has something to do with some of the more
>> unusual CMake constructs which Digikam was using (and is a fault the
>> CMake developers have acknowledged but is apparently rather difficult
>> to fix)
>
> I'm curious, so I looked through some recent digikam commits but didn't find
> what you are referring to. Can someone point me to more information?

Sure. This appears to be the relevant commit:
https://quickgit.kde.org/?p=digikam.git&a=commitdiff&h=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e

If you need more details I'll see what I can find.

>
> Thanks,
>
> Steve.

Cheers,
Ben

>
>
> _______________________________________________
> Kde-buildsystem mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Aleix Pol]

On Thu, Apr 28, 2016 at 8:28 AM, Ben Cooksley <[hidden email]> wrote:

> On Thu, Apr 28, 2016 at 7:22 AM, Stephen Kelly <[hidden email]> wrote:
>> Ben Cooksley wrote:
>>
>>>> Has this issue been resolved somehow?
>>>
>>> Yes, the fault in Digikam's code has been resolved.
>>> From what I understand it has something to do with some of the more
>>> unusual CMake constructs which Digikam was using (and is a fault the
>>> CMake developers have acknowledged but is apparently rather difficult
>>> to fix)
>>
>> I'm curious, so I looked through some recent digikam commits but didn't find
>> what you are referring to. Can someone point me to more information?
>
> Sure. This appears to be the relevant commit:
> https://quickgit.kde.org/?p=digikam.git&a=commitdiff&h=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e
>
> If you need more details I'll see what I can find.

That commit looks wrong, if anything maybe AkonadiContacts should have
become PUBLIC.

Aleix
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ben Cooksley]

On Thu, Apr 28, 2016 at 11:32 PM, Aleix Pol <[hidden email]> wrote:

> On Thu, Apr 28, 2016 at 8:28 AM, Ben Cooksley <[hidden email]> wrote:
>> On Thu, Apr 28, 2016 at 7:22 AM, Stephen Kelly <[hidden email]> wrote:
>>> Ben Cooksley wrote:
>>>
>>>>> Has this issue been resolved somehow?
>>>>
>>>> Yes, the fault in Digikam's code has been resolved.
>>>> From what I understand it has something to do with some of the more
>>>> unusual CMake constructs which Digikam was using (and is a fault the
>>>> CMake developers have acknowledged but is apparently rather difficult
>>>> to fix)
>>>
>>> I'm curious, so I looked through some recent digikam commits but didn't find
>>> what you are referring to. Can someone point me to more information?
>>
>> Sure. This appears to be the relevant commit:
>> https://quickgit.kde.org/?p=digikam.git&a=commitdiff&h=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e
>>
>> If you need more details I'll see what I can find.
>
> That commit looks wrong, if anything maybe AkonadiContacts should have
> become PUBLIC.

From what I understand, AkonadiContacts is fine - the bug is in CMake
not passing the targets automagic through the OBJECT construct Digikam
uses.

>
> Aleix

Cheers,
Ben

> _______________________________________________
> Kde-buildsystem mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel