Random crashes

I have random crashes caused by exiv2, usually on startup or after clicking
around in digiKam after some time.

[........ ONLY RELEVANT PARTS SHOWN]

Thread 4 (Thread 0xa0019b70 (LWP 6776)):
[KCrash Handler]
#6  0xb46a8df1 in Exiv2::XmpProperties::registerNs(std::string const&,
std::string const&) () from /usr/lib/libexiv2.so.5
#7  0xb6f6c75e in KExiv2Iface::KExiv2::registerXmpNameSpace (this=0xa0018604,
uri=..., prefix=...) at
/home/andi/Programmieren/KDE/digiKam/libs_KDE4/libs/libkexiv2/libkexiv2/kexiv2xmp.cpp:782
#8  0xb680b296 in DMetadata (this=0xa0018604) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dmetadata/dmetadata.cpp:66
#9  0xb67cab6d in Digikam::DImgLoader::checkExifWorkingColorSpace
(this=0xa0018ca8) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loaders/dimgloader.cpp:206
#10 0xb67cfe7b in Digikam::JPEGLoader::load (this=0xa0018ca8, filePath=...,
observer=0xb052730) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loaders/jpegloader.cpp:513
#11 0xb67b33c3 in Digikam::DImg::load (this=0xa00191f8, filePath=...,
loadFlagsInt=31, observer=0xb052730, rawDecodingSettings=...)
    at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.cpp:376
#12 0xb67b2ee7 in Digikam::DImg::load (this=0xa00191f8, filePath=...,
observer=0xb052730, rawDecodingSettings=...) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.cpp:337
#13 0xb67b1df0 in DImg (this=0xa00191f8, filePath=..., observer=0xb052730,
rawDecodingSettings=...) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.cpp:100
#14 0xb68adcbd in Digikam::SharedLoadingTask::execute (this=0xb052728) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadimageio/loadsavetask.cpp:180
#15 0xb689fd5c in Digikam::LoadSaveThread::run (this=0x9b5acf0) at
/home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadimageio/loadsavethread.cpp:135
#16 0xb4ce3922 in ?? () from /usr/lib/libQtCore.so.4
#17 0xb4c5f65c in start_thread () from /lib/libpthread.so.0
#18 0xb4aaa1fe in clone () from /lib/libc.so.6

[........ ONLY RELEVANT PARTS SHOWN]


Can you confirm this?
Components:

digiKam version 1.0.0-beta6
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: No
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibExiv2: 0.18.2
LibJPEG: 70
LibJasper: 1.900.1
LibKDE: 4.3.2 (KDE 4.3.2)
LibKExiv2: 1.0.0
LibKdcraw: 1.0.0
LibLCMS: 118
LibPGF: 6.09.33
LibPNG: 1.2.39
LibQt: 4.5.3
LibRaw: 0.8.3
LibTIFF: LIBTIFF, Version 3.9.1 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Marble widget: 0.8.1
Parallelized demosaicing: Yes
LibGphoto2: 2.4.6
LibKipi: 1.0.0


Andi


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/10/28 Andi Clemens <[hidden email]>:

> I have random crashes caused by exiv2, usually on startup or after clicking
> around in digiKam after some time.
>
> [........ ONLY RELEVANT PARTS SHOWN]
>
> Thread 4 (Thread 0xa0019b70 (LWP 6776)):
> [KCrash Handler]
> #6  0xb46a8df1 in Exiv2::XmpProperties::registerNs(std::string const&,
> std::string const&) () from /usr/lib/libexiv2.so.5
> #7  0xb6f6c75e in KExiv2Iface::KExiv2::registerXmpNameSpace (this=0xa0018604,
> uri=..., prefix=...) at
> /home/andi/Programmieren/KDE/digiKam/libs_KDE4/libs/libkexiv2/libkexiv2/kexiv2xmp.cpp:782
> #8  0xb680b296 in DMetadata (this=0xa0018604) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dmetadata/dmetadata.cpp:66
> #9  0xb67cab6d in Digikam::DImgLoader::checkExifWorkingColorSpace
> (this=0xa0018ca8) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loaders/dimgloader.cpp:206
> #10 0xb67cfe7b in Digikam::JPEGLoader::load (this=0xa0018ca8, filePath=...,
> observer=0xb052730) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loaders/jpegloader.cpp:513
> #11 0xb67b33c3 in Digikam::DImg::load (this=0xa00191f8, filePath=...,
> loadFlagsInt=31, observer=0xb052730, rawDecodingSettings=...)
>    at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.cpp:376
> #12 0xb67b2ee7 in Digikam::DImg::load (this=0xa00191f8, filePath=...,
> observer=0xb052730, rawDecodingSettings=...) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.cpp:337
> #13 0xb67b1df0 in DImg (this=0xa00191f8, filePath=..., observer=0xb052730,
> rawDecodingSettings=...) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.cpp:100
> #14 0xb68adcbd in Digikam::SharedLoadingTask::execute (this=0xb052728) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadimageio/loadsavetask.cpp:180
> #15 0xb689fd5c in Digikam::LoadSaveThread::run (this=0x9b5acf0) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadimageio/loadsavethread.cpp:135
> #16 0xb4ce3922 in ?? () from /usr/lib/libQtCore.so.4
> #17 0xb4c5f65c in start_thread () from /lib/libpthread.so.0
> #18 0xb4aaa1fe in clone () from /lib/libc.so.6
>
> [........ ONLY RELEVANT PARTS SHOWN]
>
>
> Can you confirm this?

No. but with my new computer, i don't use yet Exiv2 from trunk

I will take a look.

Note : in your backtrace, crash appear in XMP sdk section to register
new namespace, as for LightRoom. I cannot see why it will crash here.
Perhaps it's due to recent update of xmp sdk  from Adobe in Exiv2...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I don't use exiv2 from SVN either, I use 0.18.2.
Also, when not using the suppressions file from /projects folder, I get tons
of errors about exiv2.

Andi

On Thursday 29 October 2009 08:05:31 Gilles Caulier wrote:

> 2009/10/28 Andi Clemens <[hidden email]>:
> > I have random crashes caused by exiv2, usually on startup or after
> > clicking around in digiKam after some time.
> >
> > [........ ONLY RELEVANT PARTS SHOWN]
> >
> > Thread 4 (Thread 0xa0019b70 (LWP 6776)):
> > [KCrash Handler]
> > #6  0xb46a8df1 in Exiv2::XmpProperties::registerNs(std::string const&,
> > std::string const&) () from /usr/lib/libexiv2.so.5
> > #7  0xb6f6c75e in KExiv2Iface::KExiv2::registerXmpNameSpace
> > (this=0xa0018604, uri=..., prefix=...) at
> > /home/andi/Programmieren/KDE/digiKam/libs_KDE4/libs/libkexiv2/libkexiv2/k
> >exiv2xmp.cpp:782 #8  0xb680b296 in DMetadata (this=0xa0018604) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dmetadata/
> >dmetadata.cpp:66 #9  0xb67cab6d in
> > Digikam::DImgLoader::checkExifWorkingColorSpace (this=0xa0018ca8) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loade
> >rs/dimgloader.cpp:206 #10 0xb67cfe7b in Digikam::JPEGLoader::load
> > (this=0xa0018ca8, filePath=..., observer=0xb052730) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loade
> >rs/jpegloader.cpp:513 #11 0xb67b33c3 in Digikam::DImg::load
> > (this=0xa00191f8, filePath=..., loadFlagsInt=31, observer=0xb052730,
> > rawDecodingSettings=...)
> >    at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.
> >cpp:376 #12 0xb67b2ee7 in Digikam::DImg::load (this=0xa00191f8,
> > filePath=..., observer=0xb052730, rawDecodingSettings=...) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.
> >cpp:337 #13 0xb67b1df0 in DImg (this=0xa00191f8, filePath=...,
> > observer=0xb052730, rawDecodingSettings=...) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dimg.
> >cpp:100 #14 0xb68adcbd in Digikam::SharedLoadingTask::execute
> > (this=0xb052728) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadimag
> >eio/loadsavetask.cpp:180 #15 0xb689fd5c in Digikam::LoadSaveThread::run
> > (this=0x9b5acf0) at
> > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadimag
> >eio/loadsavethread.cpp:135 #16 0xb4ce3922 in ?? () from
> > /usr/lib/libQtCore.so.4
> > #17 0xb4c5f65c in start_thread () from /lib/libpthread.so.0
> > #18 0xb4aaa1fe in clone () from /lib/libc.so.6
> >
> > [........ ONLY RELEVANT PARTS SHOWN]
> >
> >
> > Can you confirm this?
>
> No. but with my new computer, i don't use yet Exiv2 from trunk
>
> I will take a look.
>
> Note : in your backtrace, crash appear in XMP sdk section to register
> new namespace, as for LightRoom. I cannot see why it will crash here.
> Perhaps it's due to recent update of xmp sdk  from Adobe in Exiv2...
>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Thread 4 (Thread 0xa0019b70 (LWP 6776)):
> [KCrash Handler]
> #6  0xb46a8df1 in Exiv2::XmpProperties::registerNs(std::string const&,
> std::string const&) () from /usr/lib/libexiv2.so.5
> #7  0xb6f6c75e in KExiv2Iface::KExiv2::registerXmpNameSpace
>  (this=0xa0018604, uri=..., prefix=...) at
> /home/andi/Programmieren/KDE/digiKam/libs_KDE4/libs/libkexiv2/libkexiv2/kex
> iv2xmp.cpp:782 #8  0xb680b296 in DMetadata (this=0xa0018604) at
> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dmetadata/dm
> etadata.cpp:66    

registerXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/"),
QString("lr"));

is this call necessary each time we use a new DMetadata object??
I would expect to call this once at application startup?

I would suspect a thread-safety issue with registering namespaces.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/10/29 Marcel Wiesweg <[hidden email]>:

>
>> Thread 4 (Thread 0xa0019b70 (LWP 6776)):
>> [KCrash Handler]
>> #6  0xb46a8df1 in Exiv2::XmpProperties::registerNs(std::string const&,
>> std::string const&) () from /usr/lib/libexiv2.so.5
>> #7  0xb6f6c75e in KExiv2Iface::KExiv2::registerXmpNameSpace
>>  (this=0xa0018604, uri=..., prefix=...) at
>> /home/andi/Programmieren/KDE/digiKam/libs_KDE4/libs/libkexiv2/libkexiv2/kex
>> iv2xmp.cpp:782 #8  0xb680b296 in DMetadata (this=0xa0018604) at
>> /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dmetadata/dm
>> etadata.cpp:66
>
> registerXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/"),
> QString("lr"));
>
> is this call necessary each time we use a new DMetadata object??
> I would expect to call this once at application startup?
>
> I would suspect a thread-safety issue with registering namespaces.

Perhaps, but i'm not sure...

It's better to ask to Andreas...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

>> registerXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/"),
>> QString("lr"));
>>
>> is this call necessary each time we use a new DMetadata object??
>> I would expect to call this once at application startup?
>>
>> I would suspect a thread-safety issue with registering namespaces.

Once at application startup is enough. That call needs to be
serialized: http://dev.exiv2.org/wiki/exiv2/Thread_safety

On the other hand wouldn't such a basic issue have been reported a
long time ago?

Andi,
can you double-check if you have multiple versions of Exiv2 on your
computer? The weirdest problems have been caused in cases where
different versions were used by digiKam and libkexiv2.

Andreas
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> On the other hand wouldn't such a basic issue have been reported a
> long time ago?

Maybe it was: http://bugs.kde.org/show_bug.cgi?id=166424
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

ah yes, now, i rememeber the story.

registered XMP namespace is not re-entrant. Thanks to Adobe to code like this.

Solution is simple :

Move this lines :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#66
http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#74
http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#82

To libkexviv2, at the right place :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.cpp#90
http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.cpp#99

Gilles

2009/10/29 Andreas Huggel <[hidden email]>:
>> On the other hand wouldn't such a basic issue have been reported a
>> long time ago?
>
> Maybe it was: http://bugs.kde.org/show_bug.cgi?id=166424
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

No I don't have mutiple instances, and I just updated to exiv2-0.18.2 three
weeks ago.
Before the update everything was fine (I guess).
I deinstalled everything now, reinstalled it, but still the same.

Andi

On Thursday 29 October 2009 21:45:34 Andreas Huggel wrote:

> >> registerXmpNameSpace(QString("http://ns.adobe.com/lightroom/1.0/"),
> >> QString("lr"));
> >>
> >> is this call necessary each time we use a new DMetadata object??
> >> I would expect to call this once at application startup?
> >>
> >> I would suspect a thread-safety issue with registering namespaces.
>
> Once at application startup is enough. That call needs to be
> serialized: http://dev.exiv2.org/wiki/exiv2/Thread_safety
>
> On the other hand wouldn't such a basic issue have been reported a
> long time ago?
>
> Andi,
> can you double-check if you have multiple versions of Exiv2 on your
> computer? The weirdest problems have been caused in cases where
> different versions were used by digiKam and libkexiv2.
>
> Andreas
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Thursday 29 October 2009 09:09:21 Andi Clemens wrote:
> I don't use exiv2 from SVN either, I use 0.18.2.
> Also, when not using the suppressions file from /projects folder, I get
>  tons of errors about exiv2.

Of course I'm talking about valgrind here...

>
> Andi
>
> On Thursday 29 October 2009 08:05:31 Gilles Caulier wrote:
> > 2009/10/28 Andi Clemens <[hidden email]>:
> > > I have random crashes caused by exiv2, usually on startup or after
> > > clicking around in digiKam after some time.
> > >
> > > [........ ONLY RELEVANT PARTS SHOWN]
> > >
> > > Thread 4 (Thread 0xa0019b70 (LWP 6776)):
> > > [KCrash Handler]
> > > #6  0xb46a8df1 in Exiv2::XmpProperties::registerNs(std::string const&,
> > > std::string const&) () from /usr/lib/libexiv2.so.5
> > > #7  0xb6f6c75e in KExiv2Iface::KExiv2::registerXmpNameSpace
> > > (this=0xa0018604, uri=..., prefix=...) at
> > > /home/andi/Programmieren/KDE/digiKam/libs_KDE4/libs/libkexiv2/libkexiv2
> > >/k exiv2xmp.cpp:782 #8  0xb680b296 in DMetadata (this=0xa0018604) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dmetadat
> > >a/ dmetadata.cpp:66 #9  0xb67cab6d in
> > > Digikam::DImgLoader::checkExifWorkingColorSpace (this=0xa0018ca8) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loa
> > >de rs/dimgloader.cpp:206 #10 0xb67cfe7b in Digikam::JPEGLoader::load
> > > (this=0xa0018ca8, filePath=..., observer=0xb052730) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/loa
> > >de rs/jpegloader.cpp:513 #11 0xb67b33c3 in Digikam::DImg::load
> > > (this=0xa00191f8, filePath=..., loadFlagsInt=31, observer=0xb052730,
> > > rawDecodingSettings=...)
> > >    at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dim
> > >g. cpp:376 #12 0xb67b2ee7 in Digikam::DImg::load (this=0xa00191f8,
> > > filePath=..., observer=0xb052730, rawDecodingSettings=...) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dim
> > >g. cpp:337 #13 0xb67b1df0 in DImg (this=0xa00191f8, filePath=...,
> > > observer=0xb052730, rawDecodingSettings=...) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/dimg/dim
> > >g. cpp:100 #14 0xb68adcbd in Digikam::SharedLoadingTask::execute
> > > (this=0xb052728) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadim
> > >ag eio/loadsavetask.cpp:180 #15 0xb689fd5c in
> > > Digikam::LoadSaveThread::run (this=0x9b5acf0) at
> > > /home/andi/Programmieren/KDE/digiKam/digikam_KDE4/digikam/libs/threadim
> > >ag eio/loadsavethread.cpp:135 #16 0xb4ce3922 in ?? () from
> > > /usr/lib/libQtCore.so.4
> > > #17 0xb4c5f65c in start_thread () from /lib/libpthread.so.0
> > > #18 0xb4aaa1fe in clone () from /lib/libc.so.6
> > >
> > > [........ ONLY RELEVANT PARTS SHOWN]
> > >
> > >
> > > Can you confirm this?
> >
> > No. but with my new computer, i don't use yet Exiv2 from trunk
> >
> > I will take a look.
> >
> > Note : in your backtrace, crash appear in XMP sdk section to register
> > new namespace, as for LightRoom. I cannot see why it will crash here.
> > Perhaps it's due to recent update of xmp sdk  from Adobe in Exiv2...
> >
> > Gilles
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Andi,

Do you see my message here ? and changes to performs...

I'm pretty sure that XMP namespace registration is not thread safe.

Also, has Marcel said, no need to registered LR namesapce for each
instance of KExif2/DMetadata. As it's fully relevant of Adobe WMP sdk
(which sometime is badly implemented for me), registering LR at
application startup is enough

Look my lxr link foe details...

Gilles

2009/10/29 Gilles Caulier <[hidden email]>:

> ah yes, now, i rememeber the story.
>
> registered XMP namespace is not re-entrant. Thanks to Adobe to code like this.
>
> Solution is simple :
>
> Move this lines :
>
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#66
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#74
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#82
>
> To libkexviv2, at the right place :
>
> http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.cpp#90
> http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.cpp#99
>
> Gilles
>
> 2009/10/29 Andreas Huggel <[hidden email]>:
>>> On the other hand wouldn't such a basic issue have been reported a
>>> long time ago?
>>
>> Maybe it was: http://bugs.kde.org/show_bug.cgi?id=166424
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I will take a look at it later.
The problem with this bug is that it is very random, sometimes it doesn't
occur for hour, then again it crashes on every startup or click.

Andi

On Thursday 05 November 2009 12:33:35 Gilles Caulier wrote:

> Andi,
>
> Do you see my message here ? and changes to performs...
>
> I'm pretty sure that XMP namespace registration is not thread safe.
>
> Also, has Marcel said, no need to registered LR namesapce for each
> instance of KExif2/DMetadata. As it's fully relevant of Adobe WMP sdk
> (which sometime is badly implemented for me), registering LR at
> application startup is enough
>
> Look my lxr link foe details...
>
> Gilles
>
> 2009/10/29 Gilles Caulier <[hidden email]>:
> > ah yes, now, i rememeber the story.
> >
> > registered XMP namespace is not re-entrant. Thanks to Adobe to code like
> > this.
> >
> > Solution is simple :
> >
> > Move this lines :
> >
> > http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmeta
> >data.cpp#66
> > http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmeta
> >data.cpp#74
> > http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmeta
> >data.cpp#82
> >
> > To libkexviv2, at the right place :
> >
> > http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2
> >.cpp#90
> > http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2
> >.cpp#99
> >
> > Gilles
> >
> > 2009/10/29 Andreas Huggel <[hidden email]>:
> >>> On the other hand wouldn't such a basic issue have been reported a
> >>> long time ago?
> >>
> >> Maybe it was: http://bugs.kde.org/show_bug.cgi?id=166424
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> registered XMP namespace is not re-entrant. Thanks to Adobe to code like
>  this.
>
> Solution is simple :
>
> Move this lines :
>
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetada
> ta.cpp#66
>  http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetad
> ata.cpp#74
>  http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetad
> ata.cpp#82
>
> To libkexviv2, at the right place :
>
> http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.c
> pp#90
>  http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.
> cpp#99

Done for trunk.
People will continue to use digikam 1.0 with an older libkexiv2 version
(without initiliaziation of the namespace)
Which bug happens if this namespace registration is removed?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel