[PATCH] Navigation and actions dock bar

Hi,

This is my first patch for Digikam. It adds a dock bar with navigation and
actions buttons in the bottom of the screen.

More than thousand words, here are 2 screenshots :

In Preview mode :
http://img291.imageshack.us/img291/4258/digikampreview.png

In Album mode :
http://img293.imageshack.us/img293/5451/digikamalbum.png

I made this patch to replace the status bar because I find the navigation
buttons are not enough visibles.
But for the moment my patch doesn't hide it.

I hope you could give me feedbacks to tell me what's good and what's not :-)

Thanks.
Luc.

PS : Have you ever thought about subscribe to reviewboard.kde.org ? I think
it's a good tool to exchange about a patch.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Sorry, the files navigationbar.cpp and navigationbar.h were not included in the
patch.
I attached them...

Le lundi 02 août 2010 23:01:24 Luc Vieillescazes, vous avez écrit :

> Hi,
>
> This is my first patch for Digikam. It adds a dock bar with navigation and
> actions buttons in the bottom of the screen.
>
> More than thousand words, here are 2 screenshots :
>
> In Preview mode :
> http://img291.imageshack.us/img291/4258/digikampreview.png
>
> In Album mode :
> http://img293.imageshack.us/img293/5451/digikamalbum.png
>
> I made this patch to replace the status bar because I find the navigation
> buttons are not enough visibles.
> But for the moment my patch doesn't hide it.
>
> I hope you could give me feedbacks to tell me what's good and what's not
> :-)
>
> Thanks.
> Luc.
>
> PS : Have you ever thought about subscribe to reviewboard.kde.org ? I think
> it's a good tool to exchange about a patch.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Klapetek]

Hi,

Although I agree that the original controls are kinda hidden down there, I have a few remarks to your patch.

1) The controls are too big. They're taking too much real estate. Think about users with small screens. They don't have much space and these controls have plenty of wasted space around them. The status bar is just better suited for this. Maybe you could try to improve that one? Or the buttons there?

2) It copies most of the functionality already available elsewhere. For example the preview - every control you have there is already there, except of the delete button and the Back to album button (which is good idea btw). Therefore you either need to get rid of the top toolbar completely and replace it with your controls (the same goes with the status bar), or throw out the duplicate controls. But then you would be left with just two or free buttons, which would render it useless.

Anyway, you have nice coding style, very clean, elegant and digikam-ish :)

To lead devels/admins: Oh please go for reviewboard.kde.org - this tool is really neat ;)

Marty

On Mon, Aug 2, 2010 at 23:14, Luc Vieillescazes <[hidden email]> wrote:

Sorry, the files navigationbar.cpp and navigationbar.h were not included in the
patch.
I attached them...

Le lundi 02 août 2010 23:01:24 Luc Vieillescazes, vous avez écrit :

> Hi,
>
> This is my first patch for Digikam. It adds a dock bar with navigation and
> actions buttons in the bottom of the screen.
>
> More than thousand words, here are 2 screenshots :
>
> In Preview mode :
> http://img291.imageshack.us/img291/4258/digikampreview.png
>
> In Album mode :
> http://img293.imageshack.us/img293/5451/digikamalbum.png
>
> I made this patch to replace the status bar because I find the navigation
> buttons are not enough visibles.
> But for the moment my patch doesn't hide it.
>
> I hope you could give me feedbacks to tell me what's good and what's not
> :-)
>
> Thanks.
> Luc.
>
> PS : Have you ever thought about subscribe to reviewboard.kde.org ? I think
> it's a good tool to exchange about a patch.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gabriel Voicu]

Hi,

1) The controls are too big. They're taking too much real estate. Think about users with small screens. They don't have much space and these controls have plenty of wasted space around them. The status bar is just better suited for this. Maybe you could try to improve that one? Or the buttons there?

Maybe a control setting would let the user choose between displaying all these control on status bar/toolbar or bottom of screen?

I also agree with the fact that something could be done to centre the movement controls.

Gabriel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

On 08/03/2010 09:44 AM, Martin Klapetek wrote:
> To lead devels/admins: Oh please go for reviewboard.kde.org - this tool is
> really neat ;)

Yes, good idea! I made a request on bugs.kde.org about it (but those
requests are private, therefore no link).

Michael
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hi !

Thanks for your feedbacks.

I made a new version which use less space.
Screenshots :
http://img225.imageshack.us/img225/130/digikamalbum1.png
http://img805.imageshack.us/img805/7448/digikampreview1.png

For the second point :
Yes I didn't add any features, but my goal is to centalize the most used
functionnalities in this central area and to remove (or hide) them from status
bar and tool bar where they have less visibility.
But before that, I wanted to have opinions from digikam developpers :-)

Luc.


Le mardi 03 août 2010 10:36:03 Gabriel Voicu, vous avez écrit :

> Hi,
>
> > 1) The controls are too big. They're taking too much real estate. Think
> > about users with small screens. They don't have much space and these
> > controls have plenty of wasted space around them. The status bar is just
> > better suited for this. Maybe you could try to improve that one? Or the
> > buttons there?
>
> Maybe a control setting would let the user choose between displaying all
> these control on status bar/toolbar or bottom of screen?
>
> I also agree with the fact that something could be done to centre the
> movement controls.
>
> Gabriel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I made a new version which use less space.
> Screenshots :
> http://img225.imageshack.us/img225/130/digikamalbum1.png
> http://img805.imageshack.us/img805/7448/digikampreview1.png
>
> For the second point :
> Yes I didn't add any features, but my goal is to centalize the most used
> functionnalities in this central area and to remove (or hide) them from
> status bar and tool bar where they have less visibility.
> But before that, I wanted to have opinions from digikam developpers :-)

This version is much better, really.
Especially in the preview mode.
We wait for Gilles' comments.

- do we need the rotation buttons and the slideshow button?
- do we need it in the icon view?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2010/8/13 Marcel Wiesweg <[hidden email]>:

>
>> I made a new version which use less space.
>> Screenshots :
>> http://img225.imageshack.us/img225/130/digikamalbum1.png
>> http://img805.imageshack.us/img805/7448/digikampreview1.png
>>
>> For the second point :
>> Yes I didn't add any features, but my goal is to centalize the most used
>> functionnalities in this central area and to remove (or hide) them from
>> status bar and tool bar where they have less visibility.
>> But before that, I wanted to have opinions from digikam developpers :-)
>
> This version is much better, really.
> Especially in the preview mode.
> We wait for Gilles' comments.
>
> - do we need the rotation buttons and the slideshow button?
> - do we need it in the icon view?

I thinking from a while something like this navigation bar.

The question about which action to host in this bar can be solved
easily to set this bar are customizable, as toolbar.

The real question is which default action to set as well...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Yes this version is much better than the first one.
As long as this toolbar is customizable, I think it is a good idea and we
would finally get rid of the icons painted above the image in preview mode :-)

Andi Clemens
-----------------
www.digikam.org

On Friday 13 August 2010 11:29:46 Marcel Wiesweg wrote:

> > I made a new version which use less space.
> > Screenshots :
> > http://img225.imageshack.us/img225/130/digikamalbum1.png
> > http://img805.imageshack.us/img805/7448/digikampreview1.png
> >
> > For the second point :
> > Yes I didn't add any features, but my goal is to centalize the most used
> > functionnalities in this central area and to remove (or hide) them from
> > status bar and tool bar where they have less visibility.
> > But before that, I wanted to have opinions from digikam developpers :-)
>
> This version is much better, really.
> Especially in the preview mode.
> We wait for Gilles' comments.
>
> - do we need the rotation buttons and the slideshow button?
> - do we need it in the icon view?
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Aditya Bhatt]

On Sun, Aug 15, 2010 at 2:53 AM, Andi Clemens <[hidden email]> wrote:

Yes this version is much better than the first one.
As long as this toolbar is customizable, I think it is a good idea and we
would finally get rid of the icons painted above the image in preview mode :-)

Yeah!

But might I suggest using cheesier icons for the nav controls + all buttons in the thumbbar row : http://z.about.com/d/graphicssoft/1/0/f/1/5/Picasa-SS.png

This saves a lot of vertical space. And looks good too.

Aditya

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Aditya Bhatt]

Or probably keep it the way it is in the patch, but make the thumbbar extend all the way. Not sure how this would affect our sidebars.

http://www.stephenschleicher.com/images/2007/01/lightroom_screen.jpg

Aditya

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hi,

I looked at picasa, and saw that the navigation buttons
(first/previous/next/last) are only visible in preview mode, each side of the
thumbnails bar.
I think it's a good idea because thumbnails and navigation buttons are not
necessary in album mode.

For the most important features in the dock bar, I think we need :
- rotate left/right
- delete
- view image / back to album
- Filters & zoom
- slideshow (maybe ?)

If you see something else or if you have ideas to make it customizable....
please tell me :-)
I will be in holidays one more week. Just after I will try to improve the
proposal

Luc.


Le samedi 14 août 2010 23:35:25, Aditya Bhatt a écrit :
> Or probably keep it the way it is in the patch, but make the thumbbar
> extend all the way. Not sure how this would affect our sidebars.
>
> http://www.stephenschleicher.com/images/2007/01/lightroom_screen.jpg
>
> Aditya
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hi,

I made a new version some days ago (http://reviewboard.kde.org/r/4905/).
The changes are :
- Thumbnails bar now uses all the width in Preview mode (suggested by Aditya Bhatt)
- The filter bar is only visible in Album mode, and navigation buttons only in Preview mode.
- Correct a bug in digikam when switching form Preview mode to Album mode, the zoombar was not refresh.
- Rework a bit the layout / add tooltip

I hope you can give me some feedbacks :-)

Thanks.
Luc

2010/8/15 Luc Vieillescazes <[hidden email]>

Hi,

I looked at picasa, and saw that the navigation buttons
(first/previous/next/last) are only visible in preview mode, each side of the
thumbnails bar.
I think it's a good idea because thumbnails and navigation buttons are not
necessary in album mode.

For the most important features in the dock bar, I think we need :
- rotate left/right
- delete
- view image / back to album
- Filters & zoom
- slideshow (maybe ?)

If you see something else or if you have ideas to make it customizable....
please tell me :-)
I will be in holidays one more week. Just after I will try to improve the
proposal

Luc.


Le samedi 14 août 2010 23:35:25, Aditya Bhatt a écrit :

> Or probably keep it the way it is in the patch, but make the thumbbar
> extend all the way. Not sure how this would affect our sidebars.
>
> http://www.stephenschleicher.com/images/2007/01/lightroom_screen.jpg
>
> Aditya

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Hi,
>
> I made a new version some days ago (http://reviewboard.kde.org/r/4905/).
> The changes are :
> - Thumbnails bar now uses all the width in Preview mode (suggested by
> Aditya Bhatt)

Does that mean the sidebar are shrunk vertically when going to preview mode?

> - The filter bar is only visible in Album mode,

There is some usefulness of the filters in any mode...

> and navigation buttons only
> in Preview mode.
> - Correct a bug in digikam when switching form Preview mode to Album mode,
> the zoombar was not refresh.
> - Rework a bit the layout / add tooltip
>
> I hope you can give me some feedbacks :-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

2010/8/31 Marcel Wiesweg <[hidden email]>

> Hi,
>
> I made a new version some days ago (http://reviewboard.kde.org/r/4905/).
> The changes are :
> - Thumbnails bar now uses all the width in Preview mode (suggested by
> Aditya Bhatt)

Does that mean the sidebar are shrunk vertically when going to preview mode?

Yes, you can see screenshots on http://reviewboard.kde.org/r/4905/, one in album mode, one in preview mode
 

> - The filter bar is only visible in Album mode,

There is some usefulness of the filters in any mode...

From my point of view, when normal users are looking for something, they want to see all the results (so in album mode) and not only the first like in preview mode.

But for "power" users, maybe we could add an "advanced button" (like the search bar in Kate) to show/hide the filters ?
 

> and navigation buttons only
> in Preview mode.
> - Correct a bug in digikam when switching form Preview mode to Album mode,
> the zoombar was not refresh.
> - Rework a bit the layout / add tooltip
>
> I hope you can give me some feedbacks :-)

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

First, i don't like review board tool. It break QA done with bugzilla.
All workflow is broken as we cannot link bugzilla to review board.

There is no advantage to use review board instead bugzilla.

Sorry for this wrong feedback, but it's already difficult to manage
the whole bugzilla entries. We don't need another tool again in the
pending list.

Luc,

this is not against your work. Your patch is really appreciate, and
it's now the time to review it indeep before inclusion to trunk

Andi,

do you have tested the last version of patch on your computer ?

Gilles

2010/9/1 Luc Vieillescazes <[hidden email]>:

> 2010/8/31 Marcel Wiesweg <[hidden email]>
>>
>> > Hi,
>> >
>> > I made a new version some days ago (http://reviewboard.kde.org/r/4905/).
>> > The changes are :
>> > - Thumbnails bar now uses all the width in Preview mode (suggested by
>> > Aditya Bhatt)
>>
>> Does that mean the sidebar are shrunk vertically when going to preview
>> mode?
>
> Yes, you can see screenshots on http://reviewboard.kde.org/r/4905/, one in
> album mode, one in preview mode
>
>>
>> > - The filter bar is only visible in Album mode,
>>
>> There is some usefulness of the filters in any mode...
>
> From my point of view, when normal users are looking for something, they
> want to see all the results (so in album mode) and not only the first like
> in preview mode.
>
> But for "power" users, maybe we could add an "advanced button" (like the
> search bar in Kate) to show/hide the filters ?
>
>>
>> > and navigation buttons only
>> > in Preview mode.
>> > - Correct a bug in digikam when switching form Preview mode to Album
>> > mode,
>> > the zoombar was not refresh.
>> > - Rework a bit the layout / add tooltip
>> >
>> > I hope you can give me some feedbacks :-)
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2010/9/26 Gilles Caulier <[hidden email]>:
> First, i don't like review board tool. It break QA done with bugzilla.
> All workflow is broken as we cannot link bugzilla to review board.
>
> There is no advantage to use review board instead bugzilla.
>

Luc,

I know that you have open a file in bugzilla about this subject.

I cannot find it in my mail archive. Can you point me on it please.

Also, ask to all to continue this thread on this bugzilla entry
instead the mailing list.

Thanks in advance

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

No not yet, I will test it now.

Andi Clemens
-----------------
www.digikam.org

On Sunday 26 September 2010 14:20:05 Gilles Caulier wrote:

> First, i don't like review board tool. It break QA done with bugzilla.
> All workflow is broken as we cannot link bugzilla to review board.
>
> There is no advantage to use review board instead bugzilla.
>
> Sorry for this wrong feedback, but it's already difficult to manage
> the whole bugzilla entries. We don't need another tool again in the
> pending list.
>
> Luc,
>
> this is not against your work. Your patch is really appreciate, and
> it's now the time to review it indeep before inclusion to trunk
>
> Andi,
>
> do you have tested the last version of patch on your computer ?
>
> Gilles
>
> 2010/9/1 Luc Vieillescazes <[hidden email]>:
> > 2010/8/31 Marcel Wiesweg <[hidden email]>
> >
> >> > Hi,
> >> >
> >> > I made a new version some days ago
> >> > (http://reviewboard.kde.org/r/4905/). The changes are :
> >> > - Thumbnails bar now uses all the width in Preview mode (suggested by
> >> > Aditya Bhatt)
> >>
> >> Does that mean the sidebar are shrunk vertically when going to preview
> >> mode?
> >
> > Yes, you can see screenshots on http://reviewboard.kde.org/r/4905/, one
> > in album mode, one in preview mode
> >
> >> > - The filter bar is only visible in Album mode,
> >>
> >> There is some usefulness of the filters in any mode...
> >
> > From my point of view, when normal users are looking for something, they
> > want to see all the results (so in album mode) and not only the first
> > like in preview mode.
> >
> > But for "power" users, maybe we could add an "advanced button" (like the
> > search bar in Kate) to show/hide the filters ?
> >
> >> > and navigation buttons only
> >> > in Preview mode.
> >> > - Correct a bug in digikam when switching form Preview mode to Album
> >> > mode,
> >> > the zoombar was not refresh.
> >> > - Rework a bit the layout / add tooltip
> >> >
> >> > I hope you can give me some feedbacks :-)
> >>
> >> _______________________________________________
> >> Digikam-devel mailing list
> >> [hidden email]
> >> https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I've applied the patch and it works quite well, but there are some things I
don't really like so far:

- The thumbbar spreads across the while digiKam window now, which shrinks the
left and right sidebars vertically when switching from album to preview mode.
This looks very hectic, the whole screen is moving around :D
Another side-effect of this: The thumbbar will be attached on the left- and
rightmost edges of the digikam window now. Before the patch the left and right
sidebar were the left- and rightmost widgets.

- The status-bar still contains all the widgets that the new dockbar has, too.
The patch should also fix this problem.

But in general, this patch seems to be ok.

Andi Clemens
-----------------
www.digikam.org

On Sunday 26 September 2010 14:31:12 Andi Clemens wrote:

> No not yet, I will test it now.
>
> Andi Clemens
> -----------------
> www.digikam.org
>
> On Sunday 26 September 2010 14:20:05 Gilles Caulier wrote:
> > First, i don't like review board tool. It break QA done with bugzilla.
> > All workflow is broken as we cannot link bugzilla to review board.
> >
> > There is no advantage to use review board instead bugzilla.
> >
> > Sorry for this wrong feedback, but it's already difficult to manage
> > the whole bugzilla entries. We don't need another tool again in the
> > pending list.
> >
> > Luc,
> >
> > this is not against your work. Your patch is really appreciate, and
> > it's now the time to review it indeep before inclusion to trunk
> >
> > Andi,
> >
> > do you have tested the last version of patch on your computer ?
> >
> > Gilles
> >
> > 2010/9/1 Luc Vieillescazes <[hidden email]>:
> > > 2010/8/31 Marcel Wiesweg <[hidden email]>
> > >
> > >> > Hi,
> > >> >
> > >> > I made a new version some days ago
> > >> > (http://reviewboard.kde.org/r/4905/). The changes are :
> > >> > - Thumbnails bar now uses all the width in Preview mode (suggested
> > >> > by Aditya Bhatt)
> > >>
> > >> Does that mean the sidebar are shrunk vertically when going to preview
> > >> mode?
> > >
> > > Yes, you can see screenshots on http://reviewboard.kde.org/r/4905/, one
> > > in album mode, one in preview mode
> > >
> > >> > - The filter bar is only visible in Album mode,
> > >>
> > >> There is some usefulness of the filters in any mode...
> > >
> > > From my point of view, when normal users are looking for something,
> > > they want to see all the results (so in album mode) and not only the
> > > first like in preview mode.
> > >
> > > But for "power" users, maybe we could add an "advanced button" (like
> > > the search bar in Kate) to show/hide the filters ?
> > >
> > >> > and navigation buttons only
> > >> > in Preview mode.
> > >> > - Correct a bug in digikam when switching form Preview mode to Album
> > >> > mode,
> > >> > the zoombar was not refresh.
> > >> > - Rework a bit the layout / add tooltip
> > >> >
> > >> > I hope you can give me some feedbacks :-)
> > >>
> > >> _______________________________________________
> > >> Digikam-devel mailing list
> > >> [hidden email]
> > >> https://mail.kde.org/mailman/listinfo/digikam-devel
> > >
> > > _______________________________________________
> > > Digikam-devel mailing list
> > > [hidden email]
> > > https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hi Gilles,

I did not find a bug report in bugzilla, so I opened a new one.

https://bugs.kde.org/show_bug.cgi?id=252671

Luc.


Le dimanche 26 septembre 2010 14:23:33 Gilles Caulier, vous avez écrit :

> 2010/9/26 Gilles Caulier <[hidden email]>:
> > First, i don't like review board tool. It break QA done with bugzilla.
> > All workflow is broken as we cannot link bugzilla to review board.
> >
> > There is no advantage to use review board instead bugzilla.
>
> Luc,
>
> I know that you have open a file in bugzilla about this subject.
>
> I cannot find it in my mail archive. Can you point me on it please.
>
> Also, ask to all to continue this thread on this bugzilla entry
> instead the mailing list.
>
> Thanks in advance
>
> Gilles Caulier
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel