New lighttable behavior

Hi all,

I have rewritten the lighttable a little bit, its behavior is somehow
strange and it also has a annoying bug:
https://bugs.kde.org/show_bug.cgi?id=160617

To fix this problem, I have changed the way images are added a little bit.
The patch can be found here:
http://digikam3rdparty.free.fr/misc.tarballs/temp/lighttable.patch

First of all, lets describe the current behavior.

WITHOUT PATCH:
1. drop image(s) in left pane:
the image will be displayed in the left pane

2. drop image(s) in right pane:
the image will be displayed in the left AND right pane

3. fill light table (F6):
the first image of the added images will be displayed in the left, the
second in the right pane. All the others are added to the thumbbar, of
course.

4. append images to light table (CTRL+F6):
the first image of the added images will be displayed in the left, the
second in the right pane. All the others are added to the thumbbar, of
course.
This behavior is strange I think, appended images should only go into
the thumbbar, not be displayed automatically

5. drop images in thumbbar:
the first image of the added images will be displayed in the left, the
second in the right pane. All the others are added to the thumbbar, of
course.
Again this behavior is strange, see #4 above.

WITH PATCH:
1. drop image(s) in left pane:
the image will be displayed in the left pane

2. drop image(s) in right pane:
the image will be displayed in the right pane

3. fill light table (F6):
the first image of the added images will be displayed in the left, the
second in the right pane. All the others are added to the thumbbar, of
course.

4. append images to light table (CTRL+F6):
Images are only appended to thumbbar, not displayed automatically.

5. drop images in thumbbar:
Images are only appended to thumbbar, not displayed automatically.


What do you think? It really works better now than before and the behavior
is much more logical.

To all of the "lighttable power users": Please test the new behavior and
compare it with the old one. What do you think?
If it is fine for you, we should be able to put this into the final 0.9.4
release.

I will provide a test tarball for 0.9.4-rc2 today, but without this patch.
First of all I want to know if the new behavior is ok with you all.

Andi


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/7/3 Andi Clemens <[hidden email]>:

> Hi all,
>
> I have rewritten the lighttable a little bit, its behavior is somehow
> strange and it also has a annoying bug:
> https://bugs.kde.org/show_bug.cgi?id=160617
>
> To fix this problem, I have changed the way images are added a little bit.
> The patch can be found here:
> http://digikam3rdparty.free.fr/misc.tarballs/temp/lighttable.patch
>
> First of all, lets describe the current behavior.
>
> WITHOUT PATCH:
> 1. drop image(s) in left pane:
> the image will be displayed in the left pane
>
> 2. drop image(s) in right pane:
> the image will be displayed in the left AND right pane
>
> 3. fill light table (F6):
> the first image of the added images will be displayed in the left, the
> second in the right pane. All the others are added to the thumbbar, of
> course.
>
> 4. append images to light table (CTRL+F6):
> the first image of the added images will be displayed in the left, the
> second in the right pane. All the others are added to the thumbbar, of
> course.
> This behavior is strange I think, appended images should only go into
> the thumbbar, not be displayed automatically
>
> 5. drop images in thumbbar:
> the first image of the added images will be displayed in the left, the
> second in the right pane. All the others are added to the thumbbar, of
> course.
> Again this behavior is strange, see #4 above.
>
> WITH PATCH:
> 1. drop image(s) in left pane:
> the image will be displayed in the left pane
>
> 2. drop image(s) in right pane:
> the image will be displayed in the right pane
>
> 3. fill light table (F6):
> the first image of the added images will be displayed in the left, the
> second in the right pane. All the others are added to the thumbbar, of
> course.
>
> 4. append images to light table (CTRL+F6):
> Images are only appended to thumbbar, not displayed automatically.
>
> 5. drop images in thumbbar:
> Images are only appended to thumbbar, not displayed automatically.
>
>
> What do you think? It really works better now than before and the behavior
> is much more logical.
>
> To all of the "lighttable power users": Please test the new behavior and
> compare it with the old one. What do you think?
> If it is fine for you, we should be able to put this into the final 0.9.4
> release.
>
> I will provide a test tarball for 0.9.4-rc2 today, but without this patch.
> First of all I want to know if the new behavior is ok with you all.
>
> Andi
>

Like i have already said to Andi in private, i'm agree with the new behaviour.

I would to have Fabien and Arnd viewpoint here especially, like they
have work on LT improvements in the pass.

Best

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Hi,

Gilles Caulier wrote:
> 2008/7/3 Andi Clemens <[hidden email]>:
>> I have rewritten the lighttable a little bit, its behavior is somehow
>> strange and it also has a annoying bug:
>> https://bugs.kde.org/show_bug.cgi?id=160617

Yes, I remember. It was a remaining bug (or feature ;-) ) after a bug
fixed (see http://bugs.kde.org/show_bug.cgi?id=150296)

>> To fix this problem, I have changed the way images are added a little bit.
>> The patch can be found here:
>> http://digikam3rdparty.free.fr/misc.tarballs/temp/lighttable.patch
>> First of all, lets describe the current behavior.
>>
>> WITHOUT PATCH:
>> 1. drop image(s) in left pane:
>> the image will be displayed in the left pane
>>
>> 2. drop image(s) in right pane:
>> the image will be displayed in the left AND right pane
>>
>> 3. fill light table (F6):
>> the first image of the added images will be displayed in the left, the
>> second in the right pane. All the others are added to the thumbbar, of
>> course.
>>
>> 4. append images to light table (CTRL+F6):
>> the first image of the added images will be displayed in the left, the
>> second in the right pane. All the others are added to the thumbbar, of
>> course.
>> This behavior is strange I think, appended images should only go into
>> the thumbbar, not be displayed automatically
>>
>> 5. drop images in thumbbar:
>> the first image of the added images will be displayed in the left, the
>> second in the right pane. All the others are added to the thumbbar, of
>> course.
>> Again this behavior is strange, see #4 above.
>>
>> WITH PATCH:
>> 1. drop image(s) in left pane:
>> the image will be displayed in the left pane
>>
>> 2. drop image(s) in right pane:
>> the image will be displayed in the right pane
>>
>> 3. fill light table (F6):
>> the first image of the added images will be displayed in the left, the
>> second in the right pane. All the others are added to the thumbbar, of
>> course.
>>
>> 4. append images to light table (CTRL+F6):
>> Images are only appended to thumbbar, not displayed automatically.
>>
>> 5. drop images in thumbbar:
>> Images are only appended to thumbbar, not displayed automatically.
>>
>>
>> What do you think? It really works better now than before and the behavior
>> is much more logical.

This behavior looks good for me.

>> To all of the "lighttable power users": Please test the new behavior and
>> compare it with the old one. What do you think?
>> If it is fine for you, we should be able to put this into the final 0.9.4
>> release.

I gave it a try with the patch and it works fine.
Thanks.


BTW, it would be nice to add "Place onto Light Table" also in the
right-click menu. Right now, there's "Add..." but not "Place...".

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

On Thu, 3 Jul 2008, Gilles Caulier wrote:

> 2008/7/3 Andi Clemens <[hidden email]>:

[ ... ]

> > What do you think? It really works better now than before and the behavior
> > is much more logical.

Yep!

> > To all of the "lighttable power users": Please test the new behavior and
> > compare it with the old one. What do you think?
> > If it is fine for you, we should be able to put this into the final 0.9.4
> > release.
> >
> > I will provide a test tarball for 0.9.4-rc2 today, but without this patch.
> > First of all I want to know if the new behavior is ok with you all.
> >
> > Andi
> >
>
> Like i have already said to Andi in private, i'm agree with the new behaviour.
>
> I would to have Fabien and Arnd viewpoint here especially, like they
> have work on LT improvements in the pass.

Sounds good to me - (can't test it at the moment),
just go ahead ... ;-)

Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I need to review some things, but if you are satisfied I will commit it to
SVN on sunday I guess, right after rc2 tarball is put on SF.net.

Andi

Arnd Baecker wrote:

> On Thu, 3 Jul 2008, Gilles Caulier wrote:
>
>> 2008/7/3 Andi Clemens <[hidden email]>:
>
> [ ... ]
>
>> > What do you think? It really works better now than before and the
>> > behavior is much more logical.
>
> Yep!
>
>> > To all of the "lighttable power users": Please test the new behavior
>> > and compare it with the old one. What do you think?
>> > If it is fine for you, we should be able to put this into the final
>> > 0.9.4 release.
>> >
>> > I will provide a test tarball for 0.9.4-rc2 today, but without this
>> > patch. First of all I want to know if the new behavior is ok with you
>> > all.
>> >
>> > Andi
>> >
>>
>> Like i have already said to Andi in private, i'm agree with the new
>> behaviour.
>>
>> I would to have Fabien and Arnd viewpoint here especially, like they
>> have work on LT improvements in the pass.
>
> Sounds good to me - (can't test it at the moment),
> just go ahead ... ;-)
>
> Arnd

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/7/3 Andi Clemens <[hidden email]>:
> I need to review some things, but if you are satisfied I will commit it to
> SVN on sunday I guess, right after rc2 tarball is put on SF.net.

We don't care about RC2 (:=)))... with svn, you can play with a
specific revision to extract code, copy, branch, etc. You can commit
your patch when you want, since RC2 svn rev exist in repository

Note : Here, i have another patch to use external sqlite3 depency
(default = use include version) for packagers, to close definitivly
this file:

http://bugs.kde.org/show_bug.cgi?id=160966

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel