New image editor noise reduction plugin...

[Gilles Caulier-2]

Hi all,

I have recently backported the new despeckle algorithm from gimp 2.2.x to
digiKam like noise reduction tool with support of 16 bits images.

After to have played with it, i have been unsatisfied... The result are a
little bit strange, especially with recursive option.

After to have serching on the web the best NR technics, my conclusion is that
this algorithm is a wrong way. despeckle use RGB color space to fix noise and
this is a wrong issue.

After to any investigation, i have found a great GPL plugin tool named
dcamnoise2. The code is really impressive and very well documented...

I have backported the code this week end, and the result look great :

http://digikam3rdparty.free.fr/Screenshots/new_noisereduction_plugin.png

The only one NR tool that i have already used witch provide a similar result
is Noise Nija plugin for photoshop... If you want to test it, there is a diff
file against current NR tool implementation from svn trunk here :

http://digikam3rdparty.free.fr/misc.tarballs/nr.diff

To test it, just go to digikamimageplugins/noisereduction directory, and apply
it like this:

# diff -p0 < nr.diff

make, and install the plugin. You can play with it in digikam. There are some
noisy images to use here :

http://digikam3rdparty.free.fr/Images_2_Test_DImg/NOISE/

To use it, especially with parameters, I recommend you to read the comments of
the algorithm author from the original gimp plugin source code here :

http://digikam3rdparty.free.fr/misc.tarballs/dcamnoise2-0.63.c

Nota :

- The most important settings are in General tab.
- The plugin do not support yet 16 bits images. It's just a question of time.
I will do it later, if the fedback is right from digiKam users.

Please, let's me hear your viewpoints. Thanks in advance...

Gilles Caulier
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

Le Mardi 14 Mars 2006 12:03 AM, Caulier Gilles a écrit :

> Hi all,
>
> I have recently backported the new despeckle algorithm from gimp 2.2.x to
> digiKam like noise reduction tool with support of 16 bits images.
>
> After to have played with it, i have been unsatisfied... The result are a
> little bit strange, especially with recursive option.
>
> After to have serching on the web the best NR technics, my conclusion is
> that this algorithm is a wrong way. despeckle use RGB color space to fix
> noise and this is a wrong issue.
>
> After to any investigation, i have found a great GPL plugin tool named
> dcamnoise2. The code is really impressive and very well documented...
>
> I have backported the code this week end, and the result look great :
>
> http://digikam3rdparty.free.fr/Screenshots/new_noisereduction_plugin.png
>
> The only one NR tool that i have already used witch provide a similar
> result is Noise Nija plugin for photoshop... If you want to test it, there
> is a diff file against current NR tool implementation from svn trunk here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/nr.diff
>
> To test it, just go to digikamimageplugins/noisereduction directory, and
> apply it like this:
>
> # diff -p0 < nr.diff
>
> make, and install the plugin. You can play with it in digikam. There are
> some noisy images to use here :
>
> http://digikam3rdparty.free.fr/Images_2_Test_DImg/NOISE/
>
> To use it, especially with parameters, I recommend you to read the comments
> of the algorithm author from the original gimp plugin source code here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/dcamnoise2-0.63.c
>
> Nota :
>
> - The most important settings are in General tab.
> - The plugin do not support yet 16 bits images. It's just a question of
> time. I will do it later, if the fedback is right from digiKam users.
>
> Please, let's me hear your viewpoints. Thanks in advance...

Forget to said that i need some RAW file samples taken with important noise to
test 16 bits image support. You can capture these pictures to boost ISO
settings of your camera for example.

Thanks in advance

Gilles Caulier
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Markus Spring]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gilles,

this looks really promising! I will try it soon, as my Minolta 7D delivers noise
at ISO 1600 that I found hard to reduce with linux tools. Thanks again for your
work!

Cheers

Markus
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFEFlW8xxUzQSse11ARAvIMAJ42kF1elHZ1coyu6I1aHnF0FMGlSgCeLtSq
hS7DcZfFp58xEoWVCqU6g/Y=
=x7sx
-----END PGP SIGNATURE-----
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Markus Spring]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Caulier Gilles schrieb:
> Forget to said that i need some RAW file samples taken with important noise to
> test 16 bits image support. You can capture these pictures to boost ISO
> settings of your camera for example.

As you own a Minolta 5D, you probably won't need 7D raw files - the noise should
be identical. Otherwise let me know how to provide them: email or for download.

Regards - Markus
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFEFlZaxxUzQSse11ARAgr0AJkB+tyC2ZIRZ6nzUV72WF9vZKGRMwCfQwAn
SwuPNZtGQcrbY4HjiTQ6Hvc=
=rgH/
-----END PGP SIGNATURE-----
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

On Tuesday 14 March 2006 06:36 am, Markus Spring wrote:
> Caulier Gilles schrieb:
> > Forget to said that i need some RAW file samples taken with important
> > noise to test 16 bits image support. You can capture these pictures to
> > boost ISO settings of your camera for example.
>
> As you own a Minolta 5D, you probably won't need 7D raw files - the noise
> should be identical. Otherwise let me know how to provide them: email or
> for download.

No, the CCD noise reduction filter included into 5D is very optimized (more
than 7D). I'm very interressed to have some samples from 7D...

Nota : I recommend you to update the firmware of your camera, if it's always
possible since DC Minolta working groups have been moved to Sony...

Thanks in advance

Gilles
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

On Tuesday 14 March 2006 06:36 am, Markus Spring wrote:
> Caulier Gilles schrieb:
> > Forget to said that i need some RAW file samples taken with important
> > noise to test 16 bits image support. You can capture these pictures to
> > boost ISO settings of your camera for example.
>
> As you own a Minolta 5D, you probably won't need 7D raw files - the noise
> should be identical. Otherwise let me know how to provide them: email or
> for download.

Markus, using download it's always better. My e-mail space account is
limited...

Gilles
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Hi,

This looks great ! thanks Gilles

>>To test it, just go to digikamimageplugins/noisereduction directory, and
>>apply it like this:
>>
>># diff -p0 < nr.diff
>>

For those who are not used to diff/patch, in fact you need to apply it
like this:

patch -p0 < nr.diff

Julien
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Hi!

> Forget to said that i need some RAW file samples taken with important noise to
> test 16 bits image support. You can capture these pictures to boost ISO
> settings of your camera for example.
>
> Thanks in advance
>
> Gilles Caulier

I can make you a picture with a long exposure on ISO 1600 with my Canon 350D, if
you want me to.
Please let me know!

Best regards,
Gabor Dudas
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

A new version of the diff file is availalble at the same place:

http://digikam3rdparty.free.fr/misc.tarballs/nr.diff

 I have fixed some settings limit to prevent crash, especially with advanced
parameters, and fixed some uninitialized variable in memory (thanks Mr
valgrind)

Gilles


On Tuesday 14 March 2006 12:03 am, Caulier Gilles wrote:

> Hi all,
>
> I have recently backported the new despeckle algorithm from gimp 2.2.x to
> digiKam like noise reduction tool with support of 16 bits images.
>
> After to have played with it, i have been unsatisfied... The result are a
> little bit strange, especially with recursive option.
>
> After to have serching on the web the best NR technics, my conclusion is
> that this algorithm is a wrong way. despeckle use RGB color space to fix
> noise and this is a wrong issue.
>
> After to any investigation, i have found a great GPL plugin tool named
> dcamnoise2. The code is really impressive and very well documented...
>
> I have backported the code this week end, and the result look great :
>
> http://digikam3rdparty.free.fr/Screenshots/new_noisereduction_plugin.png
>
> The only one NR tool that i have already used witch provide a similar
> result is Noise Nija plugin for photoshop... If you want to test it, there
> is a diff file against current NR tool implementation from svn trunk here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/nr.diff
>
> To test it, just go to digikamimageplugins/noisereduction directory, and
> apply it like this:
>
> # diff -p0 < nr.diff
>
> make, and install the plugin. You can play with it in digikam. There are
> some noisy images to use here :
>
> http://digikam3rdparty.free.fr/Images_2_Test_DImg/NOISE/
>
> To use it, especially with parameters, I recommend you to read the comments
> of the algorithm author from the original gimp plugin source code here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/dcamnoise2-0.63.c
>
> Nota :
>
> - The most important settings are in General tab.
> - The plugin do not support yet 16 bits images. It's just a question of
> time. I will do it later, if the fedback is right from digiKam users.
>
> Please, let's me hear your viewpoints. Thanks in advance...
>
> Gilles Caulier
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

The code is in svn now. The plugin support 16 bits images !!! I have polished
the implementation and tested indeep to prevent crash and memory leak.

I have found a big problem in the original implementation from "dcamnoise2"
tool : the blured image created before to applying the NR filter is broken.
This is very difficult to see it without zooming in the target image,
especially in 8bits. To 16 bits this weird effect is very increased ! But
this is not a problem with this new tool now (:=)))...

The settings area need to be polished, and all parameters need a full
contextual descriptions.

Please let's me hear your suggestions about.

I would to thanks all digiKam users who have provides some RAW pictures with
noise to debug this plugin.

Gilles Caulier

On Tuesday 14 March 2006 12:03 am, Caulier Gilles wrote:

> Hi all,
>
> I have recently backported the new despeckle algorithm from gimp 2.2.x to
> digiKam like noise reduction tool with support of 16 bits images.
>
> After to have played with it, i have been unsatisfied... The result are a
> little bit strange, especially with recursive option.
>
> After to have serching on the web the best NR technics, my conclusion is
> that this algorithm is a wrong way. despeckle use RGB color space to fix
> noise and this is a wrong issue.
>
> After to any investigation, i have found a great GPL plugin tool named
> dcamnoise2. The code is really impressive and very well documented...
>
> I have backported the code this week end, and the result look great :
>
> http://digikam3rdparty.free.fr/Screenshots/new_noisereduction_plugin.png
>
> The only one NR tool that i have already used witch provide a similar
> result is Noise Nija plugin for photoshop... If you want to test it, there
> is a diff file against current NR tool implementation from svn trunk here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/nr.diff
>
> To test it, just go to digikamimageplugins/noisereduction directory, and
> apply it like this:
>
> # diff -p0 < nr.diff
>
> make, and install the plugin. You can play with it in digikam. There are
> some noisy images to use here :
>
> http://digikam3rdparty.free.fr/Images_2_Test_DImg/NOISE/
>
> To use it, especially with parameters, I recommend you to read the comments
> of the algorithm author from the original gimp plugin source code here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/dcamnoise2-0.63.c
>
> Nota :
>
> - The most important settings are in General tab.
> - The plugin do not support yet 16 bits images. It's just a question of
> time. I will do it later, if the fedback is right from digiKam users.
>
> Please, let's me hear your viewpoints. Thanks in advance...
>
> Gilles Caulier
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Hi,

I have a problem, and I don't what is the root cause of it.
I have compiled digikam and the related stuffs from svn (not the trunk), but
when I start digikam, it doesn't generate the small thumbnails for the pictures
in the album. But I am sure that the album is not empty!
What can cause this? What should I check?
(I have also tried to install digikam from packages, but I got the same result...)

Thanks!
Gabor
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

Le Mercredi 15 Mars 2006 17:58, Dudas Gabor a écrit :

> Hi,
>
> I have a problem, and I don't what is the root cause of it.
> I have compiled digikam and the related stuffs from svn (not the trunk),
> but when I start digikam, it doesn't generate the small thumbnails for the
> pictures in the album. But I am sure that the album is not empty!
> What can cause this? What should I check?
> (I have also tried to install digikam from packages, but I got the same
> result...)
>
> Thanks!
> Gabor

I have fixed any cast problem kioslave into trunk branch about size_t
definition. This bug have been reported to OpenBsd and fixed by a
contributor.

Please give me a report with a fresh checkout of svn.

Gilles Caulier
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Gilles Caulier wrote:

> I have fixed any cast problem kioslave into trunk branch about size_t
> definition. This bug have been reported to OpenBsd and fixed by a
> contributor.
>
> Please give me a report with a fresh checkout of svn.
>
> Gilles Caulier

It is weird. It's still not working. I have a feeling that I do something wrong,
since the code from svn (and the packages) was working many times before!. I
compiled them several times. Now it's not working. I shortly describe what I did:
- I have downloaded the source from svn. I have used the following sources:
   digikam: svn://anonsvn.kde.org/home/kde/branches/stable/extragear/graphics
   extragear libs: svn://anonsvn.kde.org/home/kde/trunk/extragear/libs
- I have installed imlib2 (1.2.1.009) and sqlite3 (3.3.4) from packages.
- I have compiled and installed extragear libs
- I have compiled and installed digikam.

Thats all. Still no thumbnails for my pics. The startup output is the following:
digikam: ScanLib: Finding non-existing Albums: 5 ms
digikam: ScanLib: Finding items not in the database or disk: 53 ms
digikam: ScanLib: Updating items without date: 0 ms
... (Kipi stuffs follow)

I still don't find the problem.
(I am using Slackware 10.2, and KDE 3.5.1)

Another thing that I don't quite understand:
Digikam homepage suggests branches/stable/extragear/graphics source for digikam,
while it suggests trunk/extragear/libs for the extra_libs. Why is that?

Thanks!
Gabor Dudas
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Duncan Hill-5]

On Thursday 16 March 2006 15:24, Dudas Gabor wrote:

> Gilles Caulier wrote:
> > I have fixed any cast problem kioslave into trunk branch about size_t
> > definition. This bug have been reported to OpenBsd and fixed by a
> > contributor.
> >
> > Please give me a report with a fresh checkout of svn.
> >
> > Gilles Caulier
>
> It is weird. It's still not working. I have a feeling that I do something
> wrong, since the code from svn (and the packages) was working many times
> before!. I compiled them several times. Now it's not working. I shortly

Perchance have you disable thumbnail generation in KDE itself?

KControl -> KDE Components -> File Manager -> Previews & Meta-data

Ensure you have at least Local -> File enabled, and that your max file size is
big enough.
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

On Thursday 16 March 2006 04:31 pm, Gilles Caulier wrote:

> On Thursday 16 March 2006 04:24 pm, Dudas Gabor wrote:
> > Gilles Caulier wrote:
> > > I have fixed any cast problem kioslave into trunk branch about size_t
> > > definition. This bug have been reported to OpenBsd and fixed by a
> > > contributor.
> > >
> > > Please give me a report with a fresh checkout of svn.
> > >
> > > Gilles Caulier
> >
> > It is weird. It's still not working. I have a feeling that I do something
> > wrong, since the code from svn (and the packages) was working many times
> > before!. I compiled them several times. Now it's not working. I shortly
> > describe what I did: - I have downloaded the source from svn. I have used
> > the following sources: digikam:
> > svn://anonsvn.kde.org/home/kde/branches/stable/extragear/graphics
> > extragear
>
> no. My fix have been commited in unstable branch named trunk (corresponding
> to the next release 0.9.0), not in stable :
>
> svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/ extragear
>
> You can see the files fixed using websvn :
>
> http://websvn.kde.org/trunk/extragear/graphics/digikam/kioslave/
>
> > Another thing that I don't quite understand:
> > Digikam homepage suggests branches/stable/extragear/graphics source for
> > digikam, while it suggests trunk/extragear/libs for the extra_libs. Why
> > is that?
>
> libkipi and libkexif depencies
>
> Gilles

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Duncan Hill wrote:

>
> Perchance have you disable thumbnail generation in KDE itself?
>
> KControl -> KDE Components -> File Manager -> Previews & Meta-data
>
> Ensure you have at least Local -> File enabled, and that your max file size is
> big enough.

Well. I was thinking about the same. But no :(
The file size is set to 9 MBytes. Also, the previews are there in Konqueror (and
in showFoto also!)

Regards,
Gabor
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Gilles Caulier wrote:

>> It is weird. It's still not working. I have a feeling that I do something
>> wrong, since the code from svn (and the packages) was working many times
>> before!. I compiled them several times. Now it's not working. I shortly
>> describe what I did: - I have downloaded the source from svn. I have used
>> the following sources: digikam:
>> svn://anonsvn.kde.org/home/kde/branches/stable/extragear/graphics extragear
>
> no. My fix have been commited in unstable branch named trunk (corresponding to
> the next release 0.9.0), not in stable :
>
> svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/ extragear
>
> You can see the files fixed using websvn :
>
> http://websvn.kde.org/trunk/extragear/graphics/digikam/kioslave/

Okay, I am trying with this.
Since I am not so familiar with this svn system, could you tell me which admin
directory should I download for the trunk digikam? :

- svn://anonsvn.kde.org/home/kde/trunk/KDE/kde-common/admin/
or
- svn://anonsvn.kde.org/home/kde/branches/KDE/3.5/kde-common/admin

Thanks!
Gabor
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Dudas Gabor wrote:

> Gilles Caulier wrote:
>
>>> It is weird. It's still not working. I have a feeling that I do something
>>> wrong, since the code from svn (and the packages) was working many times
>>> before!. I compiled them several times. Now it's not working. I shortly
>>> describe what I did:  - I have downloaded the source from svn. I have used
>>> the following sources: digikam:
>>> svn://anonsvn.kde.org/home/kde/branches/stable/extragear/graphics extragear
>> no. My fix have been commited in unstable branch named trunk (corresponding to
>> the next release 0.9.0), not in stable :
>>
>> svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/ extragear
>>
>> You can see the files fixed using websvn :
>>
>> http://websvn.kde.org/trunk/extragear/graphics/digikam/kioslave/
>
> Okay, I am trying with this.

> Thanks!
> Gabor

I have compiled digikam from trunk and I got a strange result.
The thumbnails are generated only if the pictures are located in a subfolder!
Lets suppose I choose /home/dg/pics for an album folder. If I put some pictures
directly into this folder I will see nothing in digikam. But if I make a
subfolder into it with some pictures, like /home/dg/pics/summer/, I will see
that subfolder, and if I click on that I will see the contents too, as thumbnails!!
I have no idea, what can cause this...

Best regards,
Gabor Dudas
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

>> I have compiled digikam from trunk and I got a strange result.
>> The thumbnails are generated only if the pictures are located in a
>> subfolder! Lets suppose I choose /home/dg/pics for an album folder. If I
>> put some pictures directly into this folder I will see nothing in digikam.
>> But if I make a subfolder into it with some pictures, like
>> /home/dg/pics/summer/, I will see that subfolder, and if I click on that I
>> will see the contents too, as thumbnails!! I have no idea, what can cause
>> this...
>>
>
> ok. force digiKam to rebuild all thumbs. Stop digiKam and rename temporally  
> your ~/.thumbnails directory to ~/.thumbnails.old, and restart digiKam...
>
> Gilles

The same result :(
No thumbnail pictures are generated for the pictures located in the album's
root...only for sub-dirs.
I will try to compile digikam on another pc, and see the outcome...



Another thing: After I quit, I saw this message on the terminal:

digikam: Dirty: /
kio (KDirWatch): WARNING: KDirWatch::removeDir can't handle /etc/samba/smb.conf'
kio (KDirWatch): WARNING: KDirWatch::removeDir can't handle
/etc/security/fileshare.conf'
kio (KDirWatch): WARNING: KDirWatch::removeDir can't handle '/etc/exports'

I have a samba server running on the pc, but why digikam is dealing with that?

Thanks,
Gabor



_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-2]

Le Vendredi 17 Mars 2006 13:12, Dudas Gabor a écrit :

> >> I have compiled digikam from trunk and I got a strange result.
> >> The thumbnails are generated only if the pictures are located in a
> >> subfolder! Lets suppose I choose /home/dg/pics for an album folder. If I
> >> put some pictures directly into this folder I will see nothing in
> >> digikam. But if I make a subfolder into it with some pictures, like
> >> /home/dg/pics/summer/, I will see that subfolder, and if I click on that
> >> I will see the contents too, as thumbnails!! I have no idea, what can
> >> cause this...
> >
> > ok. force digiKam to rebuild all thumbs. Stop digiKam and rename
> > temporally your ~/.thumbnails directory to ~/.thumbnails.old, and restart
> > digiKam...
> >
> > Gilles
>
> The same result :(
> No thumbnail pictures are generated for the pictures located in the album's
> root...only for sub-dirs.
> I will try to compile digikam on another pc, and see the outcome...

Strange. I cannot reproduce this dysfonction here...

> Another thing: After I quit, I saw this message on the terminal:
>
> digikam: Dirty: /
> kio (KDirWatch): WARNING: KDirWatch::removeDir can't handle
> /etc/samba/smb.conf' kio (KDirWatch): WARNING: KDirWatch::removeDir can't
> handle
> /etc/security/fileshare.conf'
> kio (KDirWatch): WARNING: KDirWatch::removeDir can't handle '/etc/exports'
>
> I have a samba server running on the pc, but why digikam is dealing with
> that?
>

I think it's not a message from digikam but from KDE...

Gilles

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users