New Defects reported by Coverity Scan for digiKam

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

12 new defect(s) introduced to digiKam found with Coverity Scan.
15 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 12 of 12 defect(s)


** CID 1485985:    (UNCAUGHT_EXCEPT)
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()


________________________________________________________________________________________________________
*** CID 1485985:    (UNCAUGHT_EXCEPT)
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
48     #include "digikam_version.h"
49    
50     using namespace Digikam;
51    
52     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
53    
>>>     CID 1485985:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
54     int main(int argc, char** argv)
55     {
56         QApplication app(argc, argv);
57    
58         if (argc != 2)
59         {
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
48     #include "digikam_version.h"
49    
50     using namespace Digikam;
51    
52     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
53    
>>>     CID 1485985:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
54     int main(int argc, char** argv)
55     {
56         QApplication app(argc, argv);
57    
58         if (argc != 2)
59         {
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
48     #include "digikam_version.h"
49    
50     using namespace Digikam;
51    
52     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
53    
>>>     CID 1485985:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
54     int main(int argc, char** argv)
55     {
56         QApplication app(argc, argv);
57    
58         if (argc != 2)
59         {
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseswitch_cli.cpp: 54 in main()
48     #include "digikam_version.h"
49    
50     using namespace Digikam;
51    
52     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
53    
>>>     CID 1485985:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
54     int main(int argc, char** argv)
55     {
56         QApplication app(argc, argv);
57    
58         if (argc != 2)
59         {

** CID 1485984:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/libs/database/models/itemfiltermodel_p.cpp: 55 in Digikam::ItemFilterModel::ItemFilterModelPrivate::ItemFilterModelPrivate()()


________________________________________________________________________________________________________
*** CID 1485984:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/libs/database/models/itemfiltermodel_p.cpp: 55 in Digikam::ItemFilterModel::ItemFilterModelPrivate::ItemFilterModelPrivate()()
49           preparer           (nullptr),
50           filterer           (nullptr),
51           hasOneMatch        (false),
52           hasOneMatchForText (false)
53     {
54         setupWorkers();
>>>     CID 1485984:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "lastFilteredVersion" is not initialized in this constructor nor in any functions that it calls.
55     }
56    
57     ItemFilterModel::ItemFilterModelPrivate::~ItemFilterModelPrivate()
58     {
59         // facilitate thread stopping
60    

** CID 1485983:  Error handling issues  (UNCAUGHT_EXCEPT)
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseinit_cli.cpp: 54 in main()


________________________________________________________________________________________________________
*** CID 1485983:  Error handling issues  (UNCAUGHT_EXCEPT)
/mnt/devel/GIT/7.x/core/tests/database/checkdatabaseinit_cli.cpp: 54 in main()
48     #include "digikam_version.h"
49    
50     using namespace Digikam;
51    
52     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
53    
>>>     CID 1485983:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
54     int main(int argc, char** argv)
55     {
56         QApplication app(argc, argv);
57    
58         if (argc != 2)
59         {

** CID 1485058:  Resource leaks  (RESOURCE_LEAK)
/mnt/devel/GIT/7.x/core/libs/album/treeview/albumlabelssearchhandler.cpp: 519 in Digikam::AlbumLabelsSearchHandler::slotCheckStateChanged()()


________________________________________________________________________________________________________
*** CID 1485058:  Resource leaks  (RESOURCE_LEAK)
/mnt/devel/GIT/7.x/core/libs/album/treeview/albumlabelssearchhandler.cpp: 519 in Digikam::AlbumLabelsSearchHandler::slotCheckStateChanged()()
513             }
514    
515             emit checkStateChanged(album, Qt::Checked);
516         }
517    
518         d->oldXml = currentXml;
>>>     CID 1485058:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "album" going out of scope leaks the storage it points to.
519     }
520    
521     void AlbumLabelsSearchHandler::slotSetCurrentAlbum()
522     {
523         slotSelectionChanged();
524     }

** CID 1467488:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/facemanagement/threads/facepipelinepackage.h: 57 in ()


________________________________________________________________________________________________________
*** CID 1467488:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/facemanagement/threads/facepipelinepackage.h: 57 in ()
51     class DatabaseWriter;
52     class FacePreviewLoader;
53     class FaceItemRetriever;
54     class ParallelPipes;
55     class ScanStateFilter;
56    
>>>     CID 1467488:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::FacePipelineFaceTagsIface" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
57     class FacePipelineFaceTagsIface : public FaceTagsIface
58     {
59     public:
60    
61         enum Role
62         {

** CID 1465270:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/queuemanager/manager/queuesettings.h: 43 in ()


________________________________________________________________________________________________________
*** CID 1465270:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/queuemanager/manager/queuesettings.h: 43 in ()
37     namespace Digikam
38     {
39    
40     /**
41      * This container host all common settings used by a queue, not including assigned batch tools
42      */
>>>     CID 1465270:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::QueueSettings" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
43     class QueueSettings
44     {
45    
46     public:
47    
48         enum RenamingRule

** CID 1465265:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/imageeditor/core/iofilesettings.h: 35 in ()


________________________________________________________________________________________________________
*** CID 1465265:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/imageeditor/core/iofilesettings.h: 35 in ()
29     #include "drawdecoding.h"
30     #include "digikam_export.h"
31    
32     namespace Digikam
33     {
34    
>>>     CID 1465265:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::IOFileSettings" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
35     class DIGIKAM_EXPORT IOFileSettings
36     {
37    
38     public:
39    
40         IOFileSettings()

** CID 1460539:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/database/item/containers/itemposition.h: 46 in ()


________________________________________________________________________________________________________
*** CID 1460539:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/database/item/containers/itemposition.h: 46 in ()
40     namespace Digikam
41     {
42    
43     class CoreDbAccess;
44     class ItemPositionPriv;
45    
>>>     CID 1460539:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::ItemPosition" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
46     class DIGIKAM_DATABASE_EXPORT ItemPosition
47     {
48    
49     public:
50    
51         /**

** CID 1455818:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/database/history/itemhistorygraph.h: 45 in ()


________________________________________________________________________________________________________
*** CID 1455818:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/database/history/itemhistorygraph.h: 45 in ()
39     namespace Digikam
40     {
41    
42     class ItemHistoryGraphData;
43     class DImageHistory;
44    
>>>     CID 1455818:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::ItemHistoryGraph" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
45     class DIGIKAM_DATABASE_EXPORT ItemHistoryGraph
46     {
47     public:
48    
49         enum HistoryLoadingFlag
50         {

** CID 1455772:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/database/item/containers/iteminfo.h: 77 in ()


________________________________________________________________________________________________________
*** CID 1455772:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/database/item/containers/iteminfo.h: 77 in ()
71      *
72      * NOTE: access rules for all methods in this class:
73      * ItemInfoData members shall be accessed only under CoreDbAccess lock.
74      * The id and albumId are the exception to this rule, as they are
75      * primitive and will never change during the lifetime of an object.
76      */
>>>     CID 1455772:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::ItemInfo" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
77     class DIGIKAM_DATABASE_EXPORT ItemInfo
78     {
79     public:
80    
81         typedef DatabaseFields::Hash<QVariant> DatabaseFieldsHashRaw;
82    

** CID 1455763:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/fileactionmanager/fileactionimageinfolist.h: 103 in ()


________________________________________________________________________________________________________
*** CID 1455763:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/libs/fileactionmanager/fileactionimageinfolist.h: 103 in ()
97         // Disable
98         explicit FileActionProgressItemContainer(QObject*);
99     };
100    
101     // -------------------------------------------------------------------------------------------------------------------
102    
>>>     CID 1455763:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::FileActionItemInfoList" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
103     class FileActionItemInfoList : public QList<ItemInfo>
104     {
105     public:
106    
107         FileActionItemInfoList()
108         {

** CID 1406231:  Error handling issues  (UNCAUGHT_EXCEPT)
/mnt/devel/GIT/7.x/core/app/main/main.cpp: 99 in main()


________________________________________________________________________________________________________
*** CID 1406231:  Error handling issues  (UNCAUGHT_EXCEPT)
/mnt/devel/GIT/7.x/core/app/main/main.cpp: 99 in main()
93     #   include <shellapi.h>
94     #   include <objbase.h>
95     #endif
96    
97     using namespace Digikam;
98    
>>>     CID 1406231:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
99     int main(int argc, char* argv[])
100     {
101         SystemSettings system(QLatin1String("digikam"));
102         system.readSettings();
103    
104         QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DoQMZ_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADWxnFLZNEMYu5ia5XMkL70vwfqrdtU1KulYnyxYuF3k-2ByQJtEJ0-2F8XKr5k-2FhX-2F5dqGOi-2Fjy3O2g1bApTRPEdwQ0EJQs030INNMnJoRxac7y1Ab-2FbWHW2YaeRidEtGxgBnMYCNJaABT-2FqR6V7Fl7UBLdKsQGbTSNirNyS-2Fbrs69xUmx-2FfbHpumwG688x96V9F9M-3D