New Defects reported by Coverity Scan for digiKam

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

2 new defect(s) introduced to digiKam found with Coverity Scan.
92 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1467488:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/facemanagement/threads/facepipelinepackage.h: 57 in ()


________________________________________________________________________________________________________
*** CID 1467488:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/utilities/facemanagement/threads/facepipelinepackage.h: 57 in ()
51     class DatabaseWriter;
52     class FacePreviewLoader;
53     class FaceItemRetriever;
54     class ParallelPipes;
55     class ScanStateFilter;
56    
>>>     CID 1467488:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::FacePipelineFaceTagsIface" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
57     class FacePipelineFaceTagsIface : public FaceTagsIface
58     {
59     public:
60    
61         enum Role
62         {

** CID 1466766:  Error handling issues  (CHECKED_RETURN)
/mnt/devel/GIT/7.x/core/app/main/digikamapp_import.cpp: 177 in Digikam::DigikamApp::slotImportAddFolders()()


________________________________________________________________________________________________________
*** CID 1466766:  Error handling issues  (CHECKED_RETURN)
/mnt/devel/GIT/7.x/core/app/main/digikamapp_import.cpp: 177 in Digikam::DigikamApp::slotImportAddFolders()()
171    
172         foreach (const QUrl& url, urls)
173         {
174             if (pAlbum->albumRootPath().contains(url.toLocalFile()) ||
175                 url.toLocalFile().contains(pAlbum->albumRootPath()))
176             {
>>>     CID 1466766:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "warning" without checking return value (as is done elsewhere 32 out of 39 times).
177                 QMessageBox::warning(this, qApp->applicationName(),
178                                      i18n("The folder %1 is part of the album "
179                                           "path and cannot be imported recursively!",
180                                           QDir::toNativeSeparators(url.toLocalFile())));
181                 return;
182             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DRMlq_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADVRmR2D0sumjD-2BM8a8GaEZYuPDvcRBlymvwONrGQagLbilX1fdQf3-2Fg3Mkb6KfnfQhRPNQYiiFurtPtzleeZa2UAB9BTI5hlgs3bG09evoCg356h01Euw6u1KeT7dLxR1-2BF9EqWxZCYF9nkgyyWCGvj2abHV0NTVInSbikNnFjD4c2MpzPyH0RbRYH-2BeVnhKEw-3D