digiKam › digikam-devel

New Defects reported by Coverity Scan for digiKam

Classic

List

Threaded

1 message

scan-admin

New Defects reported by Coverity Scan for digiKam

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

8 new defect(s) introduced to digiKam found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)

** CID 1414702: Memory - illegal accesses (UNINIT)

________________________________________________________________________________________________________
*** CID 1414702: Memory - illegal accesses (UNINIT)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/tools/advprintlayouttree.cpp: 240 in Digikam::AdvPrintLayoutTree::AdvPrintLayoutTree(const Digikam::AdvPrintLayoutTree&)()
234 m_absoluteAreaPage(absoluteAreaPage)
235 {
236 }
237
238 AdvPrintLayoutTree::AdvPrintLayoutTree(const AdvPrintLayoutTree& other)
239 {
>>> CID 1414702: Memory - illegal accesses (UNINIT)
>>> Using uninitialized value "this->m_root" when calling "operator =".
240 (*this) = other;
241 }
242
243 AdvPrintLayoutTree& AdvPrintLayoutTree::operator=(const AdvPrintLayoutTree& other)
244 {
245 delete m_root;

** CID 1414701: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/assistants/printcreator/printcreator_src_automoc.dir/moc_advprintcustom_DH2XAKQ5GUBZ4L.cpp: 87 in Digikam::AdvPrintCustomLayoutDlg::qt_metacall(QMetaObject::Call, int, void **)()

________________________________________________________________________________________________________
*** CID 1414701: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/assistants/printcreator/printcreator_src_automoc.dir/moc_advprintcustom_DH2XAKQ5GUBZ4L.cpp: 87 in Digikam::AdvPrintCustomLayoutDlg::qt_metacall(QMetaObject::Call, int, void **)()
81 return QDialog::qt_metacast(_clname);
82 }
83
84 int Digikam::AdvPrintCustomLayoutDlg::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
85 {
86 _id = QDialog::qt_metacall(_c, _id, _a);
>>> CID 1414701: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
87 if (_id < 0)
88 return _id;
89 return _id;
90 }

** CID 1414700: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintcroppage.cpp: 78 in Digikam::AdvPrintCropPage::Private::Private(QWizard *)()

________________________________________________________________________________________________________
*** CID 1414700: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintcroppage.cpp: 78 in Digikam::AdvPrintCropPage::Private::Private(QWizard *)()
72
73 if (wizard)
74 {
75 settings = wizard->settings();
76 iface = wizard->iface();
77 }
>>> CID 1414700: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "iface" is not initialized in this constructor nor in any functions that it calls.
78 }
79
80 CropUI* cropUi;
81 AdvPrintWizard* wizard;
82 AdvPrintSettings* settings;
83 DInfoInterface* iface;

** CID 1414699: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/assistants/printcreator/printcreator_src_automoc.dir/moc_advprintcropfr_YDYX6UMMV4ODHM.cpp: 85 in Digikam::AdvPrintCropFrame::qt_metacall(QMetaObject::Call, int, void **)()

________________________________________________________________________________________________________
*** CID 1414699: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/assistants/printcreator/printcreator_src_automoc.dir/moc_advprintcropfr_YDYX6UMMV4ODHM.cpp: 85 in Digikam::AdvPrintCropFrame::qt_metacall(QMetaObject::Call, int, void **)()
79 return QWidget::qt_metacast(_clname);
80 }
81
82 int Digikam::AdvPrintCropFrame::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QWidget::qt_metacall(_c, _id, _a);
>>> CID 1414699: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }

** CID 1414698: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/widgets/digikamwidgetscore_src_automoc.dir/moc_dfiledialog_TLFQGNV5NMWZAY.cpp: 85 in Digikam::DFileDialog::qt_metacall(QMetaObject::Call, int, void **)()

________________________________________________________________________________________________________
*** CID 1414698: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/widgets/digikamwidgetscore_src_automoc.dir/moc_dfiledialog_TLFQGNV5NMWZAY.cpp: 85 in Digikam::DFileDialog::qt_metacall(QMetaObject::Call, int, void **)()
79 return QFileDialog::qt_metacast(_clname);
80 }
81
82 int Digikam::DFileDialog::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QFileDialog::qt_metacall(_c, _id, _a);
>>> CID 1414698: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }

** CID 1414697: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintcaptionpage.cpp: 81 in Digikam::AdvPrintCaptionPage::Private::Private(QWizard *)()

________________________________________________________________________________________________________
*** CID 1414697: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintcaptionpage.cpp: 81 in Digikam::AdvPrintCaptionPage::Private::Private(QWizard *)()
75
76 if (wizard)
77 {
78 settings = wizard->settings();
79 iface = wizard->iface();
80 }
>>> CID 1414697: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "iface" is not initialized in this constructor nor in any functions that it calls.
81 }
82
83 CaptionUI* captionUi;
84 AdvPrintWizard* wizard;
85 AdvPrintSettings* settings;
86 DInfoInterface* iface;

** CID 1414696: (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintintropage.cpp: 63 in Digikam::AdvPrintIntroPage::Private::Private(QWizard *)()
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintintropage.cpp: 63 in Digikam::AdvPrintIntroPage::Private::Private(QWizard *)()

________________________________________________________________________________________________________
*** CID 1414696: (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintintropage.cpp: 63 in Digikam::AdvPrintIntroPage::Private::Private(QWizard *)()
57 wizard = dynamic_cast<AdvPrintWizard*>(dialog);
58
59 if (wizard)
60 {
61 iface = wizard->iface();
62 }
>>> CID 1414696: (UNINIT_CTOR)
>>> Non-static class member "hbox" is not initialized in this constructor nor in any functions that it calls.
63 }
64
65 QComboBox* imageGetOption;
66 DHBox* hbox;
67 GimpBinary gimpBin;
68 DBinarySearch* binSearch;
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintintropage.cpp: 63 in Digikam::AdvPrintIntroPage::Private::Private(QWizard *)()
57 wizard = dynamic_cast<AdvPrintWizard*>(dialog);
58
59 if (wizard)
60 {
61 iface = wizard->iface();
62 }
>>> CID 1414696: (UNINIT_CTOR)
>>> Non-static class member "iface" is not initialized in this constructor nor in any functions that it calls.
63 }
64
65 QComboBox* imageGetOption;
66 DHBox* hbox;
67 GimpBinary gimpBin;
68 DBinarySearch* binSearch;

** CID 1414695: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintwizard.cpp: 88 in Digikam::AdvPrintWizard::Private::Private()()

________________________________________________________________________________________________________
*** CID 1414695: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/wizard/advprintwizard.cpp: 88 in Digikam::AdvPrintWizard::Private::Private()()
82 albumsPage = 0;
83 photoPage = 0;
84 captionPage = 0;
85 cropPage = 0;
86 cancelPrinting = false;
87 iface = 0;
>>> CID 1414695: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "settings" is not initialized in this constructor nor in any functions that it calls.
88 }
89
90 const float FONT_HEIGHT_RATIO;
91
92 AdvPrintIntroPage* introPage;
93 AdvPrintAlbumsPage* albumsPage;

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTAMUjXnOaFTuKJCqXbEyVKzHSHnpc2r8P1Bku-2FntQf3-2BAIpwwOwaJzWrTHrvrwfahBK7O9ArOAUtoTZ3jh7Q2mCzpwaoX5k5bQizxAJUzvMR8H-2F0qB0PFXdOpvR5ReExldqdgSRY-2FN8Qqox3geNDP9CvqzcRyZAtKoKCdPGp81FtJTC6DISuKwIoxQ8bXQ7atA-3D

To manage Coverity Scan email notifications for "[hidden email]", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTAMUjXnOaFTuKJCqXbEyVKzNTKCjanSvfQHdrcjfwzlZTjwu3C6fxFeicsKWVGGw2aOAksLOutSWj0RNIMItBw75U48Mtdv-2BTTE1RwRI-2FsMrY5yVg9SxAky4KZWnLGKSLTVRiBIdfvYxvixkrI2c3YzKob5cCXDDGkRhIMhK-2B3FMsiRNlkgFA0TVpvYR7EdH0A-3D