New Defects reported by Coverity Scan for digiKam

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

4 new defect(s) introduced to digiKam found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1412932:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_placeholderwid_PCPXNJE3SGLDEI.cpp: 85 in Digikam::PlaceholderWidget::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1412932:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_placeholderwid_PCPXNJE3SGLDEI.cpp: 85 in Digikam::PlaceholderWidget::qt_metacall(QMetaObject::Call, int, void **)()
79         return QFrame::qt_metacast(_clname);
80     }
81    
82     int Digikam::PlaceholderWidget::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = QFrame::qt_metacall(_c, _id, _a);
>>>     CID 1412932:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }

** CID 1412931:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_geoifacecommon_VH74N3VBN2ALMQ.cpp: 85 in Digikam::GeoIfaceGlobalObject::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1412931:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_geoifacecommon_VH74N3VBN2ALMQ.cpp: 85 in Digikam::GeoIfaceGlobalObject::qt_metacall(QMetaObject::Call, int, void **)()
79         return QObject::qt_metacast(_clname);
80     }
81    
82     int Digikam::GeoIfaceGlobalObject::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = QObject::qt_metacall(_c, _id, _a);
>>>     CID 1412931:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }

** CID 1412930:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_tilegrouper_YXEKL2ALXWSHQH.cpp: 85 in Digikam::TileGrouper::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1412930:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_tilegrouper_YXEKL2ALXWSHQH.cpp: 85 in Digikam::TileGrouper::qt_metacall(QMetaObject::Call, int, void **)()
79         return QObject::qt_metacast(_clname);
80     }
81    
82     int Digikam::TileGrouper::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = QObject::qt_metacall(_c, _id, _a);
>>>     CID 1412930:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }

** CID 1412929:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_geodragdrophan_7WAFFML2Q5QJMZ.cpp: 85 in Digikam::GeoDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1412929:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/geoiface_src_automoc.dir/moc_geodragdrophan_7WAFFML2Q5QJMZ.cpp: 85 in Digikam::GeoDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
79         return QObject::qt_metacast(_clname);
80     }
81    
82     int Digikam::GeoDragDropHandler::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = QObject::qt_metacall(_c, _id, _a);
>>>     CID 1412929:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTCsYZGOWlDKrgOEk0A6fQenKarVpl-2FZnbmJrhl3iYl-2Ftm3k75EQlDEzxufhxe7KFyGv4kOQ7xtTLCxIAOF145ujbKWL-2FV9JC3hTgmZN-2B8f0pEyV0Em69WTsiAGo0HR3KZEW-2F2sfw61nu9nx-2FzDdBXbKfR50ayC6uTg-2BdPo0J-2FglGjLfB5g-2F-2F2ShffgSiemQOIg-3D

To manage Coverity Scan email notifications for "[hidden email]", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTCsYZGOWlDKrgOEk0A6fQendgGQm0it1N5BJCPv0Gru9lYMeGU18PvANmYtcEyj1tWy8Y56ntMfDY6X2-2FlsNTrB8IJr6bIyodlSKkXTT196Mq-2B2qphTPWF4TMQHjnjBewqiDDqjtUzDm-2FEczKCAIUcn5F0xgLFTJn2tM6ntlCWQawRZ5gcOkJj3zcPG7OL-2BT4A-3D