Hi, Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan. 6 new defect(s) introduced to digiKam found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1325910: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dwidgetutils.cpp: 153 in Digikam::DVBox::qt_metacall(QMetaObject::Call, int, void **)() ________________________________________________________________________________________________________ *** CID 1325910: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dwidgetutils.cpp: 153 in Digikam::DVBox::qt_metacall(QMetaObject::Call, int, void **)() 147 return DHBox::qt_metacast(_clname); 148 } 149 150 int Digikam::DVBox::qt_metacall(QMetaObject::Call _c, int _id, void **_a) 151 { 152 _id = DHBox::qt_metacall(_c, _id, _a); >>> CID 1325910: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 153 if (_id < 0) 154 return _id; 155 return _id; 156 } 157 struct qt_meta_stringdata_Digikam__DFileSelector_t { 158 QByteArrayData data[5]; ** CID 1325909: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dwidgetutils.cpp: 85 in Digikam::DHBox::qt_metacall(QMetaObject::Call, int, void **)() ________________________________________________________________________________________________________ *** CID 1325909: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dwidgetutils.cpp: 85 in Digikam::DHBox::qt_metacall(QMetaObject::Call, int, void **)() 79 return QFrame::qt_metacast(_clname); 80 } 81 82 int Digikam::DHBox::qt_metacall(QMetaObject::Call _c, int _id, void **_a) 83 { 84 _id = QFrame::qt_metacall(_c, _id, _a); >>> CID 1325909: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 85 if (_id < 0) 86 return _id; 87 return _id; 88 } 89 struct qt_meta_stringdata_Digikam__DVBox_t { 90 QByteArrayData data[1]; ** CID 1325908: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dactivelabel.cpp: 85 in Digikam::DActiveLabel::qt_metacall(QMetaObject::Call, int, void **)() ________________________________________________________________________________________________________ *** CID 1325908: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dactivelabel.cpp: 85 in Digikam::DActiveLabel::qt_metacall(QMetaObject::Call, int, void **)() 79 return QLabel::qt_metacast(_clname); 80 } 81 82 int Digikam::DActiveLabel::qt_metacall(QMetaObject::Call _c, int _id, void **_a) 83 { 84 _id = QLabel::qt_metacall(_c, _id, _a); >>> CID 1325908: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 85 if (_id < 0) 86 return _id; 87 return _id; 88 } ** CID 1325907: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dexpanderbox.cpp: 85 in Digikam::DLineWidget::qt_metacall(QMetaObject::Call, int, void **)() ________________________________________________________________________________________________________ *** CID 1325907: Incorrect expression (IDENTICAL_BRANCHES) /core/libs/widgets/moc_dexpanderbox.cpp: 85 in Digikam::DLineWidget::qt_metacall(QMetaObject::Call, int, void **)() 79 return QFrame::qt_metacast(_clname); 80 } 81 82 int Digikam::DLineWidget::qt_metacall(QMetaObject::Call _c, int _id, void **_a) 83 { 84 _id = QFrame::qt_metacall(_c, _id, _a); >>> CID 1325907: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 85 if (_id < 0) 86 return _id; 87 return _id; 88 } 89 struct qt_meta_stringdata_Digikam__DAdjustableLabel_t { 90 QByteArrayData data[4]; ** CID 1325906: Incorrect expression (IDENTICAL_BRANCHES) /extra/kipi-plugins/common/libkipiplugins/moc_kputil.cpp: 85 in KIPIPlugins::KPHBox::qt_metacall(QMetaObject::Call, int, void **)() ________________________________________________________________________________________________________ *** CID 1325906: Incorrect expression (IDENTICAL_BRANCHES) /extra/kipi-plugins/common/libkipiplugins/moc_kputil.cpp: 85 in KIPIPlugins::KPHBox::qt_metacall(QMetaObject::Call, int, void **)() 79 return QFrame::qt_metacast(_clname); 80 } 81 82 int KIPIPlugins::KPHBox::qt_metacall(QMetaObject::Call _c, int _id, void **_a) 83 { 84 _id = QFrame::qt_metacall(_c, _id, _a); >>> CID 1325906: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 85 if (_id < 0) 86 return _id; 87 return _id; 88 } 89 struct qt_meta_stringdata_KIPIPlugins__KPVBox_t { 90 QByteArrayData data[1]; ** CID 1325905: Incorrect expression (IDENTICAL_BRANCHES) /extra/kipi-plugins/common/libkipiplugins/moc_kputil.cpp: 153 in KIPIPlugins::KPVBox::qt_metacall(QMetaObject::Call, int, void **)() ________________________________________________________________________________________________________ *** CID 1325905: Incorrect expression (IDENTICAL_BRANCHES) /extra/kipi-plugins/common/libkipiplugins/moc_kputil.cpp: 153 in KIPIPlugins::KPVBox::qt_metacall(QMetaObject::Call, int, void **)() 147 return KPHBox::qt_metacast(_clname); 148 } 149 150 int KIPIPlugins::KPVBox::qt_metacall(QMetaObject::Call _c, int _id, void **_a) 151 { 152 _id = KPHBox::qt_metacall(_c, _id, _a); >>> CID 1325905: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 153 if (_id < 0) 154 return _id; 155 return _id; 156 } 157 struct qt_meta_stringdata_KIPIPlugins__KPFileSelector_t { 158 QByteArrayData data[5]; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview To manage Coverity Scan email notifications for "[hidden email]", click https://scan.coverity.com/subscriptions/edit?email=digikam-devel%40kde.org&token=621bfe7450f4a870432a2a9c106aa3a8 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |