digiKam › digikam-devel

New Defects reported by Coverity Scan for digiKam

Classic

List

Threaded

1 message

scan-admin

New Defects reported by Coverity Scan for digiKam

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

6 new defect(s) introduced to digiKam found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)

** CID 1308783: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/newalbumdlg.cpp: 78 in KIPIGoogleServicesPlugin::NewAlbumDlg::NewAlbumDlg(QWidget *, const QString &)()

________________________________________________________________________________________________________
*** CID 1308783: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/newalbumdlg.cpp: 78 in KIPIGoogleServicesPlugin::NewAlbumDlg::NewAlbumDlg(QWidget *, const QString &)()
72 albumBoxLayout->addRow(i18nc("folder edit","Title:"),m_titleEdt);
73 albumBoxLayout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow);
74 albumBoxLayout->setSpacing(KDialog::spacingHint());
75 albumBoxLayout->setMargin(KDialog::spacingHint());
76 mainWidget->setMinimumSize(300,0);
77 mainWidget->setLayout(albumBoxLayout);
>>> CID 1308783: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_protectedRBtn" is not initialized in this constructor nor in any functions that it calls.
78 return;
79 }
80
81 QGroupBox* const albumBox = new QGroupBox(i18n("Album"), mainWidget);
82 albumBox->setWhatsThis(
83 i18n("These are basic settings for the new Google Photos/Picasaweb album."));

** CID 1308782: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/gswidget.cpp: 302 in KIPIGoogleServicesPlugin::GoogleServicesWidget::GoogleServicesWidget(QWidget *, KIPI::Interface *, const QString &)()

________________________________________________________________________________________________________
*** CID 1308782: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/gswidget.cpp: 302 in KIPIGoogleServicesPlugin::GoogleServicesWidget::GoogleServicesWidget(QWidget *, KIPI::Interface *, const QString &)()
296 }
297 else
298 {
299 uploadBox->hide();
300 sizeBox->hide();
301 }
>>> CID 1308782: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_tagsBGrp" is not initialized in this constructor nor in any functions that it calls.
302 }
303
304 GoogleServicesWidget::~GoogleServicesWidget()
305 {
306 }
307

** CID 1308781: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/picasawebtalker.cpp: 88 in KIPIGoogleServicesPlugin::PicasawebTalker::PicasawebTalker(QWidget *)()

________________________________________________________________________________________________________
*** CID 1308781: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/picasawebtalker.cpp: 88 in KIPIGoogleServicesPlugin::PicasawebTalker::PicasawebTalker(QWidget *)()
82
83 PicasawebTalker::PicasawebTalker(QWidget* const parent)
84 :Authorize(parent,QString("https://picasaweb.google.com/data/")), m_job(0)
85 {
86 connect(this, SIGNAL(signalError(QString)),
87 this, SLOT(slotError(QString)));
>>> CID 1308781: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_state" is not initialized in this constructor nor in any functions that it calls.
88 }
89
90 PicasawebTalker::~PicasawebTalker()
91 {
92 if (m_job)
93 m_job->kill();

** CID 1308780: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/gdtalker.cpp: 84 in KIPIGoogleServicesPlugin::GDTalker::GDTalker(QWidget *)()

________________________________________________________________________________________________________
*** CID 1308780: Uninitialized members (UNINIT_CTOR)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/gdtalker.cpp: 84 in KIPIGoogleServicesPlugin::GDTalker::GDTalker(QWidget *)()
78
79 GDTalker::GDTalker(QWidget* const parent)
80 :Authorize(parent,QString("https://www.googleapis.com/auth/drive"))
81 {
82 m_rootid = "root";
83 m_rootfoldername = "GoogleDrive Root";
>>> CID 1308780: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_state" is not initialized in this constructor nor in any functions that it calls.
84 }
85
86 GDTalker::~GDTalker()
87 {
88
89 }

** CID 1308779: Control flow issues (NESTING_INDENT_MISMATCH)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/gswindow.cpp: 1202 in KIPIGoogleServicesPlugin::GSWindow::slotCreateFolderDone(int, const QString &, const QString &)()

________________________________________________________________________________________________________
*** CID 1308779: Control flow issues (NESTING_INDENT_MISMATCH)
/mnt/devel/GIT/4.x/extra/kipi-plugins/googleservices/gswindow.cpp: 1202 in KIPIGoogleServicesPlugin::GSWindow::slotCreateFolderDone(int, const QString &, const QString &)()
1196 else
1197 {
1198 if(code == 0)
1199 KMessageBox::error(this, i18n("Google Photos/PicasaWeb call failed:\n%1", msg));
1200 else
1201 m_currentAlbumId = albumId;
>>> CID 1308779: Control flow issues (NESTING_INDENT_MISMATCH)
>>> This statement is indented to column 13, as if it were nested within the preceding parent statement, but it is not.
1202 m_picsasa_talker->listAlbums();
1203 }
1204
1205 }
1206
1207 void GSWindow::slotTransferCancel()

** CID 1308778: Control flow issues (DEADCODE)
/mnt/devel/GIT/4.x/core/utilities/baloo/baloowrap.cpp: 233 in Digikam::BalooWrap::bestDigikamTagForTagName(const Digikam::ImageInfo &, const QString &) const()

________________________________________________________________________________________________________
*** CID 1308778: Control flow issues (DEADCODE)
/mnt/devel/GIT/4.x/core/utilities/baloo/baloowrap.cpp: 233 in Digikam::BalooWrap::bestDigikamTagForTagName(const Digikam::ImageInfo &, const QString &) const()
227 {
228 id = TagsCache::instance()->parentTag(id);
229 score++;
230 }
231 while (id);
232
>>> CID 1308778: Control flow issues (DEADCODE)
>>> Execution cannot reach this expression "score < currentMinimumScore" inside statement "if (!currentMinimumScore ||...".
233 if (!currentMinimumScore || score < currentMinimumScore)
234 {
235 currentCandidate = tagId;
236 }
237 }
238

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/285?tab=overview

To manage Coverity Scan email notifications for "[hidden email]", click https://scan.coverity.com/subscriptions/edit?email=digikam-devel%40kde.org&token=621bfe7450f4a870432a2a9c106aa3a8

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel