digiKam › digikam-devel

New Defects reported by Coverity Scan for digiKam

Classic

List

Threaded

1 message

scan-admin

New Defects reported by Coverity Scan for digiKam

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan

Defect(s) Reported-by: Coverity Scan
Showing 7 of 16 defects

** CID 1061029: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75

** CID 1061028: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/core/utilities/fuzzysearch/findduplicatesview.cpp: 73

** CID 1061027: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/core/digikam/views/leftsidebarwidgets.cpp: 183

** CID 1061026: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 84

** CID 1061025: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagpropwidget.cpp: 58

** CID 1061024: Dereference after null check (FORWARD_NULL)

** CID 1061023: Unchecked return value (CHECKED_RETURN)
/mnt/devel/GIT/3.x/core/digikam/dragdrop/imagedragdrop.cpp: 455

________________________________________________________________________
CID 1061029: Uninitialized pointer field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 62 ( member_decl)
59
60 public:
61
>>> Class member declaration for "cancel".
62 bool cancel;
63
64 KUrl::List urls;
65 Action action;
66 KUrl outputUrl;

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> Non-static class member "cancel" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 71 ( member_decl)
68 const RawDecodingSettings settings;
69 bool align;
70 QString binaryPath;
>>> Class member declaration for "enfuseVersion4x".
71 bool enfuseVersion4x;
72
73
74 KProcess* enfuseProcess;
75 KProcess* alignProcess;

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> Non-static class member "enfuseVersion4x" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 74 ( member_decl)
71 bool enfuseVersion4x;
72
73
>>> Class member declaration for "enfuseProcess".
74 KProcess* enfuseProcess;
75 KProcess* alignProcess;
76
77 QString errString;
78

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> Non-static class member "enfuseProcess" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 75 ( member_decl)
72
73
74 KProcess* enfuseProcess;
>>> Class member declaration for "alignProcess".
75 KProcess* alignProcess;
76
77 QString errString;
78
79 KTempDir* preprocessingTmpDir;

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> Non-static class member "alignProcess" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 79 ( member_decl)
76
77 QString errString;
78
>>> Class member declaration for "preprocessingTmpDir".
79 KTempDir* preprocessingTmpDir;
80
81 protected:
82
83 bool successFlag;

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> Non-static class member "preprocessingTmpDir" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 83 ( member_decl)
80
81 protected:
82
>>> Class member declaration for "successFlag".
83 bool successFlag;
84 bool isAbortedFlag;
85 const KUrl tmpDir;
86
87 public:

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> Non-static class member "successFlag" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.h: 84 ( member_decl)
81 protected:
82
83 bool successFlag;
>>> Class member declaration for "isAbortedFlag".
84 bool isAbortedFlag;
85 const KUrl tmpDir;
86
87 public:
88

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/generictask.cpp: 75 ( uninit_member)
72 const RawDecodingSettings& rawSettings, const bool align, const QString& alignPath)
73 : Task(parent, action, fileUrl), urls(fileUrl), action(action),
74 settings(rawSettings), align(align), binaryPath(alignPath)
>>> CID 1061029: Uninitialized pointer field (UNINIT_CTOR)
>>> Non-static class member "isAbortedFlag" is not initialized in this constructor nor in any functions that it calls.
75 {}
76
77 GenericTask::GenericTask(QObject* const parent, const KUrl::List& fileUrl, const Action& action, const KUrl& outputUrl,
78 const EnfuseSettings& settings, const QString& alignPath, bool version)
79 : Task(parent, action, fileUrl), urls(fileUrl), action(action), outputUrl(outputUrl), enfuseSettings(settings),

________________________________________________________________________
CID 1061028: Uninitialized pointer field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/core/utilities/fuzzysearch/findduplicatesview.cpp: 75 ( member_decl)
72 albumSelectors = 0;
73 }
74
>>> Class member declaration for "includeAlbumsLabel".
75 QLabel* includeAlbumsLabel;
76 QLabel* similarityLabel;
77
78 QSpinBox* similarity;
79

/mnt/devel/GIT/3.x/core/utilities/fuzzysearch/findduplicatesview.cpp: 73 ( uninit_member)
70 similarityLabel = 0;
71 similarity = 0;
72 albumSelectors = 0;
>>> CID 1061028: Uninitialized pointer field (UNINIT_CTOR)
>>> Non-static class member "includeAlbumsLabel" is not initialized in this constructor nor in any functions that it calls.
73 }
74
75 QLabel* includeAlbumsLabel;
76 QLabel* similarityLabel;
77

________________________________________________________________________
CID 1061027: Uninitialized pointer field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/core/digikam/views/leftsidebarwidgets.cpp: 189 ( member_decl)
186 KPushButton* openTagMngr;
187 SearchTextBar* tagSearchBar;
188 TagFolderView* tagFolderView;
>>> Class member declaration for "tagMngr".
189 TagsManager* tagMngr;
190 };
191
192 TagViewSideBarWidget::TagViewSideBarWidget(QWidget* const parent, TagModel* const model)
193 : SidebarWidget(parent), d(new Private)

/mnt/devel/GIT/3.x/core/digikam/views/leftsidebarwidgets.cpp: 183 ( uninit_member)
180 tagSearchBar(0),
181 tagFolderView(0)
182 {
>>> CID 1061027: Uninitialized pointer field (UNINIT_CTOR)
>>> Non-static class member "tagMngr" is not initialized in this constructor nor in any functions that it calls.
183 }
184
185 TagModel* tagModel;
186 KPushButton* openTagMngr;
187 SearchTextBar* tagSearchBar;

________________________________________________________________________
CID 1061026: Uninitialized pointer field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 86 ( member_decl)
83 listView = 0;
84 }
85
>>> Class member declaration for "tagMngrView".
86 TagMngrTreeView* tagMngrView;
87 QLabel* tagmngrLabel;
88 QLabel* tagPixmap;
89 QLabel* digikamPixmap;
90 SearchTextBar* searchBar;

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 84 ( uninit_member)
81 addAction = 0;
82 delAction = 0;
83 listView = 0;
>>> Non-static class member "tagMngrView" is not initialized in this constructor nor in any functions that it calls.
84 }
85
86 TagMngrTreeView* tagMngrView;
87 QLabel* tagmngrLabel;
88 QLabel* tagPixmap;

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 104 ( member_decl)
101 KAction* delAction;
102 TagList* listView;
103
>>> Class member declaration for "tagPropWidget".
104 TagPropWidget* tagPropWidget;
105
106 TagModel* tagModel;
107 };
108

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 84 ( uninit_member)
81 addAction = 0;
82 delAction = 0;
83 listView = 0;
>>> Non-static class member "tagPropWidget" is not initialized in this constructor nor in any functions that it calls.
84 }
85
86 TagMngrTreeView* tagMngrView;
87 QLabel* tagmngrLabel;
88 QLabel* tagPixmap;

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 106 ( member_decl)
103
104 TagPropWidget* tagPropWidget;
105
>>> Class member declaration for "tagModel".
106 TagModel* tagModel;
107 };
108
109 TagsManager::TagsManager(TagModel* model)
110 : KDialog(0), d(new PrivateTagMngr())

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagsmanager.cpp: 84 ( uninit_member)
81 addAction = 0;
82 delAction = 0;
83 listView = 0;
>>> CID 1061026: Uninitialized pointer field (UNINIT_CTOR)
>>> Non-static class member "tagModel" is not initialized in this constructor nor in any functions that it calls.
84 }
85
86 TagMngrTreeView* tagMngrView;
87 QLabel* tagmngrLabel;
88 QLabel* tagPixmap;

________________________________________________________________________
CID 1061025: Uninitialized pointer field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagpropwidget.cpp: 68 ( member_decl)
65
66 QPushButton* iconButton;
67 QPushButton* resetIconButton;
>>> Class member declaration for "mainRootAlbum".
68 TAlbum* mainRootAlbum;
69 KKeySequenceWidget* keySeqWidget;
70 SearchTextBar* titleEdit;
71 };
72

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagpropwidget.cpp: 58 ( uninit_member)
55 topLabel = 0;
56 keySeqWidget = 0;
57 create = false;
>>> CID 1061025: Uninitialized pointer field (UNINIT_CTOR)
>>> Non-static class member "mainRootAlbum" is not initialized in this constructor nor in any functions that it calls.
58 }
59
60 bool create;
61
62 QLabel* topLabel;

________________________________________________________________________
CID 1061024: Dereference after null check (FORWARD_NULL)

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagpropwidget.cpp: 159 ( var_compare_op)
156
157 void TagPropWidget::slotSelectionChanged(TAlbum* album)
158 {
>>> Comparing "album" to null implies that "album" might be null.
159 if(!album)
160 kDebug() << "Error! No valid pointer for TAlbum";
161 d->mainRootAlbum = album;
162 d->titleEdit->setText(album->title());
163 d->icon = album->icon();

/mnt/devel/GIT/3.x/core/digikam/tags/tagsmanager/tagpropwidget.cpp: 162 ( var_deref_model)
159 if(!album)
160 kDebug() << "Error! No valid pointer for TAlbum";
161 d->mainRootAlbum = album;
>>> CID 1061024: Dereference after null check (FORWARD_NULL)
>>> Passing null pointer "album" to function "Digikam::Album::title() const", which dereferences it.
162 d->titleEdit->setText(album->title());
163 d->icon = album->icon();
164 d->iconButton->setIcon(SyncJob::getTagThumbnail(album));
165 }
166

________________________________________________________________________
CID 1061023: Unchecked return value (CHECKED_RETURN)

/mnt/devel/GIT/3.x/core/digikam/dragdrop/imagedragdrop.cpp: 455 ( check_return)
452 else if (DTagListDrag::canDecode(e->mimeData()))
453 {
454 QList<int> tagIDs;
>>> CID 1061023: Unchecked return value (CHECKED_RETURN)
>>> Calling function "Digikam::DTagListDrag::decode(QMimeData const *, QList<int> &)" without checking return value (as is done elsewhere 4 out of 5 times).
455 DTagListDrag::decode(e->mimeData(), tagIDs);
456
457 KMenu popMenu(view);
458
459 QList<ImageInfo> selectedInfos = view->selectedImageInfosCurrentFirst();

/mnt/devel/GIT/3.x/core/digikam/dragdrop/imagedragdrop.cpp: 455 ( unchecked_value)
452 else if (DTagListDrag::canDecode(e->mimeData()))
453 {
454 QList<int> tagIDs;
>>> No check of the return value of "Digikam::DTagListDrag::decode(e->mimeData(), tagIDs)".
455 DTagListDrag::decode(e->mimeData(), tagIDs);
456
457 KMenu popMenu(view);
458
459 QList<ImageInfo> selectedInfos = view->selectedImageInfosCurrentFirst();

________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com

To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel