digiKam › digikam-devel

New Defects reported by Coverity Scan for digiKam

Classic

List

Threaded

1 message

scan-admin

New Defects reported by Coverity Scan for digiKam

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity SCAN

Defect(s) Reported-by: Coverity Scan

** CID 990527: Uninitialized scalar field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.cpp: 43
http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10358#mergedDefectId=990527

** CID 990526: Dereference after null check (FORWARD_NULL)
http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10358#mergedDefectId=990526

** CID 990525: Resource leak in object (CTOR_DTOR_LEAK)
/mnt/devel/GIT/3.x/core/digikam/views/tableview_model.cpp: 122
http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10358#mergedDefectId=990525

________________________________________________________________________
CID 990527: Uninitialized scalar field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.h: 71 ( member_decl)
68 QString serialisedLeaves;
69 QString Name;
70
>>> Class member declaration for "faceid".
71 int faceid;
72 int objHeight;
73 int objWidth;
74
75 float minVar;

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.cpp: 43 ( uninit_member)
40
41 unitFaceModel::unitFaceModel()
42 {
>>> Non-static class member "faceid" is not initialized in this constructor nor in any functions that it calls.
43 }
44
45 unitFaceModel::~unitFaceModel()
46 {
47 }

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.h: 72 ( member_decl)
69 QString Name;
70
71 int faceid;
>>> Class member declaration for "objHeight".
72 int objHeight;
73 int objWidth;
74
75 float minVar;
76 };

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.cpp: 43 ( uninit_member)
40
41 unitFaceModel::unitFaceModel()
42 {
>>> Non-static class member "objHeight" is not initialized in this constructor nor in any functions that it calls.
43 }
44
45 unitFaceModel::~unitFaceModel()
46 {
47 }

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.h: 73 ( member_decl)
70
71 int faceid;
72 int objHeight;
>>> Class member declaration for "objWidth".
73 int objWidth;
74
75 float minVar;
76 };
77

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.cpp: 43 ( uninit_member)
40
41 unitFaceModel::unitFaceModel()
42 {
>>> Non-static class member "objWidth" is not initialized in this constructor nor in any functions that it calls.
43 }
44
45 unitFaceModel::~unitFaceModel()
46 {
47 }

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.h: 75 ( member_decl)
72 int objHeight;
73 int objWidth;
74
>>> Class member declaration for "minVar".
75 float minVar;
76 };
77
78 } // namespace libface

/mnt/devel/GIT/3.x/extra/libkface/OpenTLD/tldinterface/tldface.cpp: 43 ( uninit_member)
40
41 unitFaceModel::unitFaceModel()
42 {
>>> CID 990527: Uninitialized scalar field (UNINIT_CTOR)
>>> Non-static class member "minVar" is not initialized in this constructor nor in any functions that it calls.
43 }
44
45 unitFaceModel::~unitFaceModel()
46 {
47 }

________________________________________________________________________
CID 990526: Dereference after null check (FORWARD_NULL)

/mnt/devel/GIT/3.x/core/digikam/dragdrop/imagedragdrop.cpp: 211 ( var_compare_op)
208 // Note that the drop event does not have to be in an ImageCategorizedView.
209 // It can also be a TableViewTreeView.
210 ImageCategorizedView* view = qobject_cast<ImageCategorizedView*>(abstractview);
>>> Comparing "view" to null implies that "view" might be null.
211 if (view)
212 {
213 album = view->albumAt(e->pos());
214 }
215 else

/mnt/devel/GIT/3.x/core/digikam/dragdrop/imagedragdrop.cpp: 511 ( var_deref_model)
508
509 KMenu popMenu(view);
510
>>> CID 990526: Dereference after null check (FORWARD_NULL)
>>> Passing null pointer "view" to function "Digikam::ImageCategorizedView::selectedImageInfosCurrentFirst() const", which dereferences it.
511 QList<ImageInfo> selectedInfos = view->selectedImageInfosCurrentFirst();
512 QAction* assignToSelectedAction = 0;
513
514 if (selectedInfos.count() > 1)
515 {

________________________________________________________________________
CID 990525: Resource leak in object (CTOR_DTOR_LEAK)

/mnt/devel/GIT/3.x/core/digikam/views/tableview_model.cpp: 122 ( alloc_new)
119 Private()
120 : columnObjects(),
121 rootItem(new TableViewModelItem())
>>> CID 990525: Resource leak in object (CTOR_DTOR_LEAK)
>>> Allocating memory by calling "new Digikam::TableViewModelItem".
122 {
123 }
124
125 QList<TableViewColumn*> columnObjects;
126 TableViewModelItem* rootItem;

/mnt/devel/GIT/3.x/core/digikam/views/tableview_model.cpp: 122 ( var_assign)
119 Private()
120 : columnObjects(),
121 rootItem(new TableViewModelItem())
>>> Assigning: "this->rootItem" = "new Digikam::TableViewModelItem".
122 {
123 }
124
125 QList<TableViewColumn*> columnObjects;
126 TableViewModelItem* rootItem;

/mnt/devel/GIT/3.x/core/digikam/views/tableview_model.cpp: 122 ( ctor_dtor_leak)
119 Private()
120 : columnObjects(),
121 rootItem(new TableViewModelItem())
>>> The constructor allocates field "rootItem" of "Digikam::TableViewModel::Private" but there is no destructor.
122 {
123 }
124
125 QList<TableViewColumn*> columnObjects;
126 TableViewModelItem* rootItem;

________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan5.coverity.com:8080

If you don't have a username, you can request one by emailing: [hidden email]

To unsubscribe from the email notification for new defects, http://scan.coverity.com/email_unsubscribe.html
If you are project owner, you can subscribe your team member by accessing http://scan.coverity.com/email_subscription.html
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel