MetadataSelector merge request

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

MetadataSelector merge request

David Haslam

I've submitted my first merge request, some small tweaks to the metadata configuration dialog. They are very small, as I want to establish my workflow before doing anything bigger. I'm looking forward to some feedback.

As I am getting more familiar with the code I have ideas about improving the metadata presentation. If someone else is planning any major work in this area, let me know and I'll hold off for now.

Thanks,

-- 
David
Reply | Threaded
Open this post in threaded view
|

Re: MetadataSelector merge request

Gilles Caulier-4
Hi,

I reviewed and tested your patch and all is fine for me.

Gitlab sounds like down for the moment, I cannot push your PR. I will
try again later

Gilles Caulier

Le ven. 18 déc. 2020 à 14:19, David Haslam <[hidden email]> a écrit :
>
> I've submitted my first merge request, some small tweaks to the metadata configuration dialog. They are very small, as I want to establish my workflow before doing anything bigger. I'm looking forward to some feedback.
>
> As I am getting more familiar with the code I have ideas about improving the metadata presentation. If someone else is planning any major work in this area, let me know and I'll hold off for now.
>
> Thanks,
>
> --
> David
Reply | Threaded
Open this post in threaded view
|

Re: MetadataSelector merge request

Gilles Caulier-4
Done :

>Merge Request !39 was merged

Gilles Caulier

Le ven. 18 déc. 2020 à 16:31, Gilles Caulier
<[hidden email]> a écrit :

>
> Hi,
>
> I reviewed and tested your patch and all is fine for me.
>
> Gitlab sounds like down for the moment, I cannot push your PR. I will
> try again later
>
> Gilles Caulier
>
> Le ven. 18 déc. 2020 à 14:19, David Haslam <[hidden email]> a écrit :
> >
> > I've submitted my first merge request, some small tweaks to the metadata configuration dialog. They are very small, as I want to establish my workflow before doing anything bigger. I'm looking forward to some feedback.
> >
> > As I am getting more familiar with the code I have ideas about improving the metadata presentation. If someone else is planning any major work in this area, let me know and I'll hold off for now.
> >
> > Thanks,
> >
> > --
> > David
Reply | Threaded
Open this post in threaded view
|

Re: MetadataSelector merge request

David Haslam

Nice, thanks!

On 18/12/2020 16:48, Gilles Caulier wrote:
Done :

Merge Request !39 was merged
Gilles Caulier

Le ven. 18 déc. 2020 à 16:31, Gilles Caulier
[hidden email] a écrit :
Hi,

I reviewed and tested your patch and all is fine for me.

Gitlab sounds like down for the moment, I cannot push your PR. I will
try again later

Gilles Caulier

Le ven. 18 déc. 2020 à 14:19, David Haslam [hidden email] a écrit :
I've submitted my first merge request, some small tweaks to the metadata configuration dialog. They are very small, as I want to establish my workflow before doing anything bigger. I'm looking forward to some feedback.

As I am getting more familiar with the code I have ideas about improving the metadata presentation. If someone else is planning any major work in this area, let me know and I'll hold off for now.

Thanks,

--
David
-- 
David