Lensfun lib
Locked
 
|
Hi
I updated my OS to Kubuntu 13.04, and it had an updated version of liblensfun. Digikam requires 0.2.6, and the repository had 0.2.7. While it doesn't give a cmake error, it gets stuck during compilation. So I wanted to ask, do we have forward compatibility with lensfun or not? If not, we should really look into that. Or is it something that I am doing wrong?
Smit Mehta Junior year, B.Tech Computer Science and Engineering IIT Madras +91-9884996531 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
I can confirm that digikam won't compile with lensfun 0.2.7 On Mon, Jul 15, 2013 at 2:58 PM, smit <[hidden email]> wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
I will dig into the code and see if I can make the necessary changes.
On Mon, Jul 15, 2013 at 12:13 PM, Veaceslav Munteanu <[hidden email]> wrote:
Smit Mehta Junior year, B.Tech Computer Science and Engineering IIT Madras +91-9884996531 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
@Gilles, what is your opinion? What is the best way to support both of the libraries? Should I use cmake flags? Or should we shift our minimum requirement to 0.2.7?
On Mon, Jul 15, 2013 at 12:18 PM, smit <[hidden email]> wrote:
Smit Mehta Junior year, B.Tech Computer Science and Engineering IIT Madras +91-9884996531 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
Hi all,
This depend of level of API break. If it's not too hard, pre-compiler rules must be enough. For that, of course, lensfun must provide a version flag somewhere to be able to construct rules easily. We already do it with KDELibs for ex, libkdcraw, Exiv2, etc... If API are completely broken (as it make a big puzzle to plug rules in code), fixing lensfun dependency to 0.2.7 is fine for me for next release 3.3.0 Thanks to review this problem. Gilles 2013/7/15 smit <[hidden email]>: > @Gilles, what is your opinion? What is the best way to support both of the > libraries? Should I use cmake flags? Or should we shift our minimum > requirement to 0.2.7? > > > On Mon, Jul 15, 2013 at 12:18 PM, smit <[hidden email]> wrote: >> >> I will dig into the code and see if I can make the necessary changes. >> >> >> On Mon, Jul 15, 2013 at 12:13 PM, Veaceslav Munteanu >> <[hidden email]> wrote: >>> >>> I can confirm that digikam won't compile with lensfun 0.2.7 >>> >>> >>> On Mon, Jul 15, 2013 at 2:58 PM, smit <[hidden email]> wrote: >>>> >>>> Hi >>>> >>>> I updated my OS to Kubuntu 13.04, and it had an updated version of >>>> liblensfun. Digikam requires 0.2.6, and the repository had 0.2.7. While it >>>> doesn't give a cmake error, it gets stuck during compilation. So I wanted to >>>> ask, do we have forward compatibility with lensfun or not? If not, we should >>>> really look into that. Or is it something that I am doing wrong? >>>> >>>> -- >>>> Smit Mehta >>>> Junior year, B.Tech >>>> Computer Science and Engineering >>>> IIT Madras >>>> +91-9884996531 >>>> >>>> _______________________________________________ >>>> Digikam-devel mailing list >>>> [hidden email] >>>> https://mail.kde.org/mailman/listinfo/digikam-devel >>>> >>> >>> >>> _______________________________________________ >>> Digikam-devel mailing list >>> [hidden email] >>> https://mail.kde.org/mailman/listinfo/digikam-devel >>> >> >> >> >> -- >> Smit Mehta >> Junior year, B.Tech >> Computer Science and Engineering >> IIT Madras >> +91-9884996531 > > > > > -- > Smit Mehta > Junior year, B.Tech > Computer Science and Engineering > IIT Madras > +91-9884996531 > > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel > Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
Hi all,
digiKam compile, link, and run fine on my computer. No problem detected. If it fails on your computer, it's not digiKam or lensfun fault, but perhaps a 3rd party system library... See details here : https://bugs.kde.org/show_bug.cgi?id=323284 Gilles Caulier 2013/7/16 Gilles Caulier <[hidden email]>: > Hi all, > > This depend of level of API break. If it's not too hard, pre-compiler > rules must be enough. > > For that, of course, lensfun must provide a version flag somewhere to > be able to construct rules easily. We already do it with KDELibs for > ex, libkdcraw, Exiv2, etc... > > If API are completely broken (as it make a big puzzle to plug rules in > code), fixing lensfun dependency to 0.2.7 is fine for me for next > release 3.3.0 > > Thanks to review this problem. > > Gilles > > > > 2013/7/15 smit <[hidden email]>: >> @Gilles, what is your opinion? What is the best way to support both of the >> libraries? Should I use cmake flags? Or should we shift our minimum >> requirement to 0.2.7? >> >> >> On Mon, Jul 15, 2013 at 12:18 PM, smit <[hidden email]> wrote: >>> >>> I will dig into the code and see if I can make the necessary changes. >>> >>> >>> On Mon, Jul 15, 2013 at 12:13 PM, Veaceslav Munteanu >>> <[hidden email]> wrote: >>>> >>>> I can confirm that digikam won't compile with lensfun 0.2.7 >>>> >>>> >>>> On Mon, Jul 15, 2013 at 2:58 PM, smit <[hidden email]> wrote: >>>>> >>>>> Hi >>>>> >>>>> I updated my OS to Kubuntu 13.04, and it had an updated version of >>>>> liblensfun. Digikam requires 0.2.6, and the repository had 0.2.7. While it >>>>> doesn't give a cmake error, it gets stuck during compilation. So I wanted to >>>>> ask, do we have forward compatibility with lensfun or not? If not, we should >>>>> really look into that. Or is it something that I am doing wrong? >>>>> >>>>> -- >>>>> Smit Mehta >>>>> Junior year, B.Tech >>>>> Computer Science and Engineering >>>>> IIT Madras >>>>> +91-9884996531 >>>>> >>>>> _______________________________________________ >>>>> Digikam-devel mailing list >>>>> [hidden email] >>>>> https://mail.kde.org/mailman/listinfo/digikam-devel >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Digikam-devel mailing list >>>> [hidden email] >>>> https://mail.kde.org/mailman/listinfo/digikam-devel >>>> >>> >>> >>> >>> -- >>> Smit Mehta >>> Junior year, B.Tech >>> Computer Science and Engineering >>> IIT Madras >>> +91-9884996531 >> >> >> >> >> -- >> Smit Mehta >> Junior year, B.Tech >> Computer Science and Engineering >> IIT Madras >> +91-9884996531 >> >> _______________________________________________ >> Digikam-devel mailing list >> [hidden email] >> https://mail.kde.org/mailman/listinfo/digikam-devel >> Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
«
Return to digikam-devel
|
1 view|%1 views
| Free forum by Nabble | Edit this page |