ImportContextMenuHelper vs ContextMenuHelper?

[Andi Clemens-2]

Hi,

what is the purpose of the ImportContextMenuHelper? Right now it seems to  
be a copy of the ContextMenuHelper, maybe with a slight variation.

Wouldn't it make more sense if it was derived from ContextMenuHelper and  
just overwrites the methods it needs to change?

I got a warning of my static code analysis tool chain about (massive) code  
duplication...

Andi


--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Andi,

I come from Import tool no ? Ask to Islam, he has written this code...

Gilles

2012/10/9 Andi Clemens <[hidden email]>:

> Hi,
>
> what is the purpose of the ImportContextMenuHelper? Right now it seems to be
> a copy of the ContextMenuHelper, maybe with a slight variation.
>
> Wouldn't it make more sense if it was derived from ContextMenuHelper and
> just overwrites the methods it needs to change?
>
> I got a warning of my static code analysis tool chain about (massive) code
> duplication...
>
> Andi
>
>
> --
> Using Opera's revolutionary email client: http://www.opera.com/mail/
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

Hi Andi,

ImportContextMenuHelper differs from ContextMenuHelper in implementation as for example ContextMenuHelper deals with ImageInfos, and AlbumModels, which is not used in ImportUI. You can describe ImportContextMenuHelper as the customized version of ContextMenuHelper for ImportUI. Please if you have a better way for implementing it, suggest it to me and I will do it ASAP.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel