Import ignoring naming pattern

[Daan Wynen]

Hi all,
I am currently running the git master of digikam.
I usually use a date/time naming pttern for my pictures, i.e. [date:yyyy-MM-dd_hh-mm-ss]_[file].[ext] which is pretty verbose but works for me.
Now since switching to 3.0.0 rc and then git this pattern seems to be completely ignored, digikam just uses the original camera filenames.
Date-based sub-folder creation seems to work though, based on the mtime of the pictures (which is why I had a look through the code in the first place).
is this just me missing something obvious?

Thanks for your time
Daan

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Hi all,
> I am currently running the git master of digikam.
> I usually use a date/time naming pttern for my pictures, i.e.
> [date:yyyy-MM-dd_hh-mm-ss]_[file].[ext] which is pretty verbose but
> works for me.
> Now since switching to 3.0.0 rc and then git this pattern seems to be
> completely ignored, digikam just uses the original camera filenames.
> Date-based sub-folder creation seems to work though, based on the mtime
> of the pictures (which is why I had a look through the code in the first
> place).
> is this just me missing something obvious?

No, it's a known regression.
This is bug 307253.
I hope Andi can give us some help, at least telling us what renaming code
should be used.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens-2]

Since I have not changed anything in the renaming code (and it still works  
for me), I don't know what is wrong here.
Can you provide a test-image for further investigation?

Andi

On Mon, 31 Dec 2012 13:42:55 +0100, Marcel Wiesweg <[hidden email]>  
wrote:

>
>> Hi all,
>> I am currently running the git master of digikam.
>> I usually use a date/time naming pttern for my pictures, i.e.
>> [date:yyyy-MM-dd_hh-mm-ss]_[file].[ext] which is pretty verbose but
>> works for me.
>> Now since switching to 3.0.0 rc and then git this pattern seems to be
>> completely ignored, digikam just uses the original camera filenames.
>> Date-based sub-folder creation seems to work though, based on the mtime
>> of the pictures (which is why I had a look through the code in the first
>> place).
>> is this just me missing something obvious?
>
> No, it's a known regression.
> This is bug 307253.
> I hope Andi can give us some help, at least telling us what renaming code
> should be used.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens-2]

Oh I didn't see you are importing... you are right, for importing it  
doesn't seem to work anymore, as described in the bug 307253.

Andi

On Mon, 31 Dec 2012 13:42:55 +0100, Marcel Wiesweg <[hidden email]>  
wrote:

>
>> Hi all,
>> I am currently running the git master of digikam.
>> I usually use a date/time naming pttern for my pictures, i.e.
>> [date:yyyy-MM-dd_hh-mm-ss]_[file].[ext] which is pretty verbose but
>> works for me.
>> Now since switching to 3.0.0 rc and then git this pattern seems to be
>> completely ignored, digikam just uses the original camera filenames.
>> Date-based sub-folder creation seems to work though, based on the mtime
>> of the pictures (which is why I had a look through the code in the first
>> place).
>> is this just me missing something obvious?
>
> No, it's a known regression.
> This is bug 307253.
> I hope Andi can give us some help, at least telling us what renaming code
> should be used.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Oh I didn't see you are importing... you are right, for importing it
> doesn't seem to work anymore, as described in the bug 307253.

The problem is in utilities/importui/main/importui.cpp around line 1687.
In older times, item.downloadname contained the adjusted file name, but that
does not work any more, and is dirty. We should generate the name freshly.
"renameCustomizer" sounds like a tempting source to retrieve the name.

If the "CamItemInfo", which its including PhotoInfoContainer, provides enough
information to compute the new name, then it's the best and cleanest solution
at this place.
If we need the full file, then there is slotDownloaded further down.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Daan Wynen]

Actually, we would need access to at least the EXIF parts of the file to
also handle things like Bug 282728.
If the importing/renaming part has to be rewritten anyway it should
include that.
Is slotDownloaded called after copying the file or before?

> If the "CamItemInfo", which its including PhotoInfoContainer, provides enough
> information to compute the new name, then it's the best and cleanest solution
> at this place.
> If we need the full file, then there is slotDownloaded further down.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel