Hotplug and DCOP interface

[Leonid Zeitlin]

Hello DigiKam developers,
First of all, thank you for the great application. I've been looking into
using DigiKam with hotplug, to automatically start DigiKam when my camera
is connected. The instructions on the web site were quite useful, and I
quickly had it working. One thing that I've found somewhat inconvenient is
that if I connect my camera when DigiKam is already running, a second
instance of the application is started. It would be nice if the hotplug
script could send a DCOP call to a running instance of DigiKam to show the
camera dialog. Unfortunately, I've found out that DigiKam exports no such
interface.

So I created a quick patch that adds a DCOP interface to DigiKam. Right now
it has only one method, cameraAutoDetect to show the camera dialog. I also
created a modified digikam-hotplug script to take advantage of the new DCOP
call. I'd like to share the patch and the script with the developer
community in hopes that you could find it useful. I don't claim that what I
implemented is the best and optimal solution to the hotplug issue, but I
think a DCOP interface might come handy in many situations. Any feedback is
welcome.

Thanks a lot,
  Leonid
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Samedi 10 Décembre 2005 17:08, Leonid Zeitlin a écrit :

> Hello DigiKam developers,
> First of all, thank you for the great application. I've been looking into
> using DigiKam with hotplug, to automatically start DigiKam when my camera
> is connected. The instructions on the web site were quite useful, and I
> quickly had it working. One thing that I've found somewhat inconvenient is
> that if I connect my camera when DigiKam is already running, a second
> instance of the application is started. It would be nice if the hotplug
> script could send a DCOP call to a running instance of DigiKam to show the
> camera dialog. Unfortunately, I've found out that DigiKam exports no such
> interface.
>
> So I created a quick patch that adds a DCOP interface to DigiKam. Right now
> it has only one method, cameraAutoDetect to show the camera dialog. I also
> created a modified digikam-hotplug script to take advantage of the new DCOP
> call. I'd like to share the patch and the script with the developer
> community in hopes that you could find it useful. I don't claim that what I
> implemented is the best and optimal solution to the hotplug issue, but I
> think a DCOP interface might come handy in many situations. Any feedback is
> welcome.
>
> Thanks a lot,

In first, thanks Leonid to your digiKam interrest. your DCOP interface is
interressing and i will take a look about your implementation.

I need any feedback about other developpers/users to use it with any cameras.
Please let's me hear your viewpoints...

Oliver, can you take a look about the hotplug script modifications ?

Thanks in advance
--
Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Oliver Dörr]

Hi Gilles,

i don't have the time to check that week. But next Saturday i have x-mas holiday and so i will look at the script next weekend.

Oliver

Gilles Caulier wrote:

Le Samedi 10 Décembre 2005 17:08, Leonid Zeitlin a écrit :
  

Hello DigiKam developers,
First of all, thank you for the great application. I've been looking into
using DigiKam with hotplug, to automatically start DigiKam when my camera
is connected. The instructions on the web site were quite useful, and I
quickly had it working. One thing that I've found somewhat inconvenient is
that if I connect my camera when DigiKam is already running, a second
instance of the application is started. It would be nice if the hotplug
script could send a DCOP call to a running instance of DigiKam to show the
camera dialog. Unfortunately, I've found out that DigiKam exports no such
interface.

So I created a quick patch that adds a DCOP interface to DigiKam. Right now
it has only one method, cameraAutoDetect to show the camera dialog. I also
created a modified digikam-hotplug script to take advantage of the new DCOP
call. I'd like to share the patch and the script with the developer
community in hopes that you could find it useful. I don't claim that what I
implemented is the best and optimal solution to the hotplug issue, but I
think a DCOP interface might come handy in many situations. Any feedback is
welcome.

Thanks a lot,
    

In first, thanks Leonid to your digiKam interrest. your DCOP interface is 
interressing and i will take a look about your implementation.

I need any feedback about other developpers/users to use it with any cameras. 
Please let's me hear your viewpoints...

Oliver, can you take a look about the hotplug script modifications ?

Thanks in advance
  

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Op zaterdag 10 december 2005 18:43, schreef Gilles Caulier:

> Le Samedi 10 Décembre 2005 17:08, Leonid Zeitlin a écrit :
> > Hello DigiKam developers,
> > First of all, thank you for the great application. I've been looking into
> > using DigiKam with hotplug, to automatically start DigiKam when my camera
> > is connected. The instructions on the web site were quite useful, and I
> > quickly had it working. One thing that I've found somewhat inconvenient
> > is that if I connect my camera when DigiKam is already running, a second
> > instance of the application is started. It would be nice if the hotplug
> > script could send a DCOP call to a running instance of DigiKam to show
> > the camera dialog. Unfortunately, I've found out that DigiKam exports no
> > such interface.
> >
> > So I created a quick patch that adds a DCOP interface to DigiKam. Right
> > now it has only one method, cameraAutoDetect to show the camera dialog. I
> > also created a modified digikam-hotplug script to take advantage of the
> > new DCOP call. I'd like to share the patch and the script with the
> > developer community in hopes that you could find it useful. I don't claim
> > that what I implemented is the best and optimal solution to the hotplug
> > issue, but I think a DCOP interface might come handy in many situations.
> > Any feedback is welcome.
> >
> > Thanks a lot,
>
> In first, thanks Leonid to your digiKam interrest. your DCOP interface is
> interressing and i will take a look about your implementation.
>
> I need any feedback about other developpers/users to use it with any
> cameras. Please let's me hear your viewpoints...

I dont have objections, only nitpicks: copyright can not been given to a team,
it must be set to the original author. There is no license, we put it in
every file. There are no apidox comments, they are mandatory for new code, in
the new files our hacking style is not applied and I would have called it
dcopiface instead of digikamiface.

If some users can test it, I think we can put it in 0.8.1 as well.

Tom

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

Tom Albers wrote:

>
> I dont have objections, only nitpicks: copyright can not been given to a
> team, it must be set to the original author. There is no license, we put
> it in every file. There are no apidox comments, they are mandatory for new
> code, in the new files our hacking style is not applied and I would have
> called it dcopiface instead of digikamiface.
>
> If some users can test it, I think we can put it in 0.8.1 as well.
>
> Tom

Hi Tom,
I'd be glad to take care of the "nitpicks" you mention. I'll post an updated
patch soon.

Thanks,
   Leonid

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonid Zeitlin]

Leonid Zeitlin wrote:

> Tom Albers wrote:
>
>>
>> I dont have objections, only nitpicks: copyright can not been given to a
>> team, it must be set to the original author. There is no license, we put
>> it in every file. There are no apidox comments, they are mandatory for
>> new code, in the new files our hacking style is not applied and I would
>> have called it dcopiface instead of digikamiface.
>>
>> If some users can test it, I think we can put it in 0.8.1 as well.
>>
>> Tom
>
> Hi Tom,
> I'd be glad to take care of the "nitpicks" you mention. I'll post an
> updated patch soon.

Hi all,
I am attaching an updated patch and hotplug script, where I tried to address
the issues pointed out by Tom.  

Thanks,
   Leonid

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Op zaterdag 17 december 2005 17:57, schreef Leonid Zeitlin:

> Leonid Zeitlin wrote:
> > Tom Albers wrote:
> >> I dont have objections, only nitpicks: copyright can not been given to a
> >> team, it must be set to the original author. There is no license, we put
> >> it in every file. There are no apidox comments, they are mandatory for
> >> new code, in the new files our hacking style is not applied and I would
> >> have called it dcopiface instead of digikamiface.
> >>
> >> If some users can test it, I think we can put it in 0.8.1 as well.
> >>
> >> Tom
> >
> > Hi Tom,
> > I'd be glad to take care of the "nitpicks" you mention. I'll post an
> > updated patch soon.
>
> Hi all,
> I am attaching an updated patch and hotplug script, where I tried to
> address the issues pointed out by Tom.
>
> Thanks,
>    Leonid

Thanks a lot for your contribution. I have comitted it to svn. 0.8.1 will
contain this dcop routine.

Tom

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Monday 19 December 2005 01:08, Tom Albers wrote:

> Op zaterdag 17 december 2005 17:57, schreef Leonid Zeitlin:
> > Leonid Zeitlin wrote:
> > > Tom Albers wrote:
> > >> I dont have objections, only nitpicks: copyright can not been given to a
> > >> team, it must be set to the original author. There is no license, we put
> > >> it in every file. There are no apidox comments, they are mandatory for
> > >> new code, in the new files our hacking style is not applied and I would
> > >> have called it dcopiface instead of digikamiface.
> > >>
> > >> If some users can test it, I think we can put it in 0.8.1 as well.
> > >>
> > >> Tom
> > >
> > > Hi Tom,
> > > I'd be glad to take care of the "nitpicks" you mention. I'll post an
> > > updated patch soon.
> >
> > Hi all,
> > I am attaching an updated patch and hotplug script, where I tried to
> > address the issues pointed out by Tom.

I had a look at it. Only nitpick:  DCOPIfce is an ugly name.  How about
renaming it to camera?

        dcop digikam-<pid> camera autoDetect
                                  openCamera "Model" # TODO
                                  openDirectory /mount/point/ # TODO
                                  closeDialog # TODO
                                  reopen # TODO (for ossi bug)
                                 
Achim
> >
> > Thanks,
> >    Leonid
>
> Thanks a lot for your contribution. I have comitted it to svn. 0.8.1 will
> contain this dcop routine.
>
> Tom
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> I had a look at it. Only nitpick:  DCOPIfce is an ugly name.
> How about renaming it to camera?
>
> dcop digikam-<pid> camera autoDetect
>  openCamera "Model" # TODO
>  openDirectory /mount/point/ # TODO

Me wonders, why is this mounting stuff so hard with digiKam? I
mean, KDE supports HAL, media-kioslave and has auto-mounting
on demand. Why can we not simply use "media:/" for usb-storge
devices, when this has a dcim folder in its path?

Bye

  Thorsten

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Op woensdag 4 januari 2006 08:50, schreef Thorsten Schnebeck:

> > I had a look at it. Only nitpick:  DCOPIfce is an ugly name.
> > How about renaming it to camera?
> >
> > dcop digikam-<pid> camera autoDetect
> >  openCamera "Model" # TODO
> >  openDirectory /mount/point/ # TODO
>
> Me wonders, why is this mounting stuff so hard with digiKam? I
> mean, KDE supports HAL, media-kioslave and has auto-mounting
> on demand. Why can we not simply use "media:/" for usb-storge
> devices, when this has a dcim folder in its path?

Because media is async, and QDir does not support media:/ ;-)

A service menu can do the mounting and Im now working on a patch to support
digikam --download-from /bla/bli/blo which will open camera dialog at that
position. At least for kde 3.5 that would solve the problem for ums,
--autodetect would tacle gphoto thingies.

Achim is preparing the service menu and Im working on the patch for the new
parameter.

Toma

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Am Mittwoch 04 Januar 2006 19:46 schrieb Tom Albers:
> Because media is async, and QDir does not support media:/ ;-)
>
> A service menu can do the mounting and Im now working on a patch to support
> digikam --download-from /bla/bli/blo which will open camera dialog at that
> position. At least for kde 3.5 that would solve the problem for ums,
> --autodetect would tacle gphoto thingies.

OK, I think I understand the problem.
What is the recommended workflow, if you have more than one device connected?
By now I have 6 "cameras" defined and often 3 connected. Cause sometimes HAL
create a different mountpoint in "/media" I have to readjust the montpoint in
digiKams camera config dialog. Is it a problem for the database if digiKam
starts with e.g. 3 instances?

Anyway, this new Solid-thing sound interesting. Maybe its possible to focus
digiKams needs later in its API conception-phase.

Thanks

  Thorsten


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel