Git migration for 2.0.0 + code components re-structuring...

[Gilles Caulier-4]

Gert,

please, forget kdereview, and use digiKam soft collection from branch
(which will be migrated to git later). I just fixed it :

http://websvn.kde.org/branches/extragear/graphics/digikam/

Gilles

2010/12/14 Gert Kello <[hidden email]>:

>> I had these problems before fixing the the FindXXX.cmake files when
>> libkexiv2 was already installed. Maybe you could update to the latest
>> version, where I fixed the FindKexiv2 and FindKipi files. You may want
>> to clear the CMakeCache.txt file to make sure all libraries are found
>> properly.
>
> Yes, latest version did work fine.
>
> Just this OpenCV problems:
> 1. FindOpenCV.cmake included with libkface is not able to find it. If
> I delete it then OpenCV is found
> 2. I have to make a little modification to
> Index: libkface/libkface/CMakeLists.txt
> ===================================================================
> --- kdereview/libkface/libkface/CMakeLists.txt  (revision 1202545)
> +++ kdereview/libkface/libkface/CMakeLists.txt  (working copy)
> @@ -49,7 +49,7 @@
>                             ${KDE4_KDEUI_LIBS}
>                             ${QT_QTGUI_LIBRARY}
>                             ${LIBFACE_LIBRARIES}
> -                            ${OpenCV_LIBRARIES}
> +                            ${OpenCV_LIBS}
>                             )
>
>  SET_TARGET_PROPERTIES(kface PROPERTIES VERSION ${KFACE_LIB_SO_VERSION_STRING}
>
> 3. kipi-plugins is not able to find OpenCV.
>
> Gert
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On 14 December 2010 14:51, Gilles Caulier <[hidden email]> wrote:
> Gert,
>
> please, forget kdereview, and use digiKam soft collection from branch
> (which will be migrated to git later). I just fixed it :
>
> http://websvn.kde.org/branches/extragear/graphics/digikam/
>

Sorry, the patch was from days when it was still in kdereview. Yes,
I'm using the one in branch.

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

There is no reason to apply it since opencv detection is the same
between libkface and kipi-plugins... Or i missunderstand something ?

Do you have updated today ? I commited a lots this morning...

Gilles

2010/12/14 Gert Kello <[hidden email]>:

> On 14 December 2010 14:51, Gilles Caulier <[hidden email]> wrote:
>> Gert,
>>
>> please, forget kdereview, and use digiKam soft collection from branch
>> (which will be migrated to git later). I just fixed it :
>>
>> http://websvn.kde.org/branches/extragear/graphics/digikam/
>>
>
> Sorry, the patch was from days when it was still in kdereview. Yes,
> I'm using the one in branch.
>
> Gert
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> There is no reason to apply it since opencv detection is the same
> between libkface and kipi-plugins... Or i missunderstand something ?
>
> Do you have updated today ? I commited a lots this morning...

Yes I updated today. (I have build script to make svn update before
make... Was nice when the parts were spread out between different
locations)

I'm using the anon svn so the latest commits might not yet be in...
AFAIK the mirroring takes some time. At moment it is

c:\KdeDevel\GoSC2010>svn up
At revision 1206453.

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

hum, remove the camke cache and re-run config from scratch.

Gilles

2010/12/14 Gert Kello <[hidden email]>:

>> There is no reason to apply it since opencv detection is the same
>> between libkface and kipi-plugins... Or i missunderstand something ?
>>
>> Do you have updated today ? I commited a lots this morning...
>
> Yes I updated today. (I have build script to make svn update before
> make... Was nice when the parts were spread out between different
> locations)
>
> I'm using the anon svn so the latest commits might not yet be in...
> AFAIK the mirroring takes some time. At moment it is
>
> c:\KdeDevel\GoSC2010>svn up
> At revision 1206453.
>
> Gert
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On 14 December 2010 15:15, Gilles Caulier <[hidden email]> wrote:
> hum, remove the camke cache and re-run config from scratch.

I deleted the whole build folder:

Build C:\KdeDevel\GoSC2010
At revision 1206455.
-- The C compiler identification is GNU
-- The CXX compiler identification is GNU
-- Check for working C compiler: c:/MinGW32/bin/gcc.exe
-- Check for working C compiler: c:/MinGW32/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: c:/MinGW32/bin/g++.exe
-- Check for working CXX compiler: c:/MinGW32/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - not found.
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found.
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found.
-- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
-- Found Automoc4: C:/KDE/bin/automoc4.exe
-- Could NOT find Perl (missing:  PERL_EXECUTABLE)
-- Perl not found
-- Phonon Version: 4.3.80
-- Found Phonon: c:/KDE/lib/libphonon.dll.a
-- Found Phonon Includes: c:/KDE/include/KDE;c:/KDE/include
-- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
-- Performing Test HAVE_FPIE_SUPPORT
-- Performing Test HAVE_FPIE_SUPPORT - Success
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test __KDE_HAVE_GCC_VISIBILITY
-- Performing Test __KDE_HAVE_GCC_VISIBILITY - Success
-- Found KDE 4.4 include dir: c:/KDE/include
-- Found KDE 4.4 library dir: c:/KDE/lib
-- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
-- Found automoc4: C:/KDE/bin/automoc4.exe
-- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
-- Could NOT find Perl (missing:  PERL_EXECUTABLE)
-- Perl not found
-- Phonon Version: 4.3.80
-- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
-- Found KDE 4.4 include dir: c:/KDE/include
-- Found KDE 4.4 library dir: c:/KDE/lib
-- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
-- Found automoc4: C:/KDE/bin/automoc4.exe
-- Found Exiv2: c:/KDE/lib/libexiv2.dll.a
-- ----------------------------------------------------------------------------------
-- Starting CMake configuration for: libkdcraw
-- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
-- Could NOT find Perl (missing:  PERL_EXECUTABLE)
-- Perl not found
-- Phonon Version: 4.3.80
-- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
-- Found KDE 4.4 include dir: c:/KDE/include
-- Found KDE 4.4 library dir: c:/KDE/lib
-- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
-- Found automoc4: C:/KDE/bin/automoc4.exe
-- Found lcms version 1.18, c:/KDE/lib/liblcms-1.dll.a
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp
-- ----------------------------------------------------------------------------------
-- Starting CMake configuration for: libkface
-- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
-- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
-- Could NOT find Perl (missing:  PERL_EXECUTABLE)
-- Perl not found
-- Phonon Version: 4.3.80
-- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
-- Found KDE 4.4 include dir: c:/KDE/include
-- Found KDE 4.4 library dir: c:/KDE/lib
-- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
-- Found automoc4: C:/KDE/bin/automoc4.exe
-- Checking GNUCXX version 3/4 to determine  OpenCV /opt/net/ path
CMake Error at extra/libkface/cmake/modules/FindOpenCV.cmake:238 (MESSAGE):
  OpenCV required but some headers or libs not found.  Please specify it's
  location with OpenCV_ROOT_DIR env.  variable.
Call Stack (most recent call first):
  extra/libkface/CMakeLists.txt:48 (FIND_PACKAGE)


-- Configuring incomplete, errors occurred!
make: *** No targets specified and no makefile found.  Stop.
Build aborted
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

in the cmake command line call, pass -DOpenCV_ROOT_DIR=... with you
opencv install path

Gilles

2010/12/14 Gert Kello <[hidden email]>:

> On 14 December 2010 15:15, Gilles Caulier <[hidden email]> wrote:
>> hum, remove the camke cache and re-run config from scratch.
>
> I deleted the whole build folder:
>
> Build C:\KdeDevel\GoSC2010
> At revision 1206455.
> -- The C compiler identification is GNU
> -- The CXX compiler identification is GNU
> -- Check for working C compiler: c:/MinGW32/bin/gcc.exe
> -- Check for working C compiler: c:/MinGW32/bin/gcc.exe -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Check for working CXX compiler: c:/MinGW32/bin/g++.exe
> -- Check for working CXX compiler: c:/MinGW32/bin/g++.exe -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Looking for Q_WS_X11
> -- Looking for Q_WS_X11 - not found.
> -- Looking for Q_WS_WIN
> -- Looking for Q_WS_WIN - found
> -- Looking for Q_WS_QWS
> -- Looking for Q_WS_QWS - not found.
> -- Looking for Q_WS_MAC
> -- Looking for Q_WS_MAC - not found.
> -- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
> -- Found Automoc4: C:/KDE/bin/automoc4.exe
> -- Could NOT find Perl (missing:  PERL_EXECUTABLE)
> -- Perl not found
> -- Phonon Version: 4.3.80
> -- Found Phonon: c:/KDE/lib/libphonon.dll.a
> -- Found Phonon Includes: c:/KDE/include/KDE;c:/KDE/include
> -- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
> -- Performing Test HAVE_FPIE_SUPPORT
> -- Performing Test HAVE_FPIE_SUPPORT - Success
> -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
> -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
> -- Performing Test __KDE_HAVE_GCC_VISIBILITY
> -- Performing Test __KDE_HAVE_GCC_VISIBILITY - Success
> -- Found KDE 4.4 include dir: c:/KDE/include
> -- Found KDE 4.4 library dir: c:/KDE/lib
> -- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
> -- Found automoc4: C:/KDE/bin/automoc4.exe
> -- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
> -- Could NOT find Perl (missing:  PERL_EXECUTABLE)
> -- Perl not found
> -- Phonon Version: 4.3.80
> -- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
> -- Found KDE 4.4 include dir: c:/KDE/include
> -- Found KDE 4.4 library dir: c:/KDE/lib
> -- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
> -- Found automoc4: C:/KDE/bin/automoc4.exe
> -- Found Exiv2: c:/KDE/lib/libexiv2.dll.a
> -- ----------------------------------------------------------------------------------
> -- Starting CMake configuration for: libkdcraw
> -- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
> -- Could NOT find Perl (missing:  PERL_EXECUTABLE)
> -- Perl not found
> -- Phonon Version: 4.3.80
> -- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
> -- Found KDE 4.4 include dir: c:/KDE/include
> -- Found KDE 4.4 library dir: c:/KDE/lib
> -- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
> -- Found automoc4: C:/KDE/bin/automoc4.exe
> -- Found lcms version 1.18, c:/KDE/lib/liblcms-1.dll.a
> -- Try OpenMP C flag = [-fopenmp]
> -- Performing Test OpenMP_FLAG_DETECTED
> -- Performing Test OpenMP_FLAG_DETECTED - Success
> -- Try OpenMP CXX flag = [-fopenmp]
> -- Performing Test OpenMP_FLAG_DETECTED
> -- Performing Test OpenMP_FLAG_DETECTED - Success
> -- Found OpenMP: -fopenmp
> -- ----------------------------------------------------------------------------------
> -- Starting CMake configuration for: libkface
> -- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
> -- Found Qt-Version 4.6.2 (using c:/KDE/bin/qmake.exe)
> -- Could NOT find Perl (missing:  PERL_EXECUTABLE)
> -- Perl not found
> -- Phonon Version: 4.3.80
> -- Found KDEWin library: c:/KDE/lib/libkdewin.dll.a
> -- Found KDE 4.4 include dir: c:/KDE/include
> -- Found KDE 4.4 library dir: c:/KDE/lib
> -- Found the KDE4 kconfig_compiler preprocessor: c:/KDE/bin/kconfig_compiler.exe
> -- Found automoc4: C:/KDE/bin/automoc4.exe
> -- Checking GNUCXX version 3/4 to determine  OpenCV /opt/net/ path
> CMake Error at extra/libkface/cmake/modules/FindOpenCV.cmake:238 (MESSAGE):
>  OpenCV required but some headers or libs not found.  Please specify it's
>  location with OpenCV_ROOT_DIR env.  variable.
> Call Stack (most recent call first):
>  extra/libkface/CMakeLists.txt:48 (FIND_PACKAGE)
>
>
> -- Configuring incomplete, errors occurred!
> make: *** No targets specified and no makefile found.  Stop.
> Build aborted
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On 14 December 2010 15:25, Gilles Caulier <[hidden email]> wrote:
> in the cmake command line call, pass -DOpenCV_ROOT_DIR=... with you
> opencv install path
>

Following ones did not work:
c:\KdeDevel\GoSC2010\build>cmake -G "MinGW Makefiles" ..
-DCMAKE_BUILD_TYPE=relwithdebinfo
-DCMAKE_INCLUDE_PATH=%KDE4_INSTALL_DIR%/include
-DCMAKE_LIBRARY_PATH=%KDE4_INSTALL_DIR%/lib
-DCMAKE_INSTALL_PREFIX=%KDE4_INSTALL_DIR%
-DOpenCV_ROOT_DIR=c:\KdeDevel\OpenCvTrunk\build

c:\KdeDevel\GoSC2010\build>cmake -G "MinGW Makefiles" ..
-DCMAKE_BUILD_TYPE=relwithdebinfo
-DCMAKE_INCLUDE_PATH=%KDE4_INSTALL_DIR%/include
-DCMAKE_LIBRARY_PATH=%KDE4_INSTALL_DIR%/lib
-DCMAKE_INSTALL_PREFIX=%KDE4_INSTALL_DIR%
-DOpenCV_ROOT_DIR=c:\KdeDevel\OpenCvTrunk

c:\KdeDevel\GoSC2010\build>cmake -G "MinGW Makefiles" ..
-DCMAKE_BUILD_TYPE=relwithdebinfo
-DCMAKE_INCLUDE_PATH=%KDE4_INSTALL_DIR%/include
-DCMAKE_LIBRARY_PATH=%KDE4_INSTALL_DIR%/lib
-DCMAKE_INSTALL_PREFIX=%KDE4_INSTALL_DIR% -DOpenCV_ROOT_DIR=c:\KDE

But after all I do not understand why it is arranged like that... If I
remove the findOpenCV.cmake then the OpenCV is found just fine. Only
that one file must be updated to use the variable that is defined by
OpenCV makers... And some files in kipi_plugins as well I think.

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Let's me try under my Win7 computer

Gilles

2010/12/14 Gert Kello <[hidden email]>:

> On 14 December 2010 15:25, Gilles Caulier <[hidden email]> wrote:
>> in the cmake command line call, pass -DOpenCV_ROOT_DIR=... with you
>> opencv install path
>>
>
> Following ones did not work:
> c:\KdeDevel\GoSC2010\build>cmake -G "MinGW Makefiles" ..
> -DCMAKE_BUILD_TYPE=relwithdebinfo
> -DCMAKE_INCLUDE_PATH=%KDE4_INSTALL_DIR%/include
> -DCMAKE_LIBRARY_PATH=%KDE4_INSTALL_DIR%/lib
> -DCMAKE_INSTALL_PREFIX=%KDE4_INSTALL_DIR%
> -DOpenCV_ROOT_DIR=c:\KdeDevel\OpenCvTrunk\build
>
> c:\KdeDevel\GoSC2010\build>cmake -G "MinGW Makefiles" ..
> -DCMAKE_BUILD_TYPE=relwithdebinfo
> -DCMAKE_INCLUDE_PATH=%KDE4_INSTALL_DIR%/include
> -DCMAKE_LIBRARY_PATH=%KDE4_INSTALL_DIR%/lib
> -DCMAKE_INSTALL_PREFIX=%KDE4_INSTALL_DIR%
> -DOpenCV_ROOT_DIR=c:\KdeDevel\OpenCvTrunk
>
> c:\KdeDevel\GoSC2010\build>cmake -G "MinGW Makefiles" ..
> -DCMAKE_BUILD_TYPE=relwithdebinfo
> -DCMAKE_INCLUDE_PATH=%KDE4_INSTALL_DIR%/include
> -DCMAKE_LIBRARY_PATH=%KDE4_INSTALL_DIR%/lib
> -DCMAKE_INSTALL_PREFIX=%KDE4_INSTALL_DIR% -DOpenCV_ROOT_DIR=c:\KDE
>
> But after all I do not understand why it is arranged like that... If I
> remove the findOpenCV.cmake then the OpenCV is found just fine. Only
> that one file must be updated to use the variable that is defined by
> OpenCV makers... And some files in kipi_plugins as well I think.
>
> Gert
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Meantime I applied the patch attached... Everything seems to go fine
until it starts to link digikam.. (see builderror.txt) Is it picking
up some old libraries from kde dir? (I can't make uninstall at moment
anymore, but I can make clean KDE install if You think it will help)
At least most of that seems to be unrelated to the changes made with
mu patch...

Gert

On 14 December 2010 15:39, Gilles Caulier <[hidden email]> wrote:
> Let's me try under my Win7 computer
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

For me compilation of 2.0.0beta stops here:


[ 14%] Building CXX object
extra/kipi-plugins/gpssync/CMakeFiles/kipiplugin_gpssync.dir/setup_general.cpp.o

[ 14%] Building CXX object
extra/kipi-plugins/gpssync/CMakeFiles/kipiplugin_gpssync.dir/borrowed/modeltest.cpp.o

[ 14%] Building CXX object
extra/kipi-plugins/gpssync/CMakeFiles/kipiplugin_gpssync.dir/backend-geonamesUS-rg.cpp.o

[ 14%] Building CXX object
extra/kipi-plugins/gpssync/CMakeFiles/kipiplugin_gpssync.dir/rgtagmodel.cpp.o

[ 14%] Building CXX object
extra/kipi-plugins/gpssync/CMakeFiles/kipiplugin_gpssync.dir/tests/simpletreemodel/simpletreemodel.cpp.o

Linking CXX shared module ../../../lib/kipiplugin_gpssync.so
CMakeFiles/kipiplugin_gpssync.dir/kipiimageitem.cpp.o: In function
`KIPIGPSSyncPlugin::KipiImageItem::getExiv2ForFile()':
/home/jnarboux/digikam_versions/2.0/graphics/digikam/extra/kipi-plugins/gpssync/kipiimageitem.cpp:149:
undefined reference to `KExiv2Iface::KExiv2::setUseXMPSidecar4Reading(bool)'
/home/jnarboux/digikam_versions/2.0/graphics/digikam/extra/kipi-plugins/gpssync/kipiimageitem.cpp:150:
undefined reference to `KExiv2Iface::KExiv2::setMetadataWritingMode(int)'
/home/jnarboux/digikam_versions/2.0/graphics/digikam/extra/kipi-plugins/gpssync/kipiimageitem.cpp:154:
undefined reference to `KExiv2Iface::KExiv2::setUseXMPSidecar4Reading(bool)'
/home/jnarboux/digikam_versions/2.0/graphics/digikam/extra/kipi-plugins/gpssync/kipiimageitem.cpp:155:
undefined reference to `KExiv2Iface::KExiv2::setMetadataWritingMode(int)'
CMakeFiles/kipiplugin_gpssync.dir/kipiimageitem.cpp.o: In function
`KIPIGPSSyncPlugin::KipiImageItem::saveChanges(bool, bool)':
/home/jnarboux/digikam_versions/2.0/graphics/digikam/extra/kipi-plugins/gpssync/kipiimageitem.cpp:724:
undefined reference to `KExiv2Iface::KExiv2::setGPSInfo(double, double,
double, bool)'
/home/jnarboux/digikam_versions/2.0/graphics/digikam/extra/kipi-plugins/gpssync/kipiimageitem.cpp:780:
undefined reference to `KExiv2Iface::KExiv2::removeGPSInfo(bool)'
collect2: ld returned 1 exit status
make[2]: *** [lib/kipiplugin_gpssync.so] Erreur 1
make[1]: ***
[extra/kipi-plugins/gpssync/CMakeFiles/kipiplugin_gpssync.dir/all] Erreur 2
make: *** [all] Erreur 2


Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

On 12/14/2010 01:48 PM, Gert Kello wrote:

>> I had these problems before fixing the the FindXXX.cmake files when
>> libkexiv2 was already installed. Maybe you could update to the latest
>> version, where I fixed the FindKexiv2 and FindKipi files. You may want
>> to clear the CMakeCache.txt file to make sure all libraries are found
>> properly.
>
> Yes, latest version did work fine.
>
> Just this OpenCV problems:
> 1. FindOpenCV.cmake included with libkface is not able to find it. If
> I delete it then OpenCV is found
> 2. I have to make a little modification to
> Index: libkface/libkface/CMakeLists.txt
> ===================================================================
> --- kdereview/libkface/libkface/CMakeLists.txt (revision 1202545)
> +++ kdereview/libkface/libkface/CMakeLists.txt (working copy)
> @@ -49,7 +49,7 @@
>                               ${KDE4_KDEUI_LIBS}
>                               ${QT_QTGUI_LIBRARY}
>                               ${LIBFACE_LIBRARIES}
> -                            ${OpenCV_LIBRARIES}
> +                            ${OpenCV_LIBS}
>                               )
>
>   SET_TARGET_PROPERTIES(kface PROPERTIES VERSION ${KFACE_LIB_SO_VERSION_STRING}

Here, the problem is that there are two versions of FindOpenCV in the
wild, one defining OpenCV_LIBRARIES and one defining OpenCV_LIBS. I
don't know who distributes which version, but at least the one that is
shipped with libkface defines OpenCV_LIBRARIES. Since we add all
FindXXX.cmake files from all our libraries to the modules search path,
CMake should find the FindOpenCV.cmake file in the libkface directory. I
added an IF-clause to make sure we handle both variable names in the
future (commit 1206532):

# there are two versions of FindOpenCV.cmake in the wild, one defining
# OpenCV_LIBRARIES, the other defining OpenCV_LIBS. Make sure we handle
# both cases.
IF (NOT OpenCV_LIBRARIES)
   SET(OPENCV_LIBRARIES ${OpenCV_LIBS})
ENDIF (NOT OpenCV_LIBRARIES)

# same story with OpenCV_INCLUDE_DIRS and OpenCV_INCLUDE_DIR:
IF (NOT OpenCV_INCLUDE_DIRS)
   SET(OpenCV_INCLUDE_DIRS ${OpenCV_INCLUDE_DIR})
ENDIF (NOT OpenCV_INCLUDE_DIRS)

> But after all I do not understand why it is arranged like that... If I
> remove the findOpenCV.cmake then the OpenCV is found just fine. Only
> that one file must be updated to use the variable that is defined by
> OpenCV makers... And some files in kipi_plugins as well I think.

I guess the problem here is again the two versions, where the one which
we ship is incapable of finding your OpenCV installation. Again, with
the patch above, it should work also with your FindOpenCV.cmake file.
But it's kind of a hack to ask the user to remove the FindOpenCV.cmake
in a subdirectory before he can compile, so I added an option to not use
the FindOpenCV.cmake shipped with libkface in commit 1206536. Add
-DKFACE_EXTERNAL_FINDOPENCV:BOOL=TRUE to cmake.

I hope this solves all the FindOpenCV issues for now. Please let me know
whether it works, and thanks for trying it!

Michael
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

I remember some discussion to ship ourselves the version which comes with
OpenCV, with a patch by Gert, and throw away the homebrewn one?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jasper]

replacing FindOpenCV.cmake with the version from:
http://opencv.willowgarage.com/wiki/FindOpenCV.cmake
worked for me here.

 build fails tho with this sort of thing

 undefined reference to `cvLoadImage'

I am suprised that I still needed to build libkexiv2 etc. before hand, I thought the idea being that this would happne automagically... (is this where its heading?)

Hi.


> I remember some discussion to ship ourselves the version which comes with
> OpenCV, with a patch by Gert, and throw away the homebrewn one?

The OpenCv has OpenCVConfig.cmake, which provides a information needed...

And quote from http://opencv.willowgarage.com/wiki/FindOpenCV.cmake :
"In this tutorial you can see that there is no need to use
FindOpenCV.cmake because in the OpenCV_DIR there is a file called
OpenCVConfig.cmake that create the configuration for OpenCV
automatically. "

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> I hope this solves all the FindOpenCV issues for now. Please let me know
> whether it works, and thanks for trying it!

Almost. If I use "external opencv find" flag then kipi-plugins do not
find opencv:

-- CMake version (cleaned): cmake version 2.8.3

--
-- ----------------------------------------------------------------------------------
--  kipi-plugins 2.0.0-beta1 dependencies results
<http://www.kipi-plugins.org>
--
--  libjpeg library found.................... YES
--  libtiff library found.................... YES
--  libpng library found..................... YES
--  libkipi library found.................... YES
--  libkexiv2 library found.................. YES
--  libkdcraw library found.................. YES
--  libkmap library found.................... YES
--  libxml2 library found.................... YES (optional)
--  libxslt library found.................... YES (optional)
--  libexpat library found................... YES (optional)
--  native threads support library found..... YES (optional)
--  libopengl library found.................. YES (optional)
--  Qt4 OpenGL module found.................. YES
--  libopencv library found.................. NO  (optional)

Maybe:
Index: extra/kipi-plugins/CMakeLists.txt
===================================================================
--- extra/kipi-plugins/CMakeLists.txt   (revision 1206613)
+++ extra/kipi-plugins/CMakeLists.txt   (working copy)
@@ -142,6 +142,12 @@
 MACRO_OPTIONAL_FIND_PACKAGE(OpenCV)     # For RemoveRedEyes.
 MACRO_OPTIONAL_FIND_PACKAGE(QJSON)      # For Debian Screenshots.

+IF (NOT OPENCV_FOUND)
+    IF (OpenCV_VERSION VERSION_GREATER "2.0.99")
+        SET(OPENCV_FOUND TRUE)
+    ENDIF (OpenCV_VERSION VERSION_GREATER "2.0.99")
+ENDIF (NOT OPENCV_FOUND)
+
 # X11 check, LINUX Only.
 IF(NOT WIN32 AND NOT APPLE)
     MACRO_OPTIONAL_FIND_PACKAGE(X11)   # For AdvancedSlideshow and ImageViewer.

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hi.

> # there are two versions of FindOpenCV.cmake in the wild, one defining
> # OpenCV_LIBRARIES, the other defining OpenCV_LIBS. Make sure we handle
> # both cases.
> IF (NOT OpenCV_LIBRARIES)
>   SET(OPENCV_LIBRARIES ${OpenCV_LIBS})
> ENDIF (NOT OpenCV_LIBRARIES)
>
> # same story with OpenCV_INCLUDE_DIRS and OpenCV_INCLUDE_DIR:
> IF (NOT OpenCV_INCLUDE_DIRS)
>   SET(OpenCV_INCLUDE_DIRS ${OpenCV_INCLUDE_DIR})
> ENDIF (NOT OpenCV_INCLUDE_DIRS)
>

Seems like the fix is not working.

I still get linking errors
Linking CXX executable ..\..\..\bin\unprocessed_raw.exe
Creating library file: ..\..\..\bin\libunprocessed_raw.dll.a
[  8%] Built target unprocessed_raw
[  8%] Built target kface_automoc
Linking CXX shared library ..\..\..\bin\libkface.dll
Creating library file: ..\..\..\bin\libkface.dll.a
CMakeFiles\kface.dir/objects.a(face.cpp.obj):C:/KdeDevel/GoSC2010/extra/libkface/libkface/face.cpp:122:
undefined reference to `cvCloneImage'
CMakeFiles\kface.dir/objects.a(face.cpp.obj):C:/KdeDevel/GoSC2010/extra/libkface/libkface/face.cpp:101:
undefined reference to `cvCloneImage'
CMakeFiles\kface.dir/objects.a(kfaceutils.cpp.obj):C:/KdeDevel/GoSC2010/extra/libkface/libkface/kfaceutils.cpp:97:
undefined reference to `cvCreateIma
ge'
CMakeFiles\kface.dir/objects.a(kfaceutils.cpp.obj):C:/KdeDevel/GoSC2010/extra/libkface/libkface/kfaceutils.cpp:135:
undefined reference to `cvCreateIm
age'
CMakeFiles\kface.dir/objects.a(image.cpp.obj): In function `~ImagePriv':
C:/KdeDevel/GoSC2010/extra/libkface/libkface/image_p.h:61: undefined
reference to `cvReleaseImage'
C:/KdeDevel/GoSC2010/extra/libkface/libkface/image_p.h:61: undefined
reference to `cvReleaseImage'

When I replace ${OpenCV_LIBRARIES} with ${OpenCV_LIBS} in
extra\libkface\libkface\CMakeLists.txt then it goes fine.

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

>> IF (NOT OpenCV_LIBRARIES)
>>   SET(OPENCV_LIBRARIES ${OpenCV_LIBS})

Perhaps the names are case-sensitive?

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

yes, in Cmake it's case sensitive...

But i don't understand why al compile here under Linux Mandriva 2010.1
and not in your computer...

Gilles Caulier

2010/12/15 Gert Kello <[hidden email]>:

>>> IF (NOT OpenCV_LIBRARIES)
>>>   SET(OPENCV_LIBRARIES ${OpenCV_LIBS})
>
> Perhaps the names are case-sensitive?
>
> Gert
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > I remember some discussion to ship ourselves the version which comes with
> > OpenCV, with a patch by Gert, and throw away the homebrewn one?
>
> The OpenCv has OpenCVConfig.cmake, which provides a information needed...

Ok I understand now: OpenCVConfig.cmake has simply the values hardcoded, while
FindOpenCV.cmake will locate them dynamically.
That means only the latter is suitable for shipping with a dependent package.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel