Fwd: [Pkg-kde-extras] Bug#417297: FTBFS with GCC 4.3: missing #includes

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: [Pkg-kde-extras] Bug#417297: FTBFS with GCC 4.3: missing #includes

Mark Purcell
digikam-dev,

Find enclosed a patch to build kipi-plugins with gcc 4.3 which you might like to
include upstream.

Btw, if you subscribe to the Debian Package Tracking System
http://packages.qa.debian.org/kipi-plugins then you will receive Debian bug
reports as soon as we do.

Mark

----------  Forwarded Message  ----------

Subject: [Pkg-kde-extras] Bug#417297: FTBFS with GCC 4.3: missing #includes
Date: Mon, 2 Apr 2007
From: Martin Michlmayr <[hidden email]>
To: [hidden email]

Package: kipi-plugins
Verion: 0.1.2-3
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot from unstable.

> Automatic build of kipi-plugins_0.1.2-3 on em64t by sbuild/amd64 0.53
...
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp: In member function 'void KIPIFlickrExportPlugin::FlickrTalker::data(KIO::Job*, const QByteArray&)':
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:372: warning: conversion to 'int' from 'uint' may alter its value
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp: In member function 'void KIPIFlickrExportPlugin::FlickrTalker::slotError(const QString&)':
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:379: error: 'atoi' was not declared in this scope
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> In file included from ./flickrtalker.moc:144,
>                  from /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:757:
> /usr/share/qt3/include/qsignalslotimp.h: In constructor 'QSignalVec::QSignalVec(int)':
> /usr/share/qt3/include/qsignalslotimp.h:76: warning: conversion to 'unsigned int' from 'int' may alter its value
> In file included from /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:757:
> /usr/share/qt3/include/qmemarray.h: In member function 'uint QMemArray<type>::size() const [with type = char]':
> /usr/share/qt3/include/qcstring.h:123:   instantiated from here
> /usr/share/qt3/include/qmemarray.h:66: warning: conversion to 'uint' from 'long unsigned int' may alter its value
> /usr/share/qt3/include/qmemarray.h: In member function 'QMemArray<type>& QMemArray<type>::duplicate(const type*, uint) [with type = char]':
> /usr/share/qt3/include/qcstring.h:252:   instantiated from here
> /usr/share/qt3/include/qmemarray.h:85: warning: conversion to 'uint' from 'long unsigned int' may alter its value
> /usr/share/qt3/include/qmemarray.h: In member function 'bool QMemArray<type>::resize(uint) [with type = char]':
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:111:   instantiated from here
> /usr/share/qt3/include/qmemarray.h:70: warning: conversion to 'uint' from 'long unsigned int' may alter its value
> /usr/share/qt3/include/qmap.h: In member function 'size_t QMap<Key, T>::size() const [with Key = QString, T = QString]':
> /usr/share/qt3/include/qmap.h:821:   instantiated from 'typename QMap<Key, T>::iterator QMap<Key, T>::insert(const Key&, const T&, bool) [with Key = QString, T = QString]'
> /usr/share/qt3/include/qmap.h:670:   instantiated from 'QMapIterator<K, T> QMap<Key, T>::replace(const Key&, const T&) [with Key = QString, T = QString]'
> /usr/include/kde/kio/global.h:537:   instantiated from here
> /usr/share/qt3/include/qmap.h:675: warning: conversion to 'size_t' from 'int' may alter its value
> make[4]: *** [flickrtalker.lo] Error 1
> make[4]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu/kipi-plugins/flickrexport'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu/kipi-plugins'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu'
> make: *** [debian/stamp-makefile-build] Error 2

--- kipi-plugins/flickrexport/flickrtalker.cpp~ 2007-04-02 09:32:20.000000000 +0000
+++ kipi-plugins/flickrexport/flickrtalker.cpp 2007-04-02 09:32:31.000000000 +0000
@@ -38,6 +38,7 @@
 #include <qdom.h>
 #include <cstring>
 #include <cstdio>
+#include <cstdlib>
 
 #include <string>
 #include "flickritem.h"

--
Martin Michlmayr
http://www.cyrius.com/


_______________________________________________
pkg-kde-extras mailing list
[hidden email]
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-extras

-------------------------------------------------------

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: [Pkg-kde-extras] Bug#417297: FTBFS with GCC 4.3: missing #includes

Gilles Caulier-4
Mark,
 
You is on the wrong mailing list. Kipi-plugins ML is "[hidden email].
 
Thanks in advance to re-post your message on the right way. The plugins mainteners are in this room.
 
Gilles Caulier

 
2007/4/27, Mark Purcell <[hidden email]>:
digikam-dev,

Find enclosed a patch to build kipi-plugins with gcc 4.3 which you might like to
include upstream.

Btw, if you subscribe to the Debian Package Tracking System
http://packages.qa.debian.org/kipi-plugins then you will receive Debian bug
reports as soon as we do.

Mark

----------  Forwarded Message  ----------

Subject: [Pkg-kde-extras] Bug#417297: FTBFS with GCC 4.3: missing #includes
Date: Mon, 2 Apr 2007
From: Martin Michlmayr <[hidden email]>
To: [hidden email]

Package: kipi-plugins
Verion: 0.1.2-3
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot from unstable.

> Automatic build of kipi-plugins_0.1.2-3 on em64t by sbuild/amd64 0.53
...
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp: In member function 'void KIPIFlickrExportPlugin::FlickrTalker::data(KIO::Job*, const QByteArray&)':
> /build/tbm/kipi- plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:372: warning: conversion to 'int' from 'uint' may alter its value
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp: In member function 'void KIPIFlickrExportPlugin::FlickrTalker::slotError(const QString&)':
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:379: error: 'atoi' was not declared in this scope
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> In file included from ./flickrtalker.moc:144,
>                  from /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:757:
> /usr/share/qt3/include/qsignalslotimp.h: In constructor 'QSignalVec::QSignalVec(int)':
> /usr/share/qt3/include/qsignalslotimp.h:76: warning: conversion to 'unsigned int' from 'int' may alter its value
> In file included from /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:757:
> /usr/share/qt3/include/qmemarray.h: In member function 'uint QMemArray<type>::size() const [with type = char]':
> /usr/share/qt3/include/qcstring.h:123:   instantiated from here
> /usr/share/qt3/include/qmemarray.h:66: warning: conversion to 'uint' from 'long unsigned int' may alter its value
> /usr/share/qt3/include/qmemarray.h: In member function 'QMemArray<type>& QMemArray<type>::duplicate(const type*, uint) [with type = char]':
> /usr/share/qt3/include/qcstring.h:252:   instantiated from here
> /usr/share/qt3/include/qmemarray.h:85: warning: conversion to 'uint' from 'long unsigned int' may alter its value
> /usr/share/qt3/include/qmemarray.h: In member function 'bool QMemArray<type>::resize(uint) [with type = char]':
> /build/tbm/kipi-plugins-0.1.2/./kipi-plugins/flickrexport/flickrtalker.cpp:111:   instantiated from here
> /usr/share/qt3/include/qmemarray.h:70: warning: conversion to 'uint' from 'long unsigned int' may alter its value
> /usr/share/qt3/include/qmap.h: In member function 'size_t QMap<Key, T>::size() const [with Key = QString, T = QString]':
> /usr/share/qt3/include/qmap.h:821:   instantiated from 'typename QMap<Key, T>::iterator QMap<Key, T>::insert(const Key&, const T&, bool) [with Key = QString, T = QString]'
> /usr/share/qt3/include/qmap.h:670:   instantiated from 'QMapIterator<K, T> QMap<Key, T>::replace(const Key&, const T&) [with Key = QString, T = QString]'
> /usr/include/kde/kio/global.h:537:   instantiated from here
> /usr/share/qt3/include/qmap.h:675: warning: conversion to 'size_t' from 'int' may alter its value
> make[4]: *** [flickrtalker.lo] Error 1
> make[4]: Leaving directory `/build/tbm/kipi- plugins-0.1.2/obj-x86_64-linux-gnu/kipi-plugins/flickrexport'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu/kipi-plugins'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/build/tbm/kipi-plugins-0.1.2/obj-x86_64-linux-gnu'
> make: *** [debian/stamp-makefile-build] Error 2


--- kipi-plugins/flickrexport/flickrtalker.cpp~ 2007-04-02 09:32:20.000000000 +0000
+++ kipi-plugins/flickrexport/flickrtalker.cpp  2007-04-02 09:32:31.000000000 +0000
@@ -38,6 +38,7 @@
#include <qdom.h>
#include <cstring>
#include <cstdio>
+#include <cstdlib>

#include <string>
#include "flickritem.h"

--
Martin Michlmayr
http://www.cyrius.com/


_______________________________________________
pkg-kde-extras mailing list
[hidden email]
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-extras

-------------------------------------------------------

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel




_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel