Fwd: Camera Menu

I think a much better way would be to have only one menu entry:

Cameras -> list of all cameras (auto-detect and manually added mixed together)
-> separator -> "add camera" action

If we find duplicate entries, do not add the camera, otherwise add it.
If we find entries that are similar, add the camera, but append "(auto-
detected)".

What do you think?

Andi


SVN commit 1005626 by aclemens:

I would suggest to re-arrange camera import action menus, rename to "Manually Added"
because using only "Add" sounds like this action is only used to add a
camera, but may confuse users because you also find already added cameras in
there.
Also the camera menu entries should be together.

 M  +1 -1      digikamapp.cpp  
 M  +2 -2      digikamui.rc  


--- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #1005625:1005626
@@ -1518,7 +1518,7 @@
     d->usbMediaMenu->setIcon(KIcon("drive-removable-media-usb"));
     d->cardReaderMenu->setText(i18n("Card Readers"));
     d->cardReaderMenu->setIcon(KIcon("media-flash-smart-media"));
-    d->manuallyAddedCamerasMenu->setText(i18n("Cameras (Add)"));
+    d->manuallyAddedCamerasMenu->setText(i18n("Cameras (Manually Added)"));
     d->manuallyAddedCamerasMenu->setIcon(KIcon("preferences-other"));
 
     actionCollection()->addAction("camera_solid", d->cameraSolidMenu);
--- trunk/extragear/graphics/digikam/digikam/digikamui.rc #1005625:1005626
@@ -1,5 +1,5 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<gui version="59" name="digikam" >
+<gui version="61" name="digikam" >
 
  <MenuBar>
 
@@ -102,9 +102,9 @@
 
   <Menu name="Import"><text>I&amp;mport</text>
       <Action name="camera_solid" />
+      <Action name="camera_addedmanually" />
       <Action name="usb_media" />
       <Action name="card_reader" />
-      <Action name="camera_addedmanually" />
       <Separator/>
       <Action name="import_addImages" />
       <Action name="import_addFolders" />

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

And "manually added" cameras always win for sure, so if I add
"Nikon D50 (PTP Mode)"
and the auto-detect gives my
"Nikon D50 (ptp)",
we could simply drop this entry, since it is the same camera.

Do you see problems with that?
I can try to implement this, it would be more user-friendly I guess.

Andi

On Saturday 01 August 2009 16:46:01 Andi Clemens wrote:

> I think a much better way would be to have only one menu entry:
>
> Cameras -> list of all cameras (auto-detect and manually added mixed
> together) -> separator -> "add camera" action
>
> If we find duplicate entries, do not add the camera, otherwise add it.
> If we find entries that are similar, add the camera, but append "(auto-
> detected)".
>
> What do you think?
>
> Andi

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I have taken a screenshot of what it looks right now. We would also need a
method to cleanup the name, right now we use the full action name which is not
good. Try to rename files with the camera name added, it will always add the
mode, too (and right now also "auto-detected").

I need another method to compare solid and fixed cameras, so that no duplicate
entries are presented in the menu as it is right now.

What do you think?
I really believe this is a better way to present the list of cameras (because
most people only have 1 or 2 cameras, splitting the menu is, at least for me,
not necessary).

Andi

On Saturday 01 August 2009 16:49:37 Andi Clemens wrote:

> And "manually added" cameras always win for sure, so if I add
> "Nikon D50 (PTP Mode)"
> and the auto-detect gives my
> "Nikon D50 (ptp)",
> we could simply drop this entry, since it is the same camera.
>
> Do you see problems with that?
> I can try to implement this, it would be more user-friendly I guess.
>
> Andi
>
> On Saturday 01 August 2009 16:46:01 Andi Clemens wrote:
> > I think a much better way would be to have only one menu entry:
> >
> > Cameras -> list of all cameras (auto-detect and manually added mixed
> > together) -> separator -> "add camera" action
> >
> > If we find duplicate entries, do not add the camera, otherwise add it.
> > If we find entries that are similar, add the camera, but append "(auto-
> > detected)".
> >
> > What do you think?
> >
> > Andi
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I have taken a screenshot of what it looks right now. We would also need a
> method to cleanup the name, right now we use the full action name which is
> not good. Try to rename files with the camera name added, it will always
> add the mode, too (and right now also "auto-detected").
>
> I need another method to compare solid and fixed cameras, so that no
> duplicate entries are presented in the menu as it is right now.
>
> What do you think?

Fine for me.
Normally Solid should detect all cameras so now manual intervention is
required. Maybe we rename "Add Camera..." to "Add Camera manually" to
emphasize this?

> I really believe this is a better way to present the list of cameras
> (because most people only have 1 or 2 cameras, splitting the menu is, at
> least for me, not necessary).
>
> Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

The basic functionality is provided now, I will need to add some new code to
the cameraUI window, so that we can use the trimmed down cameraName from now
on.

On Saturday 01 August 2009 21:19:50 Marcel Wiesweg wrote:

> > I have taken a screenshot of what it looks right now. We would also need
> > a method to cleanup the name, right now we use the full action name which
> > is not good. Try to rename files with the camera name added, it will
> > always add the mode, too (and right now also "auto-detected").
> >
> > I need another method to compare solid and fixed cameras, so that no
> > duplicate entries are presented in the menu as it is right now.
> >
> > What do you think?
>
> Fine for me.
> Normally Solid should detect all cameras so now manual intervention is
> required. Maybe we rename "Add Camera..." to "Add Camera manually" to
> emphasize this?

Yes, I think this is better. I will change it now.

>
> > I really believe this is a better way to present the list of cameras
> > (because most people only have 1 or 2 cameras, splitting the menu is, at
> > least for me, not necessary).
> >
> > Andi
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

Cool that you fixed the bug that removed cameras remained in the menu! Had
noticed that recently as well.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel