Fix for default build of digikam-sc

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix for default build of digikam-sc

Andrew Goodbody
Hi Gilles,

I just pushed a fix for CMakeLists.txt from digikam-sc as it was broken
for the default build since your commit from 23rd March.
DIGIKAMSC_USE_PRIVATE_KDEGRAPHICS is now always defined since it has a
default so the test for NOT DEFINED was never going to work AFAICT.

I also fixed some typos and grammar nearby. I hope that this is all OK.
If not please let me know.

I only found this bug because the cmake run failed so there may well now
be problems if anyone needs to use DIGIKAMSC_USE_PRIVATE_KDEGRAPHICS=on.
The find packages for the private libkdcraw and libksane seemed to
return errors.

Andrew
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Fix for default build of digikam-sc

Gilles Caulier-4
Andrew,

All sound fine. Thanks for the fix.

Gilles

Le 26 mars 2012 23:58, Andrew Goodbody <[hidden email]> a écrit :

> Hi Gilles,
>
> I just pushed a fix for CMakeLists.txt from digikam-sc as it was broken for
> the default build since your commit from 23rd March.
> DIGIKAMSC_USE_PRIVATE_KDEGRAPHICS is now always defined since it has a
> default so the test for NOT DEFINED was never going to work AFAICT.
>
> I also fixed some typos and grammar nearby. I hope that this is all OK. If
> not please let me know.
>
> I only found this bug because the cmake run failed so there may well now be
> problems if anyone needs to use DIGIKAMSC_USE_PRIVATE_KDEGRAPHICS=on. The
> find packages for the private libkdcraw and libksane seemed to return
> errors.
>
> Andrew
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel