Find Duplicates: exclude or include albums?

Hi,

I have added a way to exclude Albums from the find duplicates search.
I have a test collection with over 50.000 images, this is way too much for the
find duplicates search.
We need to limit this somehow and this is what happened in current SVN.

Right now you can exclude albums from being checked, but since I'm actually
using it now, I think it would be much better to use this feature to INCLUDE
the albums that should be checked.

All albums would be automatically checked on first use, and whatever you set
in there will be saved for future use cases.

What do you think?
It would make the code much easier, too :D

My vote:
+ 1 for include


Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

+1 for me too...

Another very important feature for all fuzzy searches tools is to
print over icon view thumbs the % relevance of items found.

This information (called 'score' in code) exist in Haar search
algorithm and is printed on the console here :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/haar/haariface.cpp#408

I think the most simpler way is to add a new icons view item overlay
to just print this value somewhere over thumb. Of course, this overlay
need to be displayed only with fuzzy search albums.

Note : In Imgseek, this information is displayed under thumbs as comment.

The other problem is to sort fuzzy search items by score on icon view....

Marcel, what do you think about ?

Gilles


2009/6/10 Andi Clemens <[hidden email]>:

> Hi,
>
> I have added a way to exclude Albums from the find duplicates search.
> I have a test collection with over 50.000 images, this is way too much for the
> find duplicates search.
> We need to limit this somehow and this is what happened in current SVN.
>
> Right now you can exclude albums from being checked, but since I'm actually
> using it now, I think it would be much better to use this feature to INCLUDE
> the albums that should be checked.
>
> All albums would be automatically checked on first use, and whatever you set
> in there will be saved for future use cases.
>
> What do you think?
> It would make the code much easier, too :D
>
> My vote:
> + 1 for include
>
>
> Andi
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Ok I changed it to the 'include' version.
This really so much better and more logical.
I need to find a way to save the state of the selected albums as well as some
update method (if albums are removed, renamed).
But it is already functional, you only lose the selection after restart at the
moment.

Andi

On Wednesday 10 June 2009 21:10:10 Gilles Caulier wrote:

> +1 for me too...
>
> Another very important feature for all fuzzy searches tools is to
> print over icon view thumbs the % relevance of items found.
>
> This information (called 'score' in code) exist in Haar search
> algorithm and is printed on the console here :
>
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/database/haar/haa
>riface.cpp#408
>
> I think the most simpler way is to add a new icons view item overlay
> to just print this value somewhere over thumb. Of course, this overlay
> need to be displayed only with fuzzy search albums.
>
> Note : In Imgseek, this information is displayed under thumbs as comment.
>
> The other problem is to sort fuzzy search items by score on icon view....
>
> Marcel, what do you think about ?
>
> Gilles
>
> 2009/6/10 Andi Clemens <[hidden email]>:
> > Hi,
> >
> > I have added a way to exclude Albums from the find duplicates search.
> > I have a test collection with over 50.000 images, this is way too much
> > for the find duplicates search.
> > We need to limit this somehow and this is what happened in current SVN.
> >
> > Right now you can exclude albums from being checked, but since I'm
> > actually using it now, I think it would be much better to use this
> > feature to INCLUDE the albums that should be checked.
> >
> > All albums would be automatically checked on first use, and whatever you
> > set in there will be saved for future use cases.
> >
> > What do you think?
> > It would make the code much easier, too :D
> >
> > My vote:
> > + 1 for include
> >
> >
> > Andi
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Another possibility:

Add a context menu action to the folderview: Find Duplicates
If selected, it will automatically set the albums for the find duplicates
search.

So if I have something like this:

Album A
|-- Album B
|-- Album C
Album D

and I right-click on Album A -> Find Duplicates,
it will switch to the find duplicates view and set the Albums A,B,C as the
search target.

This would bring back a feature we had in KDE3.

Andi

On Wednesday 10 June 2009 20:37:49 Andi Clemens wrote:

> Hi,
>
> I have added a way to exclude Albums from the find duplicates search.
> I have a test collection with over 50.000 images, this is way too much for
> the find duplicates search.
> We need to limit this somehow and this is what happened in current SVN.
>
> Right now you can exclude albums from being checked, but since I'm actually
> using it now, I think it would be much better to use this feature to
> INCLUDE the albums that should be checked.
>
> All albums would be automatically checked on first use, and whatever you
> set in there will be saved for future use cases.
>
> What do you think?
> It would make the code much easier, too :D
>
> My vote:
> + 1 for include
>
>
> Andi
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

I have some problems with the AlbumSelectCombobox:

When you move the mouse over the albumtree in there, the view begins to scroll
sometimes, like when you are using the mouse wheel.
This is also true for the advanced search dialog, so I guess it is not my
setup but a general problem.

Marcel,

any idea what could be wrong here? It is sometimes hard to select an album
when the view just scrolls around.
I have looked at the code, but still all this modelview stuff is a bit strange
for me :D

Andi

On Wednesday 10 June 2009 20:37:49 Andi Clemens wrote:

> Hi,
>
> I have added a way to exclude Albums from the find duplicates search.
> I have a test collection with over 50.000 images, this is way too much for
> the find duplicates search.
> We need to limit this somehow and this is what happened in current SVN.
>
> Right now you can exclude albums from being checked, but since I'm actually
> using it now, I think it would be much better to use this feature to
> INCLUDE the albums that should be checked.
>
> All albums would be automatically checked on first use, and whatever you
> set in there will be saved for future use cases.
>
> What do you think?
> It would make the code much easier, too :D
>
> My vote:
> + 1 for include
>
>
> Andi
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I have some problems with the AlbumSelectCombobox:
>
> When you move the mouse over the albumtree in there, the view begins to
> scroll sometimes, like when you are using the mouse wheel.
> This is also true for the advanced search dialog, so I guess it is not my
> setup but a general problem.
>
> Marcel,
>
> any idea what could be wrong here? It is sometimes hard to select an album
> when the view just scrolls around.
> I have looked at the code, but still all this modelview stuff is a bit
> strange for me :D

It must be some automatic scrolling, initiated by the Qt view classes. My guess is this:

/*
    \property QAbstractItemView::autoScroll
    \brief whether autoscrolling in drag move events is enabled

    If this property is set to true (the default), the
    QAbstractItemView automatically scrolls the contents of the view
    if the user drags within 16 pixels of the viewport edge. If the current
    item changes, then the view will scroll automatically to ensure that the <---
    current item is fully visible.

    This property only works if the viewport accepts drops. Autoscroll is
    switched off by setting this property to false.
*/
void QAbstractItemView::setAutoScroll(bool enable)


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Ah ok so we should disable this I guess, in advanced search and in find
duplicates (or in the widget itself).
Right now the behaviour is more annoying then helpful :-)

Andi

On Thursday 11 June 2009 16:37:14 Marcel Wiesweg wrote:

> > I have some problems with the AlbumSelectCombobox:
> >
> > When you move the mouse over the albumtree in there, the view begins to
> > scroll sometimes, like when you are using the mouse wheel.
> > This is also true for the advanced search dialog, so I guess it is not my
> > setup but a general problem.
> >
> > Marcel,
> >
> > any idea what could be wrong here? It is sometimes hard to select an
> > album when the view just scrolls around.
> > I have looked at the code, but still all this modelview stuff is a bit
> > strange for me :D
>
> It must be some automatic scrolling, initiated by the Qt view classes. My
> guess is this:
>
> /*
>     \property QAbstractItemView::autoScroll
>     \brief whether autoscrolling in drag move events is enabled
>
>     If this property is set to true (the default), the
>     QAbstractItemView automatically scrolls the contents of the view
>     if the user drags within 16 pixels of the viewport edge. If the current
>     item changes, then the view will scroll automatically to ensure that
> the <--- current item is fully visible.
>
>     This property only works if the viewport accepts drops. Autoscroll is
>     switched off by setting this property to false.
> */
> void QAbstractItemView::setAutoScroll(bool enable)
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Now that we can quite easily search duplicates in an album (also by using the
context menu in folder view), I thought of removing the fast search again and
remove the dialog as well.
Fast search is actually quite useless, since it only finds 100% identical
images (they have to be the same dimension as well).
I only added it because find duplicates was very slow in the past.

Is this ok for you?

Andi

On Wednesday 10 June 2009 20:37:49 Andi Clemens wrote:

> Hi,
>
> I have added a way to exclude Albums from the find duplicates search.
> I have a test collection with over 50.000 images, this is way too much for
> the find duplicates search.
> We need to limit this somehow and this is what happened in current SVN.
>
> Right now you can exclude albums from being checked, but since I'm actually
> using it now, I think it would be much better to use this feature to
> INCLUDE the albums that should be checked.
>
> All albums would be automatically checked on first use, and whatever you
> set in there will be saved for future use cases.
>
> What do you think?
> It would make the code much easier, too :D
>
> My vote:
> + 1 for include
>
>
> Andi
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel