Error compiling svn 1031743

Hi,

I wanted to compile the current svn to check the changes Gilles have
made concerning a crash at the batch tool.

Unfortunately something must have changed since version 1029402 which
complies perfectly on my machine:

Scanning dependencies of target digikamcore
[  0%] Building CXX object
digikam/digikam/CMakeFiles/digikamcore.dir/digikamcore_automoc.o
[  0%] Building CXX object
digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o
In file included from /usr/include/QtCore/qdebug.h:42,
                 from /usr/include/QtCore/QDebug:1,

from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/captionvalues.h:32,

from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/dmetadata.h:39,

from /home/guenni/tmp/kde4/graphics/digikam/libs/dimg/dimg.cpp:74:
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(char)’:
/usr/include/QtCore/qhash.h:59: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:59: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:59: error: declaration of ‘unsigned int key’
shadows a parameter
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(unsigned
char)’:
/usr/include/QtCore/qhash.h:60: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:60: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:60: error: declaration of ‘unsigned int key’
shadows a parameter
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(signed
char)’:
/usr/include/QtCore/qhash.h:61: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:61: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:61: error: declaration of ‘unsigned int key’
shadows a parameter
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(short
unsigned int)’:
/usr/include/QtCore/qhash.h:62: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:62: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:62: error: declaration of ‘unsigned int key’
shadows a parameter
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(short
int)’:
/usr/include/QtCore/qhash.h:63: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:63: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:63: error: declaration of ‘unsigned int key’
shadows a parameter
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(int)’:
/usr/include/QtCore/qhash.h:65: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:65: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:65: error: declaration of ‘unsigned int key’
shadows a parameter
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(long
unsigned int)’:
/usr/include/QtCore/qhash.h:69: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:69: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:69: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:69: error: expected `;' before ‘unsigned’
/usr/include/QtCore/qhash.h:71: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:71: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(long int)’:
/usr/include/QtCore/qhash.h:74: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(quint64)’:
/usr/include/QtCore/qhash.h:78: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:78: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:78: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:78: error: expected `;' before ‘unsigned’
/usr/include/QtCore/qhash.h:80: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:80: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(const T*)’:
/usr/include/QtCore/qhash.h:99: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:99: error: expected ‘;’ before ‘unsigned’
/usr/include/QtCore/qhash.h:99: error: expected primary-expression
before ‘unsigned’
/usr/include/QtCore/qhash.h:99: error: expected `;' before ‘unsigned’
make[2]: ***
[digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o] Fehler
1
make[1]: *** [digikam/digikam/CMakeFiles/digikamcore.dir/all] Fehler 2

Also I got now a warning during cmake that marble plugin will not
compile:

--  libmarblewidget library found....... YES (optional)
--  Can build Marble plugin............. NO  (optional)

This was also running with 1029402.

Guenther


_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

2009/10/5 Guenther Erhard <[hidden email]>:

> Hi,
>
> I wanted to compile the current svn to check the changes Gilles have
> made concerning a crash at the batch tool.
>
> Unfortunately something must have changed since version 1029402 which
> complies perfectly on my machine:
>
> Scanning dependencies of target digikamcore
> [  0%] Building CXX object
> digikam/digikam/CMakeFiles/digikamcore.dir/digikamcore_automoc.o
> [  0%] Building CXX object
> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o
> In file included from /usr/include/QtCore/qdebug.h:42,
>                 from /usr/include/QtCore/QDebug:1,
>
> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/captionvalues.h:32,
>
> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/dmetadata.h:39,
>
> from /home/guenni/tmp/kde4/graphics/digikam/libs/dimg/dimg.cpp:74:

There is nothing special there. All is relevant of Qt4, not digiKam.
Something is broken on your computer ?

> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(char)’:
> /usr/include/QtCore/qhash.h:59: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:59: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:59: error: declaration of ‘unsigned int key’
> shadows a parameter
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(unsigned
> char)’:
> /usr/include/QtCore/qhash.h:60: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:60: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:60: error: declaration of ‘unsigned int key’
> shadows a parameter
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(signed
> char)’:
> /usr/include/QtCore/qhash.h:61: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:61: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:61: error: declaration of ‘unsigned int key’
> shadows a parameter
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(short
> unsigned int)’:
> /usr/include/QtCore/qhash.h:62: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:62: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:62: error: declaration of ‘unsigned int key’
> shadows a parameter
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(short
> int)’:
> /usr/include/QtCore/qhash.h:63: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:63: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:63: error: declaration of ‘unsigned int key’
> shadows a parameter
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(int)’:
> /usr/include/QtCore/qhash.h:65: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:65: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:65: error: declaration of ‘unsigned int key’
> shadows a parameter
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(long
> unsigned int)’:
> /usr/include/QtCore/qhash.h:69: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:69: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:69: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:69: error: expected `;' before ‘unsigned’
> /usr/include/QtCore/qhash.h:71: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:71: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(long int)’:
> /usr/include/QtCore/qhash.h:74: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(quint64)’:
> /usr/include/QtCore/qhash.h:78: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:78: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:78: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:78: error: expected `;' before ‘unsigned’
> /usr/include/QtCore/qhash.h:80: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:80: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h: In function ‘unsigned int qHash(const T*)’:
> /usr/include/QtCore/qhash.h:99: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:99: error: expected ‘;’ before ‘unsigned’
> /usr/include/QtCore/qhash.h:99: error: expected primary-expression
> before ‘unsigned’
> /usr/include/QtCore/qhash.h:99: error: expected `;' before ‘unsigned’
> make[2]: ***
> [digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o] Fehler
> 1
> make[1]: *** [digikam/digikam/CMakeFiles/digikamcore.dir/all] Fehler 2
>
> Also I got now a warning during cmake that marble plugin will not
> compile:

Don't care there. forget it...

Gilles
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Salut Gilles,

> There is nothing special there. All is relevant of Qt4, not digiKam.
> Something is broken on your computer ?
>
Hm, I did not change anything in the last week. Last weekend 1029402 compiled without a problem. I've checked out this old version again and it still compiles without an error. So my assumption is that in one of the following versions something must have been modified in the code which requires now maybe a higher version of Qt4 (currently 4.4.3 is installed).

I can remember a similiar effect when the new advanced renaming tool was introduced. At first some code required Qt4.5. Andi Clemens has modified it to enable compilation with Qt4.4.

Guenther

--
Vocabulary Cards for Palm OS - Try it!
http://dolphin-world.de/vc.html



_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

2009/10/6 Guenther Erhard <[hidden email]>:
> Salut Gilles,
>
>> There is nothing special there. All is relevant of Qt4, not digiKam.
>> Something is broken on your computer ?
>>
> Hm, I did not change anything in the last week. Last weekend 1029402 compiled without a problem. I've checked out this old version again and it still compiles without an error. So my assumption is that in one of the following versions something must have been modified in the code which requires now maybe a higher version of Qt4 (currently 4.4.3 is installed).
>
> I can remember a similiar effect when the new advanced renaming tool was introduced. At first some code required Qt4.5. Andi Clemens has modified it to enable compilation with Qt4.4.
>

perhaps, but here:

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/captionvalues.h#32

Where you can see your problem :

> Scanning dependencies of target digikamcore
> [  0%] Building CXX object
> digikam/digikam/CMakeFiles/digikamcore.dir/digikamcore_automoc.o
> [  0%] Building CXX object
> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o
> In file included from /usr/include/QtCore/qdebug.h:42,
>                 from /usr/include/QtCore/QDebug:1,
>
> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/captionvalues.h:32,
>
> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/dmetadata.h:39,
>
> from /home/guenni/tmp/kde4/graphics/digikam/libs/dimg/dimg.cpp:74:

...is a pure Qt4 problem from your computer.

Why ? I don't know.

Try to remove CMakeCache.txt from your root source dir, and restart
cmake to re-configure all. after that, try again...

Gilles Caulier
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Hi,

I have the same problem, compiling under Windows with KDE 4.2.3. As far
as I can see the problem is with 1030990 which puts the inclusion of
debug.h at the end of the local includes. Before kdebug.h was included
before the local includes. Just moving the inclusion of debug.h to be
the first of the local includes solves the problem for me.

/David

Gilles Caulier skrev:

> 2009/10/6 Guenther Erhard <[hidden email]>:
>  
>> Salut Gilles,
>>
>>    
>>> There is nothing special there. All is relevant of Qt4, not digiKam.
>>> Something is broken on your computer ?
>>>
>>>      
>> Hm, I did not change anything in the last week. Last weekend 1029402 compiled without a problem. I've checked out this old version again and it still compiles without an error. So my assumption is that in one of the following versions something must have been modified in the code which requires now maybe a higher version of Qt4 (currently 4.4.3 is installed).
>>
>> I can remember a similiar effect when the new advanced renaming tool was introduced. At first some code required Qt4.5. Andi Clemens has modified it to enable compilation with Qt4.4.
>>
>>    
>
> perhaps, but here:
>
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/captionvalues.h#32
>
> Where you can see your problem :
>
>  
>> Scanning dependencies of target digikamcore
>> [  0%] Building CXX object
>> digikam/digikam/CMakeFiles/digikamcore.dir/digikamcore_automoc.o
>> [  0%] Building CXX object
>> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o
>> In file included from /usr/include/QtCore/qdebug.h:42,
>>                 from /usr/include/QtCore/QDebug:1,
>>
>> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/captionvalues.h:32,
>>
>> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/dmetadata.h:39,
>>
>> from /home/guenni/tmp/kde4/graphics/digikam/libs/dimg/dimg.cpp:74:
>>    
>
> ...is a pure Qt4 problem from your computer.
>
> Why ? I don't know.
>
> Try to remove CMakeCache.txt from your root source dir, and restart
> cmake to re-configure all. after that, try again...
>
> Gilles Caulier
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users
>  

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

Same there : KDE 4.2.3 + Qt 4.5.0

No problem...

Gilles

2009/10/6 David Eriksson <[hidden email]>:

> Hi,
>
> I have the same problem, compiling under Windows with KDE 4.2.3. As far
> as I can see the problem is with 1030990 which puts the inclusion of
> debug.h at the end of the local includes. Before kdebug.h was included
> before the local includes. Just moving the inclusion of debug.h to be
> the first of the local includes solves the problem for me.
>
> /David
>
> Gilles Caulier skrev:
>> 2009/10/6 Guenther Erhard <[hidden email]>:
>>
>>> Salut Gilles,
>>>
>>>
>>>> There is nothing special there. All is relevant of Qt4, not digiKam.
>>>> Something is broken on your computer ?
>>>>
>>>>
>>> Hm, I did not change anything in the last week. Last weekend 1029402 compiled without a problem. I've checked out this old version again and it still compiles without an error. So my assumption is that in one of the following versions something must have been modified in the code which requires now maybe a higher version of Qt4 (currently 4.4.3 is installed).
>>>
>>> I can remember a similiar effect when the new advanced renaming tool was introduced. At first some code required Qt4.5. Andi Clemens has modified it to enable compilation with Qt4.4.
>>>
>>>
>>
>> perhaps, but here:
>>
>> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/captionvalues.h#32
>>
>> Where you can see your problem :
>>
>>
>>> Scanning dependencies of target digikamcore
>>> [  0%] Building CXX object
>>> digikam/digikam/CMakeFiles/digikamcore.dir/digikamcore_automoc.o
>>> [  0%] Building CXX object
>>> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o
>>> In file included from /usr/include/QtCore/qdebug.h:42,
>>>                 from /usr/include/QtCore/QDebug:1,
>>>
>>> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/captionvalues.h:32,
>>>
>>> from /home/guenni/tmp/kde4/graphics/digikam/digikam/../libs/dmetadata/dmetadata.h:39,
>>>
>>> from /home/guenni/tmp/kde4/graphics/digikam/libs/dimg/dimg.cpp:74:
>>>
>>
>> ...is a pure Qt4 problem from your computer.
>>
>> Why ? I don't know.
>>
>> Try to remove CMakeCache.txt from your root source dir, and restart
>> cmake to re-configure all. after that, try again...
>>
>> Gilles Caulier
>> _______________________________________________
>> Digikam-users mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-users
>>
>
> _______________________________________________
> Digikam-users mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-users
>

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

Hi David,

> Just moving the inclusion of debug.h to be
> the first of the local includes solves the problem for me.
>
You're right. Moving debug.h to be the first entry on the local includes
in following files:

graphics/digikam/libs/dimg/dimg.cpp
graphics/digikam/libs/dimg/loaders/jp2kloader.cpp

worked also for me.

@Gilles: I think this should be corrected in svn.

Thx
Guenther

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

2009/10/6 Guenther Erhard <[hidden email]>:

> Hi David,
>
>> Just moving the inclusion of debug.h to be
>> the first of the local includes solves the problem for me.
>>
> You're right. Moving debug.h to be the first entry on the local includes
> in following files:
>
> graphics/digikam/libs/dimg/dimg.cpp
> graphics/digikam/libs/dimg/loaders/jp2kloader.cpp
>
> worked also for me.
>
> @Gilles: I think this should be corrected in svn.

Done...

Gilles
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users