digiKam › digikam-devel

Does current git compile with KDE SC 4.10's kdegrphics libs?

classic Classic list List threaded Threaded
♦
♦
 11 messages Options
S. Burmeister
Reply | Threaded
Open this post in threaded view
♦
♦
|

Does current git compile with KDE SC 4.10's kdegrphics libs?

S. Burmeister
Hey everybody!

Should it be possible to compile current git of the digikam collection against
the released, i.e. KDE SC 4.10, kdegraphics libraries (libkexev, libkdcraw
etc.)? Or does one need KDE 4.11's libs for what will become digikam 3.1?

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Gilles Caulier-4
yes digiKam has sync extra lib developement (libkexiv2, libkdcraw, libkipi) with KDE 4.10 release.

This is why digiKam 3.0.0 have been released few day later KDE 4.10

Gilles Caulier


2013/3/3 Sven Burmeister <[hidden email]>
Hey everybody!

Should it be possible to compile current git of the digikam collection against
the released, i.e. KDE SC 4.10, kdegraphics libraries (libkexev, libkdcraw
etc.)? Or does one need KDE 4.11's libs for what will become digikam 3.1?

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
S. Burmeister
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

S. Burmeister
Am Sonntag, 3. März 2013, 11:34:06 schrieb Gilles Caulier:
> yes digiKam has sync extra lib developement (libkexiv2, libkdcraw, libkipi)
> with KDE 4.10 release.
>
> This is why digiKam 3.0.0 have been released few day later KDE 4.10

It currently fails though while compiling with private libs enabled works.

[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp: In member function 'bool Digikam::DMetadata::setImageFacesMap(QMap<QString, QVariant>&) const':
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1365:35: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1378:44: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1381:51: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1385:45: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1389:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1393:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1397:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1401:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
[ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1405:57: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Veaceslav Munteanu
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Veaceslav Munteanu
On Sun, Mar 3, 2013 at 1:54 PM, Sven Burmeister <[hidden email]> wrote:

> Am Sonntag, 3. März 2013, 11:34:06 schrieb Gilles Caulier:
>> yes digiKam has sync extra lib developement (libkexiv2, libkdcraw, libkipi)
>> with KDE 4.10 release.
>>
>> This is why digiKam 3.0.0 have been released few day later KDE 4.10
>
> It currently fails though while compiling with private libs enabled works.
>
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp: In member function 'bool Digikam::DMetadata::setImageFacesMap(QMap<QString, QVariant>&) const':
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1365:35: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1378:44: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1381:51: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1385:45: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1389:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1393:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1397:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1401:54: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'
> [ 1413s] /home/abuild/rpmbuild/BUILD/digikam-software-compilation/core/libs/dmetadata/dmetadata.cpp:1405:57: error: 'XmpTagType' is not a member of 'KExiv2Iface::KExiv2'

Please use the private libs, new version of libkexiv2 is comming with
KDE 4.10.2 and we operated few changes on this lib.



--
Veaceslav
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Veaceslav Munteanu
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Veaceslav Munteanu
> Please use the private libs, new version of libkexiv2 is comming with
> KDE 4.10.2 and we operated few changes on this lib.

Sorry, next one is 4.10.1 (I think...)
--
Veaceslav
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Marcel Wiesweg
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Marcel Wiesweg
In reply to this post by Veaceslav Munteanu


> Please use the private libs, new version of libkexiv2 is comming with
> KDE 4.10.2 and we operated few changes on this lib.

Did you really backport this change to the 4.10 branch? I'm not sure this is
really appropriate, it's a new feature, not a fix.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Rex Dieter
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Rex Dieter
Marcel Wiesweg wrote:

>> Please use the private libs, new version of libkexiv2 is comming with
>> KDE 4.10.2 and we operated few changes on this lib.
>
> Did you really backport this change to the 4.10 branch? I'm not sure this
> is really appropriate, it's a new feature, not a fix.

Why not?
compatiblity isn't guaranteed beyond kdelibs/kdepimlibs, see also
http://techbase.kde.org/Policies/Draft/Binary_And_Source_Compatibility_Policy#Binary_Compatibility_Guarantee

-- rex

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Rex Dieter
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Rex Dieter
Rex Dieter wrote:

> Marcel Wiesweg wrote:
>
>>> Please use the private libs, new version of libkexiv2 is comming with
>>> KDE 4.10.2 and we operated few changes on this lib.
>>
>> Did you really backport this change to the 4.10 branch? I'm not sure this
>> is really appropriate, it's a new feature, not a fix.
>
> Why not?
> compatiblity isn't guaranteed beyond kdelibs/kdepimlibs, see also
>
http://techbase.kde.org/Policies/Draft/Binary_And_Source_Compatibility_Policy#Binary_Compatibility_Guarantee


Nevermind, just noticed the "this is only a draft" markings on that
page/url.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Veaceslav Munteanu
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Veaceslav Munteanu
In reply to this post by Marcel Wiesweg
On Sun, Mar 3, 2013 at 10:49 PM, Marcel Wiesweg <[hidden email]> wrote:
>
>
>> Please use the private libs, new version of libkexiv2 is comming with
>> KDE 4.10.2 and we operated few changes on this lib.
>
> Did you really backport this change to the 4.10 branch? I'm not sure this is
> really appropriate, it's a new feature, not a fix.

Marcel, I don't understand...

I changes in libkexiv2 are needed for writting picassa faces and as
Gilles suggested I increased API/ABI count of the libkexiv.
Also I began to commit some pieces of code that is tested and work,
because implementing rotations, I touch to much files so I will get a
too big to review patch...If you want I can roll back the changes that
won't make digikam not to compile with shared libkexiv...


--
Veaceslav
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Gilles Caulier-4
This is my response from private mail with Veaceslav :

I think you don't need to back-port you patch in libkexiv2 from KDE 4.10 branch... In fact you cannot back-port your patch and KDE 4.10 must preserve binary compatibility. Your patch break BC due to new methods add in library

Don't forget that libkexiv2 is hosted in kdegraphics, which is a KDE component, released officially with KDE. Sure digiKam, because it's don't release at the same KDE time, it include last libkexiv2 code, but packagers can disable to use this library from digiKam tarball and use official libkexiv2 from KDE instead.

This is the same workflow from libkipi and libkdcraw.

Currently, your patch from libkexiv2 will be included with KDE 4.11. To be sure that digiKam can be compiled with libkexiv2 from KDE 4.10, you need to wrap your code from Digikam::DMetadata class into conditional pre-processor rules, checking libkexiv2 version ID shared with libkexiv2/version.h. It's very easy to do...

Gilles


2013/3/4 Veaceslav Munteanu <[hidden email]>
On Sun, Mar 3, 2013 at 10:49 PM, Marcel Wiesweg <[hidden email]> wrote:
>
>
>> Please use the private libs, new version of libkexiv2 is comming with
>> KDE 4.10.2 and we operated few changes on this lib.
>
> Did you really backport this change to the 4.10 branch? I'm not sure this is
> really appropriate, it's a new feature, not a fix.

Marcel, I don't understand...

I changes in libkexiv2 are needed for writting picassa faces and as
Gilles suggested I increased API/ABI count of the libkexiv.
Also I began to commit some pieces of code that is tested and work,
because implementing rotations, I touch to much files so I will get a
too big to review patch...If you want I can roll back the changes that
won't make digikam not to compile with shared libkexiv...


--
Veaceslav
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Veaceslav Munteanu
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Does current git compile with KDE SC 4.10's kdegrphics libs?

Veaceslav Munteanu
On Mon, Mar 4, 2013 at 8:10 AM, Gilles Caulier <[hidden email]> wrote:

> This is my response from private mail with Veaceslav :
>
> I think you don't need to back-port you patch in libkexiv2 from KDE 4.10
> branch... In fact you cannot back-port your patch and KDE 4.10 must preserve
> binary compatibility. Your patch break BC due to new methods add in library
>
> Don't forget that libkexiv2 is hosted in kdegraphics, which is a KDE
> component, released officially with KDE. Sure digiKam, because it's don't
> release at the same KDE time, it include last libkexiv2 code, but packagers
> can disable to use this library from digiKam tarball and use official
> libkexiv2 from KDE instead.
>
> This is the same workflow from libkipi and libkdcraw.
>
> Currently, your patch from libkexiv2 will be included with KDE 4.11. To be
> sure that digiKam can be compiled with libkexiv2 from KDE 4.10, you need to
> wrap your code from Digikam::DMetadata class into conditional pre-processor
> rules, checking libkexiv2 version ID shared with libkexiv2/version.h. It's
> very easy to do...
>
> Gilles
>

Fixed. Now digikam should compile with older libs. Let me know if
there are other incompatibility issues with dmetadata.cpp

--
Veaceslav
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Free forum by Nabble Edit this page