Hello,
discovered another error in noisereduction.cpp, that caused vertical
smear in images.
This bug causes, that horicontal edge detection buffer is used as
template for vertical blurring operation, thats bad ;-)
It differs from gimp version.
Patch appended.
This patch should give doubled image quality, the same as in gimp plugin.
In preparation for 2-dimensional filtering I rewrote the gaussian filter
and published this as
dcamnoise2-0.64 in gimp registry.
<
http://registry.gimp.org/plugin?id=5610>
It turned out, that the new filter gives much better sharpness. I tried
to port this to digikamimageplugins,
but had no success until now, it crashed (memory leaks ;-) . I am
working on it.
Another theme:
Is user interface broken?
While debugging I had the problem, that mousepointer stays connected
with the gamma rubber.
That means, I remove the mouse from gamma rubber and the rubber still
is connected to mouse.
(Excuse my english, if you don't understand, please ask, I will try to
explain better)
greetings,
Peter
Index: noisereduction.cpp
===================================================================
--- noisereduction.cpp (Revision 534213)
+++ noisereduction.cpp (Arbeitskopie)
@@ -149,7 +149,7 @@
memcpy(src + n*bytes, destPR + (col + width*n)*bytes, bytes);
for (int n = 0 ; n < height ; n++)
- memcpy(dest + n*bytes, destPR + (col + width*n)*bytes, bytes);
+ memcpy(dest + n*bytes, srcPR + (col + width*n)*bytes, bytes);
blur_line (data+w, data2+w, buffer+w, rbuf+w, tbuf+w, src, dest, height);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Locked
