[Digikam-devel] extragear/libs

[Gilles Caulier-2]

SVN commit 627390 by cgilles:

New common library witch will be used by digiKam and kipi-plugins to handle Pictures metadata (Exif/Iptc).

This shared library is a wrapper around Exiv2 library. It give a Qt like interface to control
Exiv2 actions on pictures. Using this library will remove all duplicate code on kipi-plugins::exiv2iface and
digikam::dmetadata.

The current implementation is the same than kipi-plugins/exiv2iface. This library is not yet used in digiKam/kipi-plugins.
We will added a new depency to this library in kipi-plugins in first and later to digiKam.

CCMAIL: [hidden email], [hidden email], [hidden email]



 A             libkexiv2 (directory)  
 A             libkexiv2/AUTHORS  
 A             libkexiv2/COPYING  
 A             libkexiv2/ChangeLog  
 A             libkexiv2/INSTALL  
 A             libkexiv2/Makefile.am  
 A             libkexiv2/NEWS  
 A             libkexiv2/README  
 A             libkexiv2/configure.in.in  
 A             libkexiv2/exiv2iface.cpp   kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
 A             libkexiv2/exiv2iface.h   kipi-plugins/common/exiv2iface/exiv2iface.h#627389
 A             libkexiv2/libkexiv2.lsm  
 A             libkexiv2/libkexiv2.pc.in  
 A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+) (wrong address)]


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Alle 13:55, venerdì 26 gennaio 2007, Gilles Caulier ha scritto:

> SVN commit 627390 by cgilles:
>
> New common library witch will be used by digiKam and kipi-plugins to handle Pictures metadata (Exif/Iptc).
>
> This shared library is a wrapper around Exiv2 library. It give a Qt like interface to control
> Exiv2 actions on pictures. Using this library will remove all duplicate code on kipi-plugins::exiv2iface and
> digikam::dmetadata.
>
> The current implementation is the same than kipi-plugins/exiv2iface. This library is not yet used in digiKam/kipi-plugins.
> We will added a new depency to this library in kipi-plugins in first and later to digiKam.
>
> CCMAIL: [hidden email], [hidden email], [hidden email]
>
>
>
>  A             libkexiv2 (directory)  
>  A             libkexiv2/AUTHORS  
>  A             libkexiv2/COPYING  
>  A             libkexiv2/ChangeLog  
>  A             libkexiv2/INSTALL  
>  A             libkexiv2/Makefile.am  
>  A             libkexiv2/NEWS  
>  A             libkexiv2/README  
>  A             libkexiv2/configure.in.in  
>  A             libkexiv2/exiv2iface.cpp   kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
>  A             libkexiv2/exiv2iface.h   kipi-plugins/common/exiv2iface/exiv2iface.h#627389
>  A             libkexiv2/libkexiv2.lsm  
>  A             libkexiv2/libkexiv2.pc.in  
>  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+) (wrong address)]

Are you sure that is the right way to? In such a way we removed libkexif to have libkexiv.

That means another package to maintain and another dependency. I'd expexted
an internal kipi-plugins lib instead...
Just a thought of course.

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Friday, 26. January 2007 15:06, Angelo Naselli wrote:

> Alle 13:55, venerdì 26 gennaio 2007, Gilles Caulier ha scritto:
> > SVN commit 627390 by cgilles:
> >
> > New common library witch will be used by digiKam and kipi-plugins to handle Pictures metadata (Exif/Iptc).
> >
> > This shared library is a wrapper around Exiv2 library. It give a Qt like interface to control
> > Exiv2 actions on pictures. Using this library will remove all duplicate code on kipi-plugins::exiv2iface and
> > digikam::dmetadata.
> >
> > The current implementation is the same than kipi-plugins/exiv2iface. This library is not yet used in digiKam/kipi-plugins.
> > We will added a new depency to this library in kipi-plugins in first and later to digiKam.
> >
> > CCMAIL: [hidden email], [hidden email], [hidden email]
> >
> >
> >
> >  A             libkexiv2 (directory)  
> >  A             libkexiv2/AUTHORS  
> >  A             libkexiv2/COPYING  
> >  A             libkexiv2/ChangeLog  
> >  A             libkexiv2/INSTALL  
> >  A             libkexiv2/Makefile.am  
> >  A             libkexiv2/NEWS  
> >  A             libkexiv2/README  
> >  A             libkexiv2/configure.in.in  
> >  A             libkexiv2/exiv2iface.cpp   kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
> >  A             libkexiv2/exiv2iface.h   kipi-plugins/common/exiv2iface/exiv2iface.h#627389
> >  A             libkexiv2/libkexiv2.lsm  
> >  A             libkexiv2/libkexiv2.pc.in  
> >  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+) (wrong address)]
> Are you sure that is the right way to? In such a way we removed libkexif to have libkexiv.
> That means another package to maintain and another dependency. I'd expexted
> an internal kipi-plugins lib instead...
> Just a thought of course.

As digikam and kipi-plugins will use it (and maybe later other kipi apps
or other image apps) it makes sense to do as standalone deb, like
libkipi is not in kipi-plugins.

In general IMHO we need more libs than more apps :)

Achim
>
> Angelo
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 26 Janvier 2007 18:09, Achim Bohnet a écrit :

> On Friday, 26. January 2007 15:06, Angelo Naselli wrote:
> > Alle 13:55, venerdì 26 gennaio 2007, Gilles Caulier ha scritto:
> > > SVN commit 627390 by cgilles:
> > >
> > > New common library witch will be used by digiKam and kipi-plugins to
> > > handle Pictures metadata (Exif/Iptc).
> > >
> > > This shared library is a wrapper around Exiv2 library. It give a Qt
> > > like interface to control Exiv2 actions on pictures. Using this library
> > > will remove all duplicate code on kipi-plugins::exiv2iface and
> > > digikam::dmetadata.
> > >
> > > The current implementation is the same than kipi-plugins/exiv2iface.
> > > This library is not yet used in digiKam/kipi-plugins. We will added a
> > > new depency to this library in kipi-plugins in first and later to
> > > digiKam.
> > >
> > > CCMAIL: [hidden email], [hidden email],
> > > [hidden email]
> > >
> > >
> > >
> > >  A             libkexiv2 (directory)
> > >  A             libkexiv2/AUTHORS
> > >  A             libkexiv2/COPYING
> > >  A             libkexiv2/ChangeLog
> > >  A             libkexiv2/INSTALL
> > >  A             libkexiv2/Makefile.am
> > >  A             libkexiv2/NEWS
> > >  A             libkexiv2/README
> > >  A             libkexiv2/configure.in.in
> > >  A             libkexiv2/exiv2iface.cpp  
> > > kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389 A            
> > > libkexiv2/exiv2iface.h  
> > > kipi-plugins/common/exiv2iface/exiv2iface.h#627389 A            
> > > libkexiv2/libkexiv2.lsm
> > >  A             libkexiv2/libkexiv2.pc.in
> > >  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+)
> > > (wrong address)]
> >
> > Are you sure that is the right way to? In such a way we removed libkexif
> > to have libkexiv. That means another package to maintain and another
> > dependency. I'd expexted an internal kipi-plugins lib instead...
> > Just a thought of course.
>
> As digikam and kipi-plugins will use it (and maybe later other kipi apps
> or other image apps) it makes sense to do as standalone deb, like
> libkipi is not in kipi-plugins.
>
> In general IMHO we need more libs than more apps :)
>
> Achim

Right Achim,

I have contacted Jesper to use it into KphotoAlbum. He already use Exiv2 in
KphotoAlbum core, but using a shared implementation can be a right way...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Op vr 26 jan 2007 18:09 schreef u:

> On Friday, 26. January 2007 15:06, Angelo Naselli wrote:
> > Alle 13:55, venerdì 26 gennaio 2007, Gilles Caulier ha scritto:
> > > SVN commit 627390 by cgilles:
> > >
> > > New common library witch will be used by digiKam and kipi-plugins to handle
> Pictures metadata (Exif/Iptc).
> > >
> > > This shared library is a wrapper around Exiv2 library. It give a Qt like
> interface to control
> > > Exiv2 actions on pictures. Using this library will remove all duplicate
> code on kipi-plugins::exiv2iface and
> > > digikam::dmetadata.
> > >
> > > The current implementation is the same than kipi-plugins/exiv2iface. This
> library is not yet used in digiKam/kipi-plugins.
> > > We will added a new depency to this library in kipi-plugins in first and
> later to digiKam.
> > >
> > > CCMAIL: [hidden email], [hidden email], [hidden email]
> > >
> > >
> > >
> > >  A             libkexiv2 (directory)  
> > >  A             libkexiv2/AUTHORS  
> > >  A             libkexiv2/COPYING  
> > >  A             libkexiv2/ChangeLog  
> > >  A             libkexiv2/INSTALL  
> > >  A             libkexiv2/Makefile.am  
> > >  A             libkexiv2/NEWS  
> > >  A             libkexiv2/README  
> > >  A             libkexiv2/configure.in.in  
> > >  A             libkexiv2/exiv2iface.cpp  
> kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
> > >  A             libkexiv2/exiv2iface.h  
> kipi-plugins/common/exiv2iface/exiv2iface.h#627389
> > >  A             libkexiv2/libkexiv2.lsm  
> > >  A             libkexiv2/libkexiv2.pc.in  
> > >  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+) (wrong
> address)]
> > Are you sure that is the right way to? In such a way we removed libkexif to
> have libkexiv.
> > That means another package to maintain and another dependency. I'd expexted
> > an internal kipi-plugins lib instead...
> > Just a thought of course.
>
> As digikam and kipi-plugins will use it (and maybe later other kipi apps
> or other image apps) it makes sense to do as standalone deb, like
> libkipi is not in kipi-plugins.
>
> In general IMHO we need more libs than more apps :)

What i find weird in the sources is this comment:
---------------
 * NOTE: This class is a simplified version of Digikam::DMetadata
 *       class from digiKam core. Please contact digiKam team
 *       before to change/fix/improve this implementation.
---------------

Sounds like we are duplicating code and making it a maintainance nightmare.  

Nobody is waiting to maintain this package, so my question is simple: who is going to generate packages for this library??

Toma


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 26 Janvier 2007 18:20, Tom Albers a écrit :

> Op vr 26 jan 2007 18:09 schreef u:
> > On Friday, 26. January 2007 15:06, Angelo Naselli wrote:
> > > Alle 13:55, venerd� 26 gennaio 2007, Gilles Caulier ha scritto:
> > > > SVN commit 627390 by cgilles:
> > > >
> > > > New common library witch will be used by digiKam and kipi-plugins to
> > > > handle
> >
> > Pictures metadata (Exif/Iptc).
> >
> > > > This shared library is a wrapper around Exiv2 library. It give a Qt
> > > > like
> >
> > interface to control
> >
> > > > Exiv2 actions on pictures. Using this library will remove all
> > > > duplicate
> >
> > code on kipi-plugins::exiv2iface and
> >
> > > > digikam::dmetadata.
> > > >
> > > > The current implementation is the same than kipi-plugins/exiv2iface.
> > > > This
> >
> > library is not yet used in digiKam/kipi-plugins.
> >
> > > > We will added a new depency to this library in kipi-plugins in first
> > > > and
> >
> > later to digiKam.
> >
> > > > CCMAIL: [hidden email], [hidden email],
> > > > [hidden email]
> > > >
> > > >
> > > >
> > > >  A             libkexiv2 (directory)
> > > >  A             libkexiv2/AUTHORS
> > > >  A             libkexiv2/COPYING
> > > >  A             libkexiv2/ChangeLog
> > > >  A             libkexiv2/INSTALL
> > > >  A             libkexiv2/Makefile.am
> > > >  A             libkexiv2/NEWS
> > > >  A             libkexiv2/README
> > > >  A             libkexiv2/configure.in.in
> > > >  A             libkexiv2/exiv2iface.cpp
> >
> > kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
> >
> > > >  A             libkexiv2/exiv2iface.h
> >
> > kipi-plugins/common/exiv2iface/exiv2iface.h#627389
> >
> > > >  A             libkexiv2/libkexiv2.lsm
> > > >  A             libkexiv2/libkexiv2.pc.in
> > > >  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+)
> > > > (wrong
> >
> > address)]
> >
> > > Are you sure that is the right way to? In such a way we removed
> > > libkexif to
> >
> > have libkexiv.
> >
> > > That means another package to maintain and another dependency. I'd
> > > expexted an internal kipi-plugins lib instead...
> > > Just a thought of course.
> >
> > As digikam and kipi-plugins will use it (and maybe later other kipi apps
> > or other image apps) it makes sense to do as standalone deb, like
> > libkipi is not in kipi-plugins.
> >
> > In general IMHO we need more libs than more apps :)
>
> What i find weird in the sources is this comment:
> ---------------
>  * NOTE: This class is a simplified version of Digikam::DMetadata
>  *       class from digiKam core. Please contact digiKam team
>  *       before to change/fix/improve this implementation.
> ---------------
>
> Sounds like we are duplicating code and making it a maintainance nightmare.

no... Look my commit comments before. The common source code in kipi-plugins
and digiKam will be removed...

also the comments libkexiv2 header is obsolete. it comme from
Kipi-plugins::Exiv2Iface class ! This is the reason the do a shared lib. It's
a nightmare to maintain Kipi-plugins::Exiv2Iface and Digikam::DMetadata
class...

I will personally fix kipi-plugins and digiKam in this way.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 26 Janvier 2007 18:20, Tom Albers a écrit :

> Op vr 26 jan 2007 18:09 schreef u:
> > On Friday, 26. January 2007 15:06, Angelo Naselli wrote:
> > > Alle 13:55, venerd� 26 gennaio 2007, Gilles Caulier ha scritto:
> > > > SVN commit 627390 by cgilles:
> > > >
> > > > New common library witch will be used by digiKam and kipi-plugins to
> > > > handle
> >
> > Pictures metadata (Exif/Iptc).
> >
> > > > This shared library is a wrapper around Exiv2 library. It give a Qt
> > > > like
> >
> > interface to control
> >
> > > > Exiv2 actions on pictures. Using this library will remove all
> > > > duplicate
> >
> > code on kipi-plugins::exiv2iface and
> >
> > > > digikam::dmetadata.
> > > >
> > > > The current implementation is the same than kipi-plugins/exiv2iface.
> > > > This
> >
> > library is not yet used in digiKam/kipi-plugins.
> >
> > > > We will added a new depency to this library in kipi-plugins in first
> > > > and
> >
> > later to digiKam.
> >
> > > > CCMAIL: [hidden email], [hidden email],
> > > > [hidden email]
> > > >
> > > >
> > > >
> > > >  A             libkexiv2 (directory)
> > > >  A             libkexiv2/AUTHORS
> > > >  A             libkexiv2/COPYING
> > > >  A             libkexiv2/ChangeLog
> > > >  A             libkexiv2/INSTALL
> > > >  A             libkexiv2/Makefile.am
> > > >  A             libkexiv2/NEWS
> > > >  A             libkexiv2/README
> > > >  A             libkexiv2/configure.in.in
> > > >  A             libkexiv2/exiv2iface.cpp
> >
> > kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
> >
> > > >  A             libkexiv2/exiv2iface.h
> >
> > kipi-plugins/common/exiv2iface/exiv2iface.h#627389
> >
> > > >  A             libkexiv2/libkexiv2.lsm
> > > >  A             libkexiv2/libkexiv2.pc.in
> > > >  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+)
> > > > (wrong
> >
> > address)]
> >
> > > Are you sure that is the right way to? In such a way we removed
> > > libkexif to
> >
> > have libkexiv.
> >
> > > That means another package to maintain and another dependency. I'd
> > > expexted an internal kipi-plugins lib instead...
> > > Just a thought of course.
> >
> > As digikam and kipi-plugins will use it (and maybe later other kipi apps
> > or other image apps) it makes sense to do as standalone deb, like
> > libkipi is not in kipi-plugins.
> >
> > In general IMHO we need more libs than more apps :)
>
> What i find weird in the sources is this comment:
> ---------------
>  * NOTE: This class is a simplified version of Digikam::DMetadata
>  *       class from digiKam core. Please contact digiKam team
>  *       before to change/fix/improve this implementation.
> ---------------
>
> Sounds like we are duplicating code and making it a maintainance nightmare.
>
> Nobody is waiting to maintain this package, so my question is simple: who
> is going to generate packages for this library??
>
> Toma

And look like ShowImg use a copy of the digiKam core Exiv2 interface
(DMetadata class) :

http://websvn.kde.org/trunk/extragear/graphics/showimg/showimg/metadata/dmetadata.cpp?rev=595799&view=auto

Witch is the same than :

http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp?rev=627043&view=auto

and where the kipi-plugins Exiv2Iface class is a simplified one :

http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/common/exiv2iface/exiv2iface.cpp?rev=627061&view=auto

...It time to _UNIFIED_ all this world with a shared library...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 26 Janvier 2007 19:14, Caulier Gilles(UNTRUSTED, sender is
<kde-imaging-bounces-+caulier.gilles=[hidden email]>) a écrit :
> And look like ShowImg use a copy of the digiKam core Exiv2 interface
> (DMetadata class) :
>
> http://websvn.kde.org/trunk/extragear/graphics/showimg/showimg/metadata/dme
>tadata.cpp?rev=595799&view=auto

Richard Groult, the ShowImg author, have reported to me than i will use this
library for the next Showimg version instead the duplicate DMetadata class
copied in core...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Alle 12:01, sabato 27 gennaio 2007, Caulier Gilles ha scritto:

> Le Vendredi 26 Janvier 2007 19:14, Caulier Gilles(UNTRUSTED, sender is
> <kde-imaging-bounces-+caulier.gilles=[hidden email]>) a écrit :
> > And look like ShowImg use a copy of the digiKam core Exiv2 interface
> > (DMetadata class) :
> >
> > http://websvn.kde.org/trunk/extragear/graphics/showimg/showimg/metadata/dme
> >tadata.cpp?rev=595799&view=auto
>
> Richard Groult, the ShowImg author, have reported to me than i will use this
> library for the next Showimg version instead the duplicate DMetadata class
> copied in core...
>
> Gilles

Ok in the next few days I will provide prepare/release scripts for it.

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Op za 27 jan 2007 12:01 schreef u:

> Le Vendredi 26 Janvier 2007 19:14, Caulier Gilles(UNTRUSTED, sender is
> <kde-imaging-bounces-+caulier.gilles=[hidden email]>) a écrit :
> > And look like ShowImg use a copy of the digiKam core Exiv2 interface
> > (DMetadata class) :
> >
> > http://websvn.kde.org/trunk/extragear/graphics/showimg/showimg/metadata/dme
> >tadata.cpp?rev=595799&view=auto
>
> Richard Groult, the ShowImg author, have reported to me than i will use this
> library for the next Showimg version instead the duplicate DMetadata class
> copied in core...

Ok, then a shared lib is logical!
The downside is that someone needs to make tarballs of it...

Toma


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel