[Digikam-devel] extragear/graphics/digikamimageplugins

[Marcel Wiesweg]

SVN commit 515753 by mwiesweg:

digikam from trunk:
Port "Infrared" plugin to DImg

Gilles: There are three places were the data is Gaussian blurred,
 lines 139, 210, 255 of infrared.cpp. Is this intentional?

CCMAIL: [hidden email]



 M  +1 -1      TODO  
 M  +5 -0      filmgrain/imageeffect_filmgrain.cpp  
 M  +2 -3      infrared/Makefile.am  
 M  +40 -33    infrared/imageeffect_infrared.cpp  
 M  +12 -10    infrared/imageeffect_infrared.h  
 M  +9 -4      infrared/imageplugin_infrared.cpp  
 M  +270 -144  infrared/infrared.cpp  
 M  +11 -19    infrared/infrared.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Samedi 4 Mars 2006 20:33, Marcel Wiesweg a écrit :
> SVN commit 515753 by mwiesweg:
>
> digikam from trunk:
> Port "Infrared" plugin to DImg
>
> Gilles: There are three places were the data is Gaussian blurred,
>  lines 139, 210, 255 of infrared.cpp. Is this intentional?
>

I have take a look in old implementation of infrared.cpp from stable branch
and the tutorial from gimpGuru :

http://www.gimpguru.org/Tutorials/SimulatedInfrared

We have blur calls at lines :

112 ==> correct
148 ==> correct
150 ==> uncorrect. certainly a wrong copy and paste from me
173 ==> uncorrect. idem...

In new implementation we have :

139 ==> correct
196 ==> correct
210 ==> uncorrect
255 ==> uncorrect

We need to check if the results are correct if lines 210 and 255 are removed.
Your viewpoints ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> We need to check if the results are correct if lines 210 and 255 are
> removed. Your viewpoints ?
>

I agree to remove these lines, results are still correct, to me it appears
that detailed image regions are not blurred as much which is good I think.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Dimanche 5 Mars 2006 19:08, Marcel Wiesweg a écrit :
> > We need to check if the results are correct if lines 210 and 255 are
> > removed. Your viewpoints ?
>
> I agree to remove these lines, results are still correct, to me it appears
> that detailed image regions are not blurred as much which is good I think.
>
> Marcel

ok Fixed in svn

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel