[Digikam-devel] extragear/graphics/digikam/utilities/setup

[F.J.Cruz]

SVN commit 521344 by fjcruz:

New setup parameter to storage preferences for managed view (colormanaged display) in I.E.

Work in progress -- useless.

CCMAIL:[hidden email]

 M  +23 -16    setupicc.cpp  


--- trunk/extragear/graphics/digikam/utilities/setup/setupicc.cpp #521343:521344
@@ -98,6 +98,7 @@
 
     QCheckBox       *enableColorManagement;
     QCheckBox       *bpcAlgorithm;
+    QCheckBox       *managedView;
     
     QRadioButton    *defaultApplyICC;
     QRadioButton    *defaultAskICC;
@@ -221,7 +222,21 @@
 
     layout->addWidget(profiles);
 
+     // --------------------------------------------------------
+    
+    QVGroupBox * mv = new QVGroupBox(i18n("Colormanaged View"), parent);
+
+    d->managedView = new QCheckBox(mv);
+    d->managedView->setText(i18n("Use Colormanaged view."));
+    QWhatsThis::add( d->managedView, i18n("<p>You have to use this option if "
+    "you want to use your Monitor Color Profile to show your pictures in "
+    "Image Editor window.</p>"));
+    
+    layout->addWidget(mv);
+    
     // --------------------------------------------------------
+
+    // --------------------------------------------------------
     
     QVGroupBox * bpc = new QVGroupBox(i18n("BPC Algorithm"), parent);
 
@@ -322,17 +337,7 @@
     {
         config->writeEntry("BehaviourICC", false);
     }
-//     config->writeEntry("ApplyICC", d->defaultApplyICC->isChecked());
-//     config->writeEntry("AskICC", d->defaultAskICC->isChecked());
-//     if (d->defaultPathKU->url().isEmpty())
-//     {
-//         QString message = QString(i18n("<p>You must set a default path to color profiles files.</p>"));
-//         message.append(i18n("<p>This settings will not be written.</p>"));
-//         KMessageBox::error(this, message );
-//         config->writeEntry("EnableCM", false);
-//         config->sync();
-//         return;
-//     }
+
     config->writePathEntry("DefaultPath", d->defaultPathKU->url());
     config->writeEntry("WorkSpaceProfile", d->workProfilesKC->currentItem());
     config->writeEntry("MonitorProfile", d->monitorProfilesKC->currentItem());
@@ -344,7 +349,8 @@
     config->writePathEntry("WorkProfileFile", d->workICCFiles_file[d->workProfilesKC->currentItem()]);
     config->writePathEntry("MonitorProfileFile", d->monitorICCFiles_file[d->monitorProfilesKC->currentItem()]);
     config->writePathEntry("ProofProfileFile", d->proofICCFiles_file[d->proofProfilesKC->currentItem()]);
-
+    config->writeEntry("ManagedView", d->managedView->isChecked());
+    
     config->sync();
 }
 
@@ -382,10 +388,8 @@
     d->ICCPath["WorkProfile"] = config->readPathEntry("WorkProfileFile");
     d->ICCPath["MonitorProfile"] = config->readPathEntry("MonitorProfileFile");
     d->ICCPath["ProofProfile"] = config->readPathEntry("ProofProfileFile");
-    kdDebug() << "Profile Path: " << d->ICCPath["InProfile"] << endl;
-    kdDebug() << "Profile Path: " << d->ICCPath["WorkProfile"] << endl;
-    kdDebug() << "Profile Path: " << d->ICCPath["MonitorProfile"] << endl;
-    kdDebug() << "Profile Path: " << d->ICCPath["ProofProfile"] << endl;
+    d->managedView->setChecked(config->readBoolEntry("ManagedView", false));
+
 }
 
 void SetupICC::fillCombos()
@@ -503,6 +507,8 @@
 {
     d->bpcAlgorithm->setEnabled(t);
     d->bpcAlgorithm->setChecked(t);
+
+    d->managedView->setChecked(t);
 
     d->defaultApplyICC->setEnabled(t);
     d->defaultAskICC->setEnabled(t);
@@ -548,6 +554,7 @@
         d->ICCPath["WorkProfile"] = config->readPathEntry("WorkProfileFile");
         d->ICCPath["MonitorProfile"] = config->readPathEntry("MonitorProfileFile");
         d->ICCPath["ProofProfile"] = config->readPathEntry("ProofProfileFile");
+        d->managedView->setChecked(config->readBoolEntry("ManagedView", false));
     }
 }
 
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mercredi 22 Mars 2006 12:42 PM, Francisco J. Cruz a écrit :
> SVN commit 521344 by fjcruz:
>
> New setup parameter to storage preferences for managed view (colormanaged
> display) in I.E.
>
> Work in progress -- useless.
>

Paco, i will finalize dcraw decoding option to add :

- noise reduction decoding option ('-B').
- using embeded ICC profile in RAW file during decoding.

About the last one, where do you want to see the option ? In ICC profile setup
page, or in RAW decoding setup page ?

A nice day

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[F.J.Cruz]

---- Caulier Gilles <[hidden email]> escribió:

> Le Mercredi 22 Mars 2006 12:42 PM, Francisco J. Cruz a écrit :
> > SVN commit 521344 by fjcruz:
> >
> > New setup parameter to storage preferences for managed view (colormanaged
> > display) in I.E.
> >
> > Work in progress -- useless.
> >
>
> Paco, i will finalize dcraw decoding option to add :
>
> - noise reduction decoding option ('-B').
> - using embeded ICC profile in RAW file during decoding.
>
> About the last one, where do you want to see the option ? In ICC profile setup
> page, or in RAW decoding setup page ?
>
> A nice day
>
> Gilles

Hi Gilles,

That's a good question :-). I think it'd be raseonable to put it in RAW setup page, something like:

"Use default in/out profiles from ICC profiles setup - select another ones"

What do you think about this?

Mmmmm, I have some doubts about new convertTopixma method, maybe I make you some questions when I arrive at home ;-).

Paco.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Wednesday 22 March 2006 01:48 pm, you wrote:

> ---- Caulier Gilles <[hidden email]> escribió:
> > Le Mercredi 22 Mars 2006 12:42 PM, Francisco J. Cruz a écrit :
> > > SVN commit 521344 by fjcruz:
> > >
> > > New setup parameter to storage preferences for managed view
> > > (colormanaged display) in I.E.
> > >
> > > Work in progress -- useless.
> >
> > Paco, i will finalize dcraw decoding option to add :
> >
> > - noise reduction decoding option ('-B').
> > - using embeded ICC profile in RAW file during decoding.
> >
> > About the last one, where do you want to see the option ? In ICC profile
> > setup page, or in RAW decoding setup page ?
> >
> > A nice day
> >
> > Gilles
>
> Hi Gilles,
>
> That's a good question :-). I think it'd be raseonable to put it in RAW
> setup page, something like:
>
> "Use default in/out profiles from ICC profiles setup - select another ones"
>
> What do you think about this?

You want said that we will to delegate ICC profile color transformations to
dcraw with RAW file... following these options :

1- dcraw use the ICC profile file setup from digikam...

or

2- dcraw try to you use the embeded ICC profile into RAW file if exist.

Right ?


>
> Mmmmm, I have some doubts about new convertTopixma method, maybe I make you
> some questions when I arrive at home ;-).

no problem. Let's me hear

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel