[Digikam-devel] extragear/graphics/digikam

[Guillaume Laurent]

SVN commit 539687 by glaurent:

- moved listbox related classes to their own files in digikam/libs/widgets/imageplugins
- use thumbnail previews in autocorrection plugin as well
- make previews reflect curves/contrast changes in bw plugin

CCMAIL: [hidden email]



 M  +57 -32    imageplugins/imageeffect_autocorrection.cpp  
 M  +6 -2      imageplugins/imageeffect_autocorrection.h  
 M  +110 -56   imageplugins/imageeffect_bwsepia.cpp  
 M  +12 -1     imageplugins/imageeffect_bwsepia.h  
 M  +1 -1      libs/dialogs/imagedlgbase.h  
 M  +2 -1      libs/widgets/imageplugins/Makefile.am  
 A             libs/widgets/imageplugins/listboxpreviewitem.cpp   [License: GPL]
 A             libs/widgets/imageplugins/listboxpreviewitem.h   [License: GPL]
 A             libs/widgets/imageplugins/listboxwhatsthis.cpp   [License: GPL]
 A             libs/widgets/imageplugins/listboxwhatsthis.h   [License: GPL]


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 11 May 2006 03:23 pm, Guillaume Laurent wrote:

> SVN commit 539687 by glaurent:
>
> - moved listbox related classes to their own files in
> digikam/libs/widgets/imageplugins - use thumbnail previews in
> autocorrection plugin as well
> - make previews reflect curves/contrast changes in bw plugin
>
> CCMAIL: [hidden email]
>
>
>
>  M  +57 -32    imageplugins/imageeffect_autocorrection.cpp
>  M  +6 -2      imageplugins/imageeffect_autocorrection.h
>  M  +110 -56   imageplugins/imageeffect_bwsepia.cpp
>  M  +12 -1     imageplugins/imageeffect_bwsepia.h
>  M  +1 -1      libs/dialogs/imagedlgbase.h
>  M  +2 -1      libs/widgets/imageplugins/Makefile.am
>  A             libs/widgets/imageplugins/listboxpreviewitem.cpp   [License:
> GPL] A             libs/widgets/imageplugins/listboxpreviewitem.h  
> [License: GPL] A             libs/widgets/imageplugins/listboxwhatsthis.cpp
>   [License: GPL] A             libs/widgets/imageplugins/listboxwhatsthis.h
>   [License: GPL]
>
>

Into the QListBox, why the items cannot give a contextual menu relevant of
WhatThis informations when you use right mouse button ? This way work fine
into histogram area, why not into QlistBox ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 11 May 2006 03:23 pm, Guillaume Laurent wrote:

> SVN commit 539687 by glaurent:
>
> - moved listbox related classes to their own files in
> digikam/libs/widgets/imageplugins - use thumbnail previews in
> autocorrection plugin as well
> - make previews reflect curves/contrast changes in bw plugin
>
> CCMAIL: [hidden email]
>
>
>
>  M  +57 -32    imageplugins/imageeffect_autocorrection.cpp
>  M  +6 -2      imageplugins/imageeffect_autocorrection.h
>  M  +110 -56   imageplugins/imageeffect_bwsepia.cpp
>  M  +12 -1     imageplugins/imageeffect_bwsepia.h
>  M  +1 -1      libs/dialogs/imagedlgbase.h
>  M  +2 -1      libs/widgets/imageplugins/Makefile.am
>  A             libs/widgets/imageplugins/listboxpreviewitem.cpp   [License:
> GPL] A             libs/widgets/imageplugins/listboxpreviewitem.h  
> [License: GPL] A             libs/widgets/imageplugins/listboxwhatsthis.cpp
>   [License: GPL] A             libs/widgets/imageplugins/listboxwhatsthis.h
>   [License: GPL]
>

Forget to said : Good job Guillaume. I love it (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 11 May 2006 03:23 pm, Guillaume Laurent wrote:

> SVN commit 539687 by glaurent:
>
> - moved listbox related classes to their own files in
> digikam/libs/widgets/imageplugins - use thumbnail previews in
> autocorrection plugin as well
> - make previews reflect curves/contrast changes in bw plugin
>
> CCMAIL: [hidden email]
>
>
>
>  M  +57 -32    imageplugins/imageeffect_autocorrection.cpp
>  M  +6 -2      imageplugins/imageeffect_autocorrection.h
>  M  +110 -56   imageplugins/imageeffect_bwsepia.cpp
>  M  +12 -1     imageplugins/imageeffect_bwsepia.h
>  M  +1 -1      libs/dialogs/imagedlgbase.h
>  M  +2 -1      libs/widgets/imageplugins/Makefile.am
>  A             libs/widgets/imageplugins/listboxpreviewitem.cpp   [License:
> GPL] A             libs/widgets/imageplugins/listboxpreviewitem.h  
> [License: GPL] A             libs/widgets/imageplugins/listboxwhatsthis.cpp
>   [License: GPL] A             libs/widgets/imageplugins/listboxwhatsthis.h
>   [License: GPL]
>

In DigikamImagePlugins, there are 3 plugins witch can be use your widget :

- AddBorder.
- DistorsionFX.
- BlurFx.

Take a care, Distorsion and BlurFx take a while to render preview. Not sure
that we can use your implementation at these places. There is no technical
problem with AddBorder normally

Give me your viewpoints...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Guillaume Laurent]

On Thursday 11 May 2006 15:37, Gilles Caulier wrote:
>
> Into the QListBox, why the items cannot give a contextual menu relevant of
> WhatThis informations when you use right mouse button ? This way work fine
> into histogram area, why not into QlistBox ?

It's certainly doable, but from a UI point of view I have to say I find this
rather atypical. RMB menu doesn't carry help information usually, one expects
to find functions in it.

--
Guillaume.
http://www.telegraph-road.org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Guillaume Laurent]

On Thursday 11 May 2006 15:38, Gilles Caulier wrote:

> Forget to said : Good job Guillaume. I love it (:=)))

Thanks :-).

On Thursday 11 May 2006 15:46, Gilles Caulier wrote:

>
> In DigikamImagePlugins, there are 3 plugins witch can be use your widget :
>
> - AddBorder.
> - DistorsionFX.
> - BlurFx.
>
> Take a care, Distorsion and BlurFx take a while to render preview. Not sure
> that we can use your implementation at these places. There is no technical
> problem with AddBorder normally

I'll try to take a look.

--
Guillaume.
http://www.telegraph-road.org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Guillaume Laurent]

On Thursday 11 May 2006 15:58, Guillaume Laurent wrote:

> On Thursday 11 May 2006 15:46, Gilles Caulier wrote:
> > In DigikamImagePlugins, there are 3 plugins witch can be use your widget
> > :
> >
> > - AddBorder.
> > - DistorsionFX.
> > - BlurFx.
> >
> > Take a care, Distorsion and BlurFx take a while to render preview. Not
> > sure that we can use your implementation at these places. There is no
> > technical problem with AddBorder normally
>
> I'll try to take a look.

update : I won't realistically have the time to work on this before a while,
sorry :-(.

--
Guillaume.
http://www.telegraph-road.org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel