[Digikam-devel] extragear/graphics/digikam

[Marcel Wiesweg]

SVN commit 529254 by mwiesweg:

digikam from trunk:

The ImageEditor can now access the database independently
from main view, i.e. also if main moved to a different directory.

- adjust ImageInfo to be more like a database item wrapper class
- add a method to ImageWindow to start it with a list of
  ImageInfo objects, use this in AlbumIconView
- adapt ImageWindow to (optional) ImageInfo list
- adjust behavior of saveAsIsComplete
- add itemChanged methods to ImagePropertiesSidebarDB:
  - one takes only a URL (no database)
  - one takes an ImageInfo object (used by ImageWindow, full DB support)
  - one takes AlbumIconItem and -View (used by main view,
    full DB support, optional future interaction with the view)
- ImageDescEditTab now works on an ImageInfo object
- add a copyItem method to ImageInfo as a wrapper for said function from AlbumDB
- modify AlbumDB::copyItem to return image id of inserted image
- add DISTINCT keyword to second SELECT statement of AlbumDB::copyItem.
  With all of above changes, I constantly produced bug #113915.
  I do not know why the SELECT statement produces (in my case) three times
  the same result so that INSERT complains, and I do not know which of
  my changes should ever trigger this problem, but the DISTINCT fixes this.
  If anyone speaks SQL, you might want to check my comment in AlbumDB::copyItem.

Currently, the rating is not copied when database information is copied (in copyItem).
Should this be done?

CCBUG: 113915
CCMAIL: [hidden email]



 M  +19 -4     digikam/albumdb.cpp  
 M  +5 -3      digikam/albumdb.h  
 M  +17 -10    digikam/albumiconview.cpp  
 M  +2 -2      digikam/digikamview.cpp  
 M  +31 -0     digikam/imageinfo.cpp  
 M  +22 -7     digikam/imageinfo.h  
 M  +33 -35    libs/imageproperties/imagedescedittab.cpp  
 M  +13 -12    libs/imageproperties/imagedescedittab.h  
 M  +52 -22    libs/imageproperties/imagepropertiessidebardb.cpp  
 M  +22 -14    libs/imageproperties/imagepropertiessidebardb.h  
 M  +105 -70   utilities/imageeditor/editor/imagewindow.cpp  
 M  +12 -6     utilities/imageeditor/editor/imagewindow.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Wednesday 12 April 2006 11:53 pm, Marcel Wiesweg wrote:

> SVN commit 529254 by mwiesweg:
>
> digikam from trunk:
>
> The ImageEditor can now access the database independently
> from main view, i.e. also if main moved to a different directory.
>
> - adjust ImageInfo to be more like a database item wrapper class
> - add a method to ImageWindow to start it with a list of
>   ImageInfo objects, use this in AlbumIconView
> - adapt ImageWindow to (optional) ImageInfo list
> - adjust behavior of saveAsIsComplete
> - add itemChanged methods to ImagePropertiesSidebarDB:
>   - one takes only a URL (no database)
>   - one takes an ImageInfo object (used by ImageWindow, full DB support)
>   - one takes AlbumIconItem and -View (used by main view,
>     full DB support, optional future interaction with the view)
> - ImageDescEditTab now works on an ImageInfo object
> - add a copyItem method to ImageInfo as a wrapper for said function from
> AlbumDB - modify AlbumDB::copyItem to return image id of inserted image
> - add DISTINCT keyword to second SELECT statement of AlbumDB::copyItem.
>   With all of above changes, I constantly produced bug #113915.
>   I do not know why the SELECT statement produces (in my case) three times
>   the same result so that INSERT complains, and I do not know which of
>   my changes should ever trigger this problem, but the DISTINCT fixes this.
>   If anyone speaks SQL, you might want to check my comment in
> AlbumDB::copyItem.

I know SQL, but my database experience is limited. I have already build
database for web site, but i have never tried to optimize my database
requests. We need to investiguate this point. Please annoye B.K.O or TODO
file for that.

>
> Currently, the rating is not copied when database information is copied (in
> copyItem). Should this be done?
>

yes, rating must be copied is we move/copy a picture from an album to another
one.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel