[Digikam-devel] extragear/graphics/digikam/libs/dcraw [POSSIBLY UNSAFE]

[Gilles Caulier]

SVN commit 588214 by cgilles:

digikam from trunk : prepare to use an embedded dcraw binary version into digiKam

This is want mean that we can remove the external dcraw depency definitivly.
digiKAm will build and install a 'digikamdcraw' binary file witch can be used instead 'dcraw'

This way will solve all bug reported from users about uncompatible  dcraw command options.
When we want to update dcraw in digiKam, we just need to update the dcraw.c and test the
compatibility with all options used by digiKAm core.

To digikam team : please let's me here if this way is right for you. Thanks in advance.

CCMAIL: [hidden email]  



 M  +6 -5      Makefile.am  
 A             dcraw.c   [POSSIBLY UNSAFE: scanf] [License: GENERATED FILE]


--- trunk/extragear/graphics/digikam/libs/dcraw/Makefile.am #588213:588214
@@ -8,11 +8,12 @@
 
 libdcraw_la_LDFLAGS = $(all_libraries) $(KDE_RPATH)
 
-# binary
-#bin_PROGRAMS = digikamdcraw
+#-- dcraw binary -------------------------------------------------
 
-#digikamdcraw_CFLAGS = -w
+bin_PROGRAMS = digikamdcraw
 
-#digikamdcraw_SOURCES = dcraw.c
+dcraw.o: CFLAGS = -w
 
-#digikamdcraw_LDFLAGS = -O4 -lm -ljpeg -lcms
\ No newline at end of file
+digikamdcraw_SOURCES = dcraw.c
+
+digikamdcraw_LDFLAGS = $(all_libraries) $(LIBJPEG) $(LCMS_LIBS)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel